From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54B0BE776D1 for ; Mon, 2 Oct 2023 23:15:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B63338D001C; Mon, 2 Oct 2023 19:15:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B13A68D0003; Mon, 2 Oct 2023 19:15:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B3FC8D001C; Mon, 2 Oct 2023 19:15:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 89CF58D0003 for ; Mon, 2 Oct 2023 19:15:03 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4FB9014011B for ; Mon, 2 Oct 2023 23:15:03 +0000 (UTC) X-FDA: 81302078886.03.25319B9 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf18.hostedemail.com (Postfix) with ESMTP id 964761C000A for ; Mon, 2 Oct 2023 23:15:01 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SUotx8DF; spf=pass (imf18.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696288501; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=mOt3XSQtUEUA5CNWLdkquGCY/Lz/78GBxWkDuifhphU=; b=zmhPErHQwwfkmwkNnh93MxNHJSuSxEbiQyNXwfsYSmhPM2kG2qUUBjPPUfg13kLGyW1suL ewi0PvwI/qT9UL4f1StxLb4psEGYSvl0ao2EmUrmZ7RSBkwe1lAPkMIeHzNXBFWRlIBvim q4wOdWtahwfXtkf7YdxTAuMfPpjYkig= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SUotx8DF; spf=pass (imf18.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696288501; a=rsa-sha256; cv=none; b=eqzz5ywxC4P2NjYX371STv5Ugx/pbqW10Suswy7UXEDu8mOu+bhuBMIyai7h4q6vMlmhfq YfenVLs3Iny9ONATk6PdgurkEbtlSpHbUH1uUagJHWnuYZNE6D4saxpPqCdUYdICgl1Q1Y MUOuvd+kl7kZ9bQD3Rib3K9e7Qkuv0I= Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-405417465aaso3431575e9.1 for ; Mon, 02 Oct 2023 16:15:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696288500; x=1696893300; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mOt3XSQtUEUA5CNWLdkquGCY/Lz/78GBxWkDuifhphU=; b=SUotx8DFYC1vEPtU7qtyI+T4mhIsA3aEzu2dBYMEfHovYh7TjvcJpV6tOmEQVDuN52 CDVtAkKFr0Nz4AWStF+hb5dkAExTZmTJHwjvWlANfd7vR2gpxRDJxIxcPSAljFz0jKE7 p8Jx/a1uL6ErhCc7Q7KCY+SATdrPc3fnmVAVVSfhARv1k6sYoL0frD1ygFySKoWG5B5q bMsnFhoapwi5ozgLpJ2LNPytmZzdwnZFps1OfhdVqOVsESFQtcVj1Z6Go0Xtns7YCUNK Ydh/haUe2S3mksccVH2nWnyk/YFLRM0p+TqvGQlsxKj7Ql2qjj0MsYvh62MLFh28S3kX eJhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696288500; x=1696893300; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mOt3XSQtUEUA5CNWLdkquGCY/Lz/78GBxWkDuifhphU=; b=Odm0x2IhF1mANr2eGzQ38iSX16NW5GKDg//t3PB4+24wZcRS3UBidtmsDcQr/JUh7q XYhmCAVi98zPP04PgtSZhQDVnWroNbHklqCB7vDjEPayp//50muJDyzbxSsPlxBQ5W04 a4VSSG1ErThUtIRNKMXNcNv1pGaqwYrPsAld/QpB+Mu6exjggmH62HTTlfxxg12L9hpC Sqzisw9HuMZk8lRPsXBJvBRldWOFwXhMP3uY+RW2ZHJGwu8G6s9gcTvU1SM63N/K8CKQ noZrGLkuMpbDd6oq6rDdp8BQpmlpgrTXbi+xaYbaDO9Nm68sDnpryqyNiQpzdD54zgBe uWdQ== X-Gm-Message-State: AOJu0YwsdDQ/GIiSTtentU3wNcbcBBMS9bak+OfBm76Y9p0SmflGbaqF ZJTAgMGQMiuZ4aLUGhMSzotR9CT0Af4= X-Google-Smtp-Source: AGHT+IHWnytmP2BpQFox1Y7j1Ao8wc2rkcTlgLD3/VFtY2ODQJ53FA1ArPwBB6DUdfuWAo7yw+iOSw== X-Received: by 2002:a5d:5550:0:b0:309:1532:8287 with SMTP id g16-20020a5d5550000000b0030915328287mr11155438wrw.19.1696288499527; Mon, 02 Oct 2023 16:14:59 -0700 (PDT) Received: from lucifer.home ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.googlemail.com with ESMTPSA id e31-20020a5d595f000000b0031fbbe347e1sm63860wri.65.2023.10.02.16.14.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 16:14:58 -0700 (PDT) From: Lorenzo Stoakes To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Will Deacon , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland Cc: Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Oleg Nesterov , Richard Cochran , Jason Gunthorpe , John Hubbard , Arnd Bergmann , Lorenzo Stoakes Subject: [PATCH v2 0/4] various improvements to the GUP interface Date: Tue, 3 Oct 2023 00:14:50 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 964761C000A X-Rspam-User: X-Stat-Signature: goqtfy3tsjscqdq6ypkzwao4f5pit9k9 X-Rspamd-Server: rspam01 X-HE-Tag: 1696288501-510935 X-HE-Meta: U2FsdGVkX19+7zxC35KToFyWAkRHmnkedu6LhNMcBi9H4ZXpoEeaMN1Qg2aKetJvQu7Sa3o2SfBccCUcu7UxulEunAGKx36hriL8+HMjaObBYvDGkkKOfyp+Vco/gH0lCVCnb+d9qzkXnKdCe+dI44q78vahiaF0Qwity1WGQj4QEDFdI8dDTbJ9IeXXRGuvsRrl/OHrc72mOXQjP0wEr21tujrrKWgwnAK2PIE1cY8VvCLZCnIc5qxWn9dCZedR4hqN9ZHYpas9jrr3O9vSbEwN+IvLR7xVFYb09hbUbGNTvhWTuX2A2M2r3nDLH2tqRUzCCV0aPmoCjutRBVNyj6jHvs1cQPQCk5LVSWXZOQa9oMvfMEBtevkEZLmxsJZRl4YUxGZq8TC+4ePjpzVczoUN+hq6hvVsIT5EgbEl2BNLm/mnO/HXoBdHHkcVfpzSlPqElxqVh7gXTOnnxWhVBSyXyuVeR3wD7RlqCieOwWHHDQzGAqeIH9G8MMrD0Xfao7p6xAJQEjqwhNXh0Owt+YL02hmIVL5t+lZp3MDv6xvrzH6iTTj8ARAfEpiWjKhWDXUNxzXogkeU7+ti2eGrFa+4wvx+DOSIkZdF2a6xJ9WmhnUq3M3/qV3x7EvM1d4cAZn9l+ikCZbSTSVfP7t7mgS8iYniWXEXQhUCZxVUvAr7pqQGUMMMnl5uk5hH2b/qt1KiDsokcIJVDq8dbsGj8HukUglPzQ6BR6VEdQOcgrx3Cz+d3cXBBvj4NVeOsSBV7nJF2Btg8ihxOBHneNT3/GVr/OAnGPAjnhzWaDe/VegvFPGqlM3pQVhh5gH3wNl3+Mc4ilQUZgCKjP+P8MNRnPdD143Vff1FHiu3ZcYukTxKgGcOcAHF/JuXcoj+n+fdLcIrG1a9h9c7/mZahPqB4WQkodbHPCV+kwGF0ZL47GOUE6VYWbd2CVcroGBGSKVBpMD10RI+p4upM/ZjLj7 Tt09PTdt DSmhPtXHQMhXnkJLrsWinN7AbbMXAT/YWajwHm7iHjaObTo4rnKmMR4H3wxk7JwEyBLs6LK4+FQVjC1E0iEFlu+wy3oqE2aYpoS+ux2AaacqPDwRr0rtrv4YA4Knd4vFSz8awTXrIxIpVrm0/wsxMrIXK1JSAXJGbbYsfRAvR2voFY0F367KZQWpIQux96d7/lzvlzM6ewu1VN7ZQWLb0eR3PJE8tNpt+8IIgey0QK1f7f2d8KTv2wT8K2NAnINRnSzdyo89hMEstujj6PhVy53Ni23TMkMzzcJzMt0VrTcqa0mbf9maafCwOHiU1+wCqNpb4CnJyVc6o8WxkT37/iz4v1ydRMnAuSpYOSu5q4zCgX7rah7iSLAvxktCUYjZYxHIYUW5qxSWeWfcB9WJpQaFk4Ya/+BhrmZSnZO6zXyR8jiflHPZKVTPfTarh/SZVzbjWc14QhJM6D8m6TjqySqmRLWAf+PWEFpfVKyoAhgePGB8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: A series of fixes to simplify and improve the GUP interface with an eye to providing groundwork to future improvements:- * __access_remote_vm() and access_remote_vm() are functionally identical, so make the former static such that in future we can potentially change the external-facing implementation details of this function. * Extend is_valid_gup_args() to cover the missing FOLL_TOUCH case, and simplify things by defining INTERNAL_GUP_FLAGS to check against. * Adjust __get_user_pages_locked() to explicitly treat a failure to pin any pages as an error in all circumstances other than FOLL_NOWAIT being specified, bringing it in line with the nommu implementation of this function. * (With many thanks to Arnd who suggested this in the first instance) Update get_user_page_vma_remote() to explicitly only return a page or an error, simplifying the interface and avoiding the questionable IS_ERR_OR_NULL() pattern. v2: * Corrected spelling mistakes in patches 1 and 2 (thanks PeterZ). * Made things WARN_ON_ONCE() where appropriate and dropped unnecessary checks (thanks David). v1: https://lore.kernel.org/all/cover.1696174961.git.lstoakes@gmail.com/ Lorenzo Stoakes (4): mm: make __access_remote_vm() static mm/gup: explicitly define and check internal GUP flags, disallow FOLL_TOUCH mm/gup: make failure to pin an error if FOLL_NOWAIT not specified mm/gup: adapt get_user_page_vma_remote() to never return NULL arch/arm64/kernel/mte.c | 4 ++-- include/linux/mm.h | 14 +++++++++----- kernel/events/uprobes.c | 4 ++-- kernel/ptrace.c | 2 +- mm/gup.c | 16 +++++++++++++--- mm/internal.h | 3 +++ mm/memory.c | 7 +++---- mm/nommu.c | 4 ++-- 8 files changed, 35 insertions(+), 19 deletions(-) -- 2.42.0