From: Lorenzo Stoakes <lstoakes@gmail.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Oleg Nesterov <oleg@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Jason Gunthorpe <jgg@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>, Arnd Bergmann <arnd@arndb.de>,
Lorenzo Stoakes <lstoakes@gmail.com>
Subject: [PATCH 0/4] various improvements to the GUP interface
Date: Sun, 1 Oct 2023 17:00:01 +0100 [thread overview]
Message-ID: <cover.1696174961.git.lstoakes@gmail.com> (raw)
A series of fixes to simplify and improve the GUP interface with an eye to
providing groundwork to future improvements:-
* __access_remote_vm() and access_remote_vm() are functionally identical,
so make the former static such that in future we can potentially change
the external-facing implementation details of this function.
* Extend is_valid_gup_args() to cover the missing FOLL_TOUCH case, and
simplify things by defining INTERNAL_GUP_FLAGS to check against.
* Adjust __get_user_pages_locked() to explicitly treat a failure to pin any
pages as an error in all circumstances other than FOLL_NOWAIT being
specified, bringing it in line with the nommu implementation of this
function.
* (With many thanks to Arnd who suggested this in the first instance)
Update get_user_page_vma_remote() to explicitly only return a page or an
error, simplifying the interface and avoiding the questionable
IS_ERR_OR_NULL() pattern.
Lorenzo Stoakes (4):
mm: make __access_remote_vm() static
mm/gup: explicitly define and check internal GUP flags, disallow
FOLL_TOUCH
mm/gup: make failure to pin an error if FOLL_NOWAIT not specified
mm/gup: adapt get_user_page_vma_remote() to never return NULL
arch/arm64/kernel/mte.c | 4 ++--
include/linux/mm.h | 18 +++++++++++++-----
kernel/events/uprobes.c | 4 ++--
kernel/ptrace.c | 2 +-
mm/gup.c | 16 +++++++++++++---
mm/internal.h | 3 +++
mm/memory.c | 7 +++----
mm/nommu.c | 4 ++--
8 files changed, 39 insertions(+), 19 deletions(-)
--
2.42.0
next reply other threads:[~2023-10-01 16:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-01 16:00 Lorenzo Stoakes [this message]
2023-10-01 16:00 ` [PATCH 1/4] mm: make __access_remote_vm() static Lorenzo Stoakes
2023-10-02 10:59 ` David Hildenbrand
2023-10-09 22:16 ` Jason Gunthorpe
2023-10-01 16:00 ` [PATCH 2/4] mm/gup: explicitly define and check internal GUP flags, disallow FOLL_TOUCH Lorenzo Stoakes
2023-10-02 11:00 ` David Hildenbrand
2023-10-09 22:19 ` Jason Gunthorpe
2023-10-01 16:00 ` [PATCH 3/4] mm/gup: make failure to pin an error if FOLL_NOWAIT not specified Lorenzo Stoakes
2023-10-02 11:04 ` David Hildenbrand
2023-10-02 22:51 ` Lorenzo Stoakes
2023-10-09 22:22 ` Jason Gunthorpe
2023-10-01 16:00 ` [PATCH 4/4] mm/gup: adapt get_user_page_vma_remote() to never return NULL Lorenzo Stoakes
2023-10-02 10:16 ` Catalin Marinas
2023-10-02 11:08 ` David Hildenbrand
2023-10-02 22:56 ` Lorenzo Stoakes
2023-10-09 22:24 ` Jason Gunthorpe
2023-10-01 17:39 ` [PATCH 0/4] various improvements to the GUP interface Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1696174961.git.lstoakes@gmail.com \
--to=lstoakes@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=irogers@google.com \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=richardcochran@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox