From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CEB4CD4F3B for ; Fri, 22 Sep 2023 09:06:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7ECA16B02A0; Fri, 22 Sep 2023 05:06:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79D8A6B02A1; Fri, 22 Sep 2023 05:06:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 665206B02A2; Fri, 22 Sep 2023 05:06:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 543B16B02A0 for ; Fri, 22 Sep 2023 05:06:09 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1D1A91C9DB8 for ; Fri, 22 Sep 2023 09:06:09 +0000 (UTC) X-FDA: 81263651658.07.D383096 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by imf12.hostedemail.com (Postfix) with ESMTP id 8BD6440018 for ; Fri, 22 Sep 2023 09:06:06 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OaUuReH+; spf=pass (imf12.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695373567; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=jgwrnG4tADjLTY0jz/kvpx4JlhsV3CEMqMlQish3xpk=; b=WVQSR7hoEeXvkfMzbx0+x1WOrxJA12QGxoxclZvBJRRzhN93xmgMwdSCJkQ4QDfh99gpLU piq4DLhL3S9cNLJ+GlNTdLlaPvzYjLHEDkB/WYjp4lDI1+NjELjV8+XPHtsVEpEgrPKEqf kYrz6J5/Y5FlVOLhUiAF9sC6jpGSa2o= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OaUuReH+; spf=pass (imf12.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695373567; a=rsa-sha256; cv=none; b=mgcySKFT5HjfDp1NxOVvRmX/ZxNz3YU2TCahXEh0g1huEB6Jrw+3v4ehSIWgCk2DAbU5Je 2iHpU6AC56pWsbBuKD+Pn5u5rIQgbSnbrSa/cjszZoY3d8g9tdmkuQeZgAi1PsrD9J+/Ma r23FxSIXbwSZmTe1jGaKtX37E7Z/oNg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695373566; x=1726909566; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=T3FdWmDNR/lv5xeJT/UeFBdFzsKp+DdlUH94ECBPozw=; b=OaUuReH+I3Paa2FHpiE2Y2qD6dhdB/F1stcO0QQzuD7POCtqPgEDtAGm fAa7YOPeoC2isXu+LU3hgWXPAwXlQ/ACVzzDqnUf33BbswXzfG1G2jX8m Gu+9O30VzeaHjf23LvqGDzSLr26BZlOq0WamnIbePbFNL+qNcKl1ImuQ6 WLSgtMIvNvc1/6QIUKWGtpK025rFV244HY5WSHcp5c9Zc5b4muJ8VQoHK g4VCsFSCjQZHuGqJKUn5tuIyGYXoY93zCGmNInhdgaasUdvsfaE5BigxO jEP/eh08axygtf+LecFk303UfbbK0NeYPcwzXeNsZu0djz7GcRyTdQre0 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10840"; a="383528347" X-IronPort-AV: E=Sophos;i="6.03,167,1694761200"; d="scan'208";a="383528347" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2023 02:06:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10840"; a="741026653" X-IronPort-AV: E=Sophos;i="6.03,167,1694761200"; d="scan'208";a="741026653" Received: from bmatwiej-mobl.ger.corp.intel.com (HELO wieczorr-mobl1.intel.com) ([10.213.8.2]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2023 02:05:58 -0700 From: Maciej Wieczor-Retman To: akpm@linux-foundation.org, christian@kellner.me, fenghua.yu@intel.com, keescook@chromium.org, ndesaulniers@google.com, coltonlewis@google.com, dmatlack@google.com, vipinsh@google.com, seanjc@google.com, brauner@kernel.org, pbonzini@redhat.com, shuah@kernel.org, hannes@cmpxchg.org, nphamcs@gmail.com, reinette.chatre@intel.com Cc: ilpo.jarvinen@linux.intel.com, linux-kselftest@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v3 0/8] Add printf attribute to kselftest functions Date: Fri, 22 Sep 2023 11:05:50 +0200 Message-ID: X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 8BD6440018 X-Rspam-User: X-Stat-Signature: t7jtpo43bppzpdryrjjiarjcmftzyasc X-Rspamd-Server: rspam01 X-HE-Tag: 1695373566-266342 X-HE-Meta: U2FsdGVkX19XEhIGtlm6XYX9MKwczOXNbmn4upl5m/qqEA1zOgNXmJVuuUOcQi49BjCloxy35JlwjRG2PctiLqie7OCAXd2j0wh5B1AvLZPeAZb/l1DmiRTxFcpkUKZdXJqf1gAEbPfofAoH3y83pCG4LbAlb5isNC9L76iS0nicw9u3ZjM/gAMhgoh+WKVW89ap00nh/AOXGQHGo3Fz+op5ecoBviDRSYS4daWbvHhjYg0e1WxFHdlEewIwKFwaDCulXwzR8hU9wPyeWbu5vpGvd4np8x1D4QlTmQ+1baDcd+ASqxKnoSHzQz6yLHWlMW7nOYXhl4ESYslH/r5EcBvGu4CYkvnxTDI/BF9WUaiTP0CSe502mMaYWAJlCQFeDxxQ4jk45KfgDQUQ9rIaipfYV/O687mVwPDFbfP1/IX/Dy7rBlmVuAtURpdbCgcSeS0r1HTzuiIhwPSvqx23BfxCvYJYXv2x3+Bxs+CV0ys/MqQM6jckx5ObPF117vjci2bW/9T2IiswbyJ5p+Ou9ojNeCUEMazY8+VHq+l16OmLllYO2CTkK76AvYfhUl7HKvCMZlputOaWzuTSmARo+SDUTiSTQILre3YbuEhfeA4ZYVgUYh+G0Vh7ZD0iwuz/DBQMZ5hyC8TuYRggOCnY5+nUAYZVAM2BinTxbD2qd3oaFW2OG1yMo7Xt1eeW6OLo5V+h6vCXI5f1YArdME9JKprxkSgS/uqrJvCHQtN0sDs3XZsaObhgjuEnfPO4lLkDGdq2kjjlHue+lIburDDTknD0s1Hwv45X8xxCCx7L1leCiIuAaAsi9VtKhdgoTRlv2ZluaEG94ylHGY+UOO05fyhgfdEpCnimVMRKWaeszNV7ebdZLV0I+WiZoPZcwcDPIRFFXPAmsmv9VVxXY84ZDxxfMWIbt6MfOZ0r3vmYhcdSaa/FaYADwW68osaYbUuu1FHmUTkEZYfVn5hXSMS /4jdw3iu /eQkTd1TnJ8YkPDekjjftnTdTdsvwTkuvM7KCSHaXfeAKCuyVT90JylfnBk7IuPRCfP4Kag7p2EnponGiesJFUW0TLQkUM6Lh+n6TfbV/DJ6rb3WPlWTuudieH/v9y5q2uNMydxSQogPfw6q+RGoF7PYmTwlm3SYnC8H7CkX9Xv3q+64/XPyCgL7scgccQioVZCTFeIB+tQrkE/7Cb4t1p3FAiXk7wJydv1eT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Kselftest.h declares many variadic functions that can print some formatted message while also executing selftest logic. These declarations don't have any compiler mechanism to verify if passed arguments are valid in comparison with format specifiers used in printf() calls. Attribute addition can make debugging easier, the code more consistent and prevent mismatched or missing variables. Add a __printf() macro that validates types of variables passed to the format string. The macro is similarly used in other tools in the kernel. Add __printf() attributes to function definitions inside kselftest.h that use printing. Adding the __printf() macro exposes some mismatches in format strings across different selftests. Fix the mismatched format specifiers in multiple tests. Series is based on kselftests next branch. Changelog v3: - Change git signature from Wieczor-Retman Maciej to Maciej Wieczor-Retman. - Add one review tag. - Rebase onto updated kselftests next branch and change base commit. Changelog v2: - Add review and fixes tags to patches. - Add two patches with mismatch fixes. - Fix missed attribute in selftests/kvm. (Andrew) - Fix previously missed issues in selftests/mm (Ilpo) [v2] https://lore.kernel.org/all/cover.1693829810.git.maciej.wieczor-retman@intel.com/ [v1] https://lore.kernel.org/all/cover.1693216959.git.maciej.wieczor-retman@intel.com/ Maciej Wieczor-Retman (8): selftests: Add printf attribute to ksefltest prints selftests/cachestat: Fix print_cachestat format selftests/openat2: Fix wrong format specifier selftests/pidfd: Fix ksft print formats selftests/sigaltstack: Fix wrong format specifier selftests/kvm: Replace attribute with macro selftests/mm: Substitute attribute with a macro selftests/resctrl: Fix wrong format specifier .../selftests/cachestat/test_cachestat.c | 2 +- tools/testing/selftests/kselftest.h | 18 ++++++++++-------- .../testing/selftests/kvm/include/test_util.h | 8 ++++---- tools/testing/selftests/mm/mremap_test.c | 2 +- tools/testing/selftests/mm/pkey-helpers.h | 2 +- tools/testing/selftests/openat2/openat2_test.c | 2 +- .../selftests/pidfd/pidfd_fdinfo_test.c | 2 +- tools/testing/selftests/pidfd/pidfd_test.c | 12 ++++++------ tools/testing/selftests/resctrl/cache.c | 2 +- tools/testing/selftests/sigaltstack/sas.c | 2 +- 10 files changed, 27 insertions(+), 25 deletions(-) base-commit: ce9ecca0238b140b88f43859b211c9fdfd8e5b70 -- 2.42.0