From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54EEDC83F11 for ; Mon, 28 Aug 2023 10:49:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 879B98E0014; Mon, 28 Aug 2023 06:49:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 802CB8E000E; Mon, 28 Aug 2023 06:49:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A38C8E0014; Mon, 28 Aug 2023 06:49:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 543F68E000E for ; Mon, 28 Aug 2023 06:49:07 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1A12F401CC for ; Mon, 28 Aug 2023 10:49:07 +0000 (UTC) X-FDA: 81173191134.09.4CC9E8D Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by imf09.hostedemail.com (Postfix) with ESMTP id 202BD140010 for ; Mon, 28 Aug 2023 10:49:04 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=T0HzYGqJ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf09.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693219745; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=lVinktNuHyE4QF90rmcUwk6hGxRKhXfK4g9qnKz6gWA=; b=S1AFKprwpPdI9mTAVSKa2Pm+dVQF0CNeZIXmK4DqhV++lPgAbWISOANvX85h4FS4OplHWv RJQtpF5p5xKYz+MV/aFQoAkO1D/lr1jIdLqS/tfpppNohd1JwADMUZU6AQxuAv6yBhpwx+ npQpoSII2WgTo/wW+tSBXmbUxQnNhU4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=T0HzYGqJ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf09.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693219745; a=rsa-sha256; cv=none; b=Ne5ONMsMiuN3Qagve+f4Hkl4V1aNV11c6bc/UViiNmworNJ4AAkaC9RcxYp+ALEyyykA4O v46EUGNGK+yoPuH7eBggKcS9YPq28lzl6ZioXlZAMaJev5ld9/Snl1/fKOE0VuMly/FJkD ejISHNJ7lBME31B0PkaxiEil2oU0zeo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693219745; x=1724755745; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=68kPnBw0DAbuilGsjX92zfZ1H4FfKYa2MVlR5dt9PmI=; b=T0HzYGqJ4YdOTGE0cfZe81fAk1nl2hWEG8KnaQ9aCCWu9nsHqLwGf+CK oC6N8hW5rGi95onK5oOQNZ8qrAumPMhgAaJCB9jN0CM/VvCqHgvd5YNvV 7Cc/RXsrNferkD7mFerjuv5wnHEBcBgzqw4AO3pdjvxPLzKz8fkTqX79J T+Fa9fUx0lmIRmJ3UDsX+P3pKRjNII58DBwhQGoyQD1iTkH9XOJB62K4P XMvR8B7XjrlH/dwzTgg8iGpmR3UyiWLxnFmF1ZQWFX2mX+qe/2tYFGEDG 3+yOCQLYhvrdJH1w17JIO8HF4wCdkOwLh1Whs+mF7w37L/zsdEavaqner w==; X-IronPort-AV: E=McAfee;i="6600,9927,10815"; a="378848309" X-IronPort-AV: E=Sophos;i="6.02,207,1688454000"; d="scan'208";a="378848309" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2023 03:49:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10815"; a="984840263" X-IronPort-AV: E=Sophos;i="6.02,207,1688454000"; d="scan'208";a="984840263" Received: from nwiklans-mobl.ger.corp.intel.com (HELO wieczorr-mobl1.intel.com) ([10.213.22.120]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2023 03:48:57 -0700 From: "Wieczor-Retman, Maciej" To: linux-kernel@vger.kernel.org, Christian Brauner Cc: kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, keescook@chromium.org, ndesaulniers@google.com, coltonlewis@google.com, dmatlack@google.com, vipinsh@google.com, seanjc@google.com, pbonzini@redhat.com, shuah@kernel.org, hannes@cmpxchg.org, nphamcs@gmail.com, reinette.chatre@intel.com, ilpo.jarvinen@linux.intel.com, "Wieczor-Retman, Maciej" Subject: [PATCH 0/6] Add printf attribute to kselftest functions Date: Mon, 28 Aug 2023 12:48:24 +0200 Message-ID: X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 202BD140010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: b6whsc3g6wdomfnohjsmxb8mmxwyw9ib X-HE-Tag: 1693219744-361339 X-HE-Meta: U2FsdGVkX1/hGMiN2g6pwv1q0xx5ur7cXcBq3UtLjapYkGUqEmiwJdys9slcV9rcwxZWrD+qW6+dUP3t5MZFCx+7Znk4Ff9dWRlwtHiXJ0z6om5iROfI1gOY/ndzzTZkjGC+MJz3Z1EaUSNKRCv0XxidfkQeXgrXrnl5BClvO6qWiVBM+rEOtvM2TubFh1XoJ7lIEKBQaQKvnYPz7L2yGhXadq9lDJ85dstouDN1s1St6dxOWKuSxjLAsoCZsaCTlIS7CVFZf7rd1jYv61g+laog5bCiH4TDT4RlMoajJ98+iZ4eJ+x7TyYulPTPf8NYZ5b4v9PxmoerwHRNOnujTgaYLih13Mv6/qu7trjEj64k8HCBB+z1vQulSuHufHYX8h8rWGynKncE35+iCOqZIKtQPtrddebRhrwmTsQ74wusVbmkXK925Sgjj41uMjNIyWB8Loui2aigr1lDmDh0WHLw2ks1gYdfdvX/kECpqGppH1SDxX6wHplu4KshAYqWGIRPDJSoQUbKLUSHueIsj247v5EwpM3Ros+ATVquqUzfrdqmV50bQfF9nwi4/YSc+sQTxL3tT44hDVNTexoR2XBKfC3wU/SK7ArShqyJ/jW96wG01rYfp2GNUZulBEsTO3Ca4I8mejH2y6hY+6J5g1kw43e4eRLybFCTD9B5jw6txoVyRd9jva4spT0gDcAA70qfUJrQwzoW9iMyov3bfZ9LOzoXyHKE03VBOVGefmD0S/hE44m0SLpJeSVhuOLxlz0d1rngiFkIZK77pL2pAXuuVz19kNJ7hixcdYHqo97k4pEGDIcma3uyWW2KP48/Dym8KGEbW6Hg+CQZ35sjjCo26aZ9NTI7eHesFtI9sFadqOjG6YszjD4u6/S1HOlvNCkKAvDIujCi7X4zzO4wXgcVz75BwsKN2j3giyJosGUxPtaa5MdHkQmEZH57TUqc3dwj1qnJp3a9xRYQEXQ 1IAxNUDL +cQYr9ODgy2XV0Y9+rTUwI+EPs3fr9Qxlnbt4WbruX/2M0n36InahqP3CgW0drFtBNq1s7egkIAf7+DjAQ5/6ChD6Sc7HIyavxexfPOLU9S4YTIPwLE/bLuyzYYOXcHVrtwUTQvkE42tKWoqEMkg24k9F6g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Kselftest.h declares many variadic functions that can print some formatted message while also executing selftest logic. These declarations don't have any compiler mechanism to verify if passed arguments are valid in comparison with format specifiers used in printf() calls. Attribute addition can make debugging easier, the code more consistent and prevent mismatched or missing variables. Add a __printf() macro that validates types of variables passed to the format string. The macro is similiarly used in other tools in the kernel. Add __printf() attributes to function definitions inside kselftest.h that use printing. Adding the __printf() macro exposes some mismatches in format strings across different selftests. Fix the mismatched format specifiers in multiple tests. Wieczor-Retman, Maciej (6): selftests: Add printf attribute to ksefltest prints selftests/cachestat: Fix print_cachestat format selftests/openat2: Fix wrong format specifier selftests/pidfd: Fix ksft print formats selftests/sigaltstack: Fix wrong format specifier selftests/kvm: Replace attribute with macro .../selftests/cachestat/test_cachestat.c | 2 +- tools/testing/selftests/kselftest.h | 18 ++++++++++-------- .../testing/selftests/kvm/include/test_util.h | 2 +- tools/testing/selftests/openat2/openat2_test.c | 2 +- .../selftests/pidfd/pidfd_fdinfo_test.c | 2 +- tools/testing/selftests/pidfd/pidfd_test.c | 12 ++++++------ tools/testing/selftests/sigaltstack/sas.c | 2 +- 7 files changed, 21 insertions(+), 19 deletions(-) base-commit: 13eb52f6293dbda02890698d92f3d9913d8d5aeb -- 2.42.0