linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Chris Goldsworthy <quic_cgoldswo@quicinc.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@redhat.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	"Sudarshan Rajagopalan" <quic_sudaraja@quicinc.com>,
	Georgi Djakov <quic_c_gdjako@quicinc.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
	Chris Goldsworthy <quic_cgoldswo@quicinc.com>
Subject: arm64: mm: update max_pfn after memory hotplug
Date: Tue, 28 Sep 2021 11:51:48 -0700	[thread overview]
Message-ID: <cover.1632853776.git.quic_cgoldswo@quicinc.com> (raw)

Follow up of RFC patch:

https://lore.kernel.org/linux-mm/a3bf84c4-8f35-f273-145c-55928a06f332@quicinc.com/T/#m219937b1acdd40318bbe90ab39f187804775eb74

On arm64 we set max_pfn at boot in arch/arm64/mm/init.c. If you
hotplug in memory after booting up, max_pfn is not updated. This
breaks diagnostic functions executed from user space like
read_page_owner():

https://elixir.bootlin.com/linux/v5.14.7/source/mm/page_owner.c#L472

or kpageflags_read() (see how get_max_dump_pfn() is used):

https://elixir.bootlin.com/linux/v5.14.7/source/fs/proc/page.c#L47

Thus, this patch updates max_pfn and max_low_pfn in arm64's
arch_add_memory() function, mirroring what is updatated during boot:

https://elixir.bootlin.com/linux/v5.14.7/source/arch/arm64/mm/init.c#L448

Quick reference for David's Acked-by, with a follow-up discussion on
max_low_pfn:

https://lore.kernel.org/linux-mm/a3bf84c4-8f35-f273-145c-55928a06f332@quicinc.com/T/#m7d30b3afa632a4fa836f5fe55f4ee8e7bbc83e5d
https://lore.kernel.org/linux-mm/a3bf84c4-8f35-f273-145c-55928a06f332@quicinc.com/T/#m0d0e509375af1504d25451d079c5cbd6e7aa513b

Sudarshan Rajagopalan (1):
  arm64: mm: update max_pfn after memory hotplug

 arch/arm64/mm/mmu.c | 5 +++++
 1 file changed, 5 insertions(+)

-- 
2.7.4



             reply	other threads:[~2021-09-28 18:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28 18:51 Chris Goldsworthy [this message]
2021-09-28 18:51 ` [PATCH] " Chris Goldsworthy
2021-09-28 19:34   ` Georgi Djakov
2021-10-01  6:38   ` Anshuman Khandual
2021-10-01  8:39     ` David Hildenbrand
2021-10-01  8:52   ` Anshuman Khandual
2021-09-29 17:48 ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1632853776.git.quic_cgoldswo@quicinc.com \
    --to=quic_cgoldswo@quicinc.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=david@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=quic_c_gdjako@quicinc.com \
    --cc=quic_sudaraja@quicinc.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox