From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1881C02198 for ; Thu, 13 Feb 2025 01:53:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3060B280002; Wed, 12 Feb 2025 20:53:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B602280001; Wed, 12 Feb 2025 20:53:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17DCD280002; Wed, 12 Feb 2025 20:53:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EFBCE280001 for ; Wed, 12 Feb 2025 20:53:19 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9CAF381677 for ; Thu, 13 Feb 2025 01:53:19 +0000 (UTC) X-FDA: 83113248918.05.EA8CDF1 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf27.hostedemail.com (Postfix) with ESMTP id A726540009 for ; Thu, 13 Feb 2025 01:53:17 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="BRc/qrRw"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.47 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739411597; a=rsa-sha256; cv=none; b=IRRK/yxBeWLq5yxiHC/u3EuyXZi52oejDsnfL2aPHzFYfiRybsiYHczmTfVhVrEwvOSZy0 gpUKOllRxzXlX+2MB9Ivjg9aR+9rPkime49aQo7iGxuMRcP6efNUtH0NFuTibVGh8sjhgw XI/oiPRX8tobHqo/4Ts84FGZ57VPnc4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="BRc/qrRw"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.47 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739411597; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mjgq8Dv9L5Zlmb2+3WRJFHG3qseBbMgQXG2FucXZtPg=; b=nrQR69++c06d3V8YD+4AX1nokvxorVo2s0M2lVkDewmuYYMxdFe78UNBgQhZUM/shQiith d7m+UJ0LHOaMuE0m6OoD0w9qFrAD7jBEGklXOAUZxxtqaum1r2eiPwOXt2vRvzNGbADFBn skhkX9EzqqHdymHSlQWXOStV3AlZgWY= Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2fa3e20952fso779793a91.1 for ; Wed, 12 Feb 2025 17:53:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1739411596; x=1740016396; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mjgq8Dv9L5Zlmb2+3WRJFHG3qseBbMgQXG2FucXZtPg=; b=BRc/qrRwS9y7N5gUc+A8iTW1mrFVup4IhGHEfhrorEy0NCYjsbZF6HRzC3DghCuEvI 2ycYxMHbnABfHtl4Dh2QxWmLz+Dn1d6c3nGkybPMzynZ0dmf+ea0pbaPCt5EcN4uHiIr 79DYYURBqkr5zw9kI8loNr63sBcWnso5583RQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739411596; x=1740016396; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mjgq8Dv9L5Zlmb2+3WRJFHG3qseBbMgQXG2FucXZtPg=; b=lHWYty7aWR5rAzSo/z0l2ANizyyhwe/IaO7Cegi3m44fHfB00tsMQsuX/s57dMzbwV dNS46DO4V87bO0QK/GWEXtsUY1wqO5bxj6iRvi5gAXN2S9XO/nV3sbuUIUh3b5emfVus rq2FKTmkIsrp6rLX7QNJ65FBNAugZSMnaRErkm+64G6jC3CYgjZXKAvHSWcFTgosyXqA WADbSib+kOVVhfwkSfsITL4khxtiSqrNnL3ZBcb8aDY2NGJUA3JuiTcJ0ilDDG9+ZO2/ klv/R03/skZ5xTy4rGQNyr+MSJebnSH0SHvJx8o7Kaz3hjRvgG+Zwd0lG//dVNYSYCnU OOWw== X-Forwarded-Encrypted: i=1; AJvYcCUMs13m8wo495VM+rb30s0fq8nndmc3uWBFXH74ssnxnOKDxOLKAKKUiVYNSo2+CBsoFzBLjrU9rw==@kvack.org X-Gm-Message-State: AOJu0Yx9yDxCJpHYDcoYFaMLN61XkGTIQEzZPMKKS9xBjV4RyPgy/6as MQkKOHr9XlymTaLRXK/yGU2pJWexXj3krJakigt1NyzoLKC4gCd6WljzYlyJlQ== X-Gm-Gg: ASbGncs/1hknmXXvQImLJCIrgX8M4/9xbHQ96dl1looZGk4pEQXfcBdhBfzW0v7CWuG lsfC/mlSpJT/mDFxIn3aSfOHojKs1UFCot5yRl8opqFWkpA4nIf3u7Kw1JoTfyIxP/ROS4nf7O/ ddR8S4MahwWuCbV6ex0y64rWUjAsejXtg+XnRtJJhOn8BD+ufYjrkUoooscs/A6SWLd88gg0lNQ QjSvS01HAnlEZZXmw/fIIeYupk+bqq7d6rT6vn1Y0x3nLnhUoXsdr8cRQ0qzM1hi6Urn9jQnVgJ DLgu7WWJ/0MRc9+ziGE= X-Google-Smtp-Source: AGHT+IG6+jByA0PrH/eC1+V2PyBt31aGCsCjFz2zdX4WSKw9zHmoUsOnQ2y4Ak52aJjuOcTgc7eMqA== X-Received: by 2002:a17:90b:1f82:b0:2f2:8bdd:cd8b with SMTP id 98e67ed59e1d1-2fbf5c6f522mr7810051a91.29.1739411596690; Wed, 12 Feb 2025 17:53:16 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:3ed3:97ce:5f5f:1f61]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fc13ba564bsm111460a91.40.2025.02.12.17.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 17:53:16 -0800 (PST) Date: Thu, 13 Feb 2025 10:53:11 +0900 From: Sergey Senozhatsky To: Yosry Ahmed Cc: Sergey Senozhatsky , Andrew Morton , Kairui Song , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 12/18] zsmalloc: make zspage lock preemptible Message-ID: References: <20250212063153.179231-1-senozhatsky@chromium.org> <20250212063153.179231-13-senozhatsky@chromium.org> <3f4ff25513fa8a6589288418694f614e4d0399c4@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f4ff25513fa8a6589288418694f614e4d0399c4@linux.dev> X-Rspam-User: X-Rspamd-Queue-Id: A726540009 X-Rspamd-Server: rspam12 X-Stat-Signature: a1iszhohmimpj6o7igao5ri174qn4dk8 X-HE-Tag: 1739411597-89442 X-HE-Meta: U2FsdGVkX18wES364+veHlY958rjhgxkX83urcxguHB78x1IG7qlCxqsTHw+WSGnd7YmwYtzq3gsdmBu2D1KCEUlHFHUqRJE0KO1BxYNRJSTbVvIZzfwHa98RYnJZTAj1Y4oo8e1rqwOYIa3Eby8G6aSr6YftTgVy4RRjYGNEklH+Xc21uD9nV0NQMLv2vwSwHgNw2Y49H/VOhy7yGtYh+PZyEK76SAoRbh1UDvyIuBhFm9/EfxhZjgFqxoBpCca70zc1eFKi8OB1d9clFWHLTgeTIq6F43V5jWdvEjiTjsgczbi2Cu6N0psLnHcjHgt5FUXv4Rv9gbct2P1VsS6omdeaQSzYVRvJ2q+8RnmP3xDYDd8eVhgeipEsESza9GqqQbMlF609n6hwfMMM4JjvxWE8rEyLMOd9A+oqwRl3kuYMaN1WZhHQQkctV2bdodnuOp4KZJrM3S9AYhr7d7r5QD8DksEVFFkfwaIVWn86uzSMvoR6YzITVGJ4kKYT+JaU4QK9V0BfLpxarr2kY5OAJSgsyUw72XhtpfUD22NEVxSO+eIv2lQom8wo9PhInAbjaTZWlFG889A2UMxjU6cTcrmHG89PfejWwtdjsi7hC7A3vNUx52FHqNDzUMi/Fdf093faeqZDJ3p8EEN7KQARft23HnCptBDtrJuoUxoow7y1sUzUTL9NR7BeO210Dj0sAGHebRVV0Njaa5iVQTZy0kjmoeROEH+vHDTBFgSTD4Qgutz8OaY+WA419OSXMgaWp4yOoIkgaE4Xf741CdVLGixgzVoNy3h+2xfks0SVgsI7F3vWgMVvSaIY8HdXx2ImBt+OLXGoEDwktthMVKhJKque03tvW6b5m1dEmoPr5DUDPPsZt9PxweYjGzppVhpErs8taGFaJ6c+hWApdV9x58rySwT4uuapyFuw3FSM7cgTovrXOv6EvjvTUsy+v5+HoMGL76H6L0ZIYRw7qI qqhOJNG+ vSmKAxYdEWTShBrAF0eiOajOQKt+yDtS++cfCBOzpOUMaI7WRy0xaexOlrXbYC/eGfSSUxi2hrs/j8hLormLW95icYQwKst1oCe25MoJsw0Akp6jocn8ccgGPoPk0Nc9mhWbXvPVV+75XkAa1sJIM75zNA68Jv+ESoN4Qob+qupVC+iZfAd4HGLMKv4r1cwi++ielicPJKoUjINEN+CyIhhXE5JQxzdizpZH9FBCAGd4U29tKC1mcL5F9YFFTM02b6ma63YKt/R4jp5A91nlrHvdOFTbNQu46QbXeDjwdLo7B+Kie70nK3yE+r13sA0zuRu2UDPfgvcxKZhoDO2kLX3ayxBfK+JvSBTd6F0gaJVcS4As= X-Bogosity: Ham, tests=bogofilter, spamicity=0.373057, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/02/13 01:31), Yosry Ahmed wrote: > > > Hmm I know I may have been the one suggesting this, but do we actually > > > > > > need it? We disable preemption explicitly anyway before holding the > > > > > > lock. > > > > > > > This is just to make sure that the precondition for > > > > "writer is always atomic" is satisfied. But I can drop it. > > Right, but why do we care? Oh, not that we care, just wanted extra smoke-detectors. It's gone now.