From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 331ABC36002 for ; Tue, 25 Mar 2025 03:24:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1000E280002; Mon, 24 Mar 2025 23:24:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B207280001; Mon, 24 Mar 2025 23:24:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB944280002; Mon, 24 Mar 2025 23:24:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CE547280001 for ; Mon, 24 Mar 2025 23:24:50 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7FDB2801FF for ; Tue, 25 Mar 2025 03:24:50 +0000 (UTC) X-FDA: 83258631540.05.CD13CCB Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf25.hostedemail.com (Postfix) with ESMTP id 8C90AA0005 for ; Tue, 25 Mar 2025 03:24:48 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=YiaY4fS8; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf25.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742873088; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m3C+uTMvJM5RFkt7M/wtzib7q7b+9i6ok0fza3OH7Hg=; b=6Ws9TthLEjQvkQTzrQYwUPU9pcHtW0fz0IAHbpnYfEmMj9xGApVXHDWoRn12Xj/Cs7t9oP jBPY9MJjWJEvvo/Xlp5Laykv0dp9WF4t5h5C6+YNC/7q9GGVstxW4TeatMeL8XBnNOl00F HChOeKlT4YraRnq6HhU8RWGu5AfzPiU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=YiaY4fS8; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf25.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.180 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742873088; a=rsa-sha256; cv=none; b=Jsrrq34GVr8716VkiG476HDKTCTR2gIbPB66qVx1aLTsSzkVRSSaMWsrEO/YU7bsuzplir eIQrvnAg8tWG9wzwsWLTueeZB9BiNWs5ESmzPVqH3v3jcfaDDYf0Ee8AON92jT+prUqd9f huk6CxWOAQHBSxXRjwCnmYYjiTCl8Xw= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-224171d6826so25338835ad.3 for ; Mon, 24 Mar 2025 20:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1742873087; x=1743477887; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=m3C+uTMvJM5RFkt7M/wtzib7q7b+9i6ok0fza3OH7Hg=; b=YiaY4fS8QN+QP60x33MALxv69YcSfU+4z75jIVSr47pLYMuZgVs4kindBuQVVt9FsP UhqNngAsNbP6RrsYYQ9EDdxcPhE/2Q6U8cBbiEnUyBO61hdp2hlWCxxEzOkjQ1ahatHG oyhw8S/PxI5dFAAHoWvCy872bnn0sUoFO4n2w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742873087; x=1743477887; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=m3C+uTMvJM5RFkt7M/wtzib7q7b+9i6ok0fza3OH7Hg=; b=SY1b3gHZPn83VbVWFCddt+Shr95SgEMQpLGd96dQhyJyiwJooLqputyOSCIVNoawzy ewmh87JmqVdvuNv1MmnRFz+WpA+15noPxqyT2qd4SsCJ3p/lcKBhOe1yCns5BokllhSn sHI5BPRdsQcqvuVrb3mnKy2HOofR8As/9y7o+xYULZb9nRJPEPHKqzqdZoHqtYFsEh6D mdVzqaZKhPhatQ2Ltb1rMq6RzxiA1eUrn7YIBqydC1TaMNig+/0Ih4GnmqH5Wx3t10S8 OfBccgY9zzZiZ2IuCB9EQG4d9Y7zHliBEE3YS6FuyhhfJeHQdD85LS4wCGb6Gi26DWXN DF1A== X-Forwarded-Encrypted: i=1; AJvYcCXgMi3JiX/iOfq74nndKPyYblrjDx/qO0fxdBzlnl8ZYPwhm6OdLOrEuSPk0/Kf+qE7WMmDu/HFuQ==@kvack.org X-Gm-Message-State: AOJu0YzcSVjDWIG7V1sOETbiMqZb67rSNIBHoPUjKp/Rqd2z0eKRrQSf 0TSEaRd6Thp9R3r035Tl7K59gVSSW5AtR5XQusrNCTI9F4szdcMKiwdfTdET1eZzT+b9LWQlaKz Jfw== X-Gm-Gg: ASbGncuD15ZZ23Pud8xOdNGYYVETHOW//WhNdCJgp2ay+wnwO5PJA3sEePYm2WbiuLo OdL4+gTdxK6J3x571oOmaziFDs36B+4DGwIJLG2ZrI30uBefttHIs+c14f8JXV0eY7Y8JgYpDZz LiXFOInJlrp9/Py8BkJI4yEqc7WyTGqEhq30boRXcQHgr8iwphBvWabuCVwmvTnWlOs/Oc6OlXa 2+j4ZbikX4ryz0lC303JezELtyzwsWLA+dgfb2NT+IM4G+GOtHwQQghAPZ9usMTzrkPfpbyoqt6 hnFAc50PO0KpIQ5gedRIq+mYGkNBLBccUDkBD44qwLwpMGOr X-Google-Smtp-Source: AGHT+IFPnnSPt8FXPt92912/10CHAuk8319S+W0ptpwjnV6stjmMuK14t3Al2sS2qGfVMry24h2t4w== X-Received: by 2002:a05:6a00:4648:b0:736:a973:748 with SMTP id d2e1a72fcca58-73905a2515emr22240445b3a.22.1742873087113; Mon, 24 Mar 2025 20:24:47 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:f107:eb57:41d8:a285]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73905fab82esm9223499b3a.14.2025.03.24.20.24.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Mar 2025 20:24:46 -0700 (PDT) Date: Tue, 25 Mar 2025 12:24:41 +0900 From: Sergey Senozhatsky To: Anastasia Belova Cc: Sergey Senozhatsky , Minchan Kim , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] mm/zsmalloc: prevent integer overflow in obj_free Message-ID: References: <20250313115147.47418-1-abelova@astralinux.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam01 X-Stat-Signature: pdpc3o7z76816hgimrsnmmq431msz9tt X-Rspam-User: X-Rspamd-Queue-Id: 8C90AA0005 X-HE-Tag: 1742873088-423362 X-HE-Meta: U2FsdGVkX1+VxE6dgldQXfosZ4ILdKFbmeXQCWAm+Hn1BifEFJ8iISpPxANksdeKfIPIyhn8Ea1FS9UrQXrapTvz5h+Sqgd1S/rj1BO2XAt/2zAE0/Qx54Mz0/pmdDgDl/Dfyg8nmqVMhyO0gMOCUy9+tECZyMgGfG8OIEtT/pe91lbc5BXJJ+dPD6psp5LiUJ1IYRDijR8oaNzBpGKkKmvt+nIObqldMdJ/IliixG9zSZ3YHZB4wMJ2EEW/EuunLzVISUnoLIXBM53bIfTOdi0jS2Br6QIaW6RdbVNpEcFCVWBq9Xxp62xaxhnwBPYGEvZwK01uBIe30xO9an5ShT/tcz/EpoShy3i4OlW6EHsYcx3OD1Z7ve+B2pNYVbebubw7agzHRpsPERe22/bAhIpNNYU6XBDlNNxPbwoe0LHxMkzhUBJwOxeYYa+9gE8AB52E9Jg1Yc/8eSxOX7pXmBHjstSW7Jt2Pe97htMstcypqo7uqMeMRW8EVT9DUHOB5/eJPPsWoqqsvk/rCj3qk5tYbOA35d1fxj5jhe4BSl3PQcMK69clD2CRK4UuXXfalb4mXXzdy5+q11gFlMzRvpWzrqlDjI5zccSajIi1g3E3ZtCcp9lm7YOCVmHIbGeYnLHloYa00EyyJcxx23ualRHL8J4OgEu8ksSx57nLJMFXug11+rzQr8//REmqKoTGhSJOEyFD8JAQlWhvJX2+LtoicNB9UoiuTjM7tTgedxOEiSmMJ9NdeHDb3zR+DQNKULPRQMRBroN6RxJBpHUWVkmXyumcvGHHxbA0/SxtOPzDCO/F9IIJ+43+fmaTiQXLEluN6FJ0yYjJyl3ZDcG5HnzlZuJW3NJ+9mLArlmwyr28W4wyyRtMmJ1MkP81at6+PrI2nQgN5WBAuguMUFfRIwmSXa8MJh8yEVl4sopODeVenMIqned0grKs5GrL2/DqkfA+UdMsjx5if+tuHYE ikxjB/v4 2daJMip+bnx1zcOCPZRNXvCz/c3mMKasNrKc4UibEQud6LMA0iX+gsFrUW/xqRcvVGYj87q+CiH4upcmckP2mox9Rj2P/3tAaqYjL9mYJciJgpnW1JB5+WEpWmLWOZ49WKzl4UKByE/RGV1BigqTz5uJ1KC37TUbhCP6RppdRV4LIleHzW7TzSXa3rvZ5GhYsbwA7H0JqTsDix7TG2FmzRaT3EgCMT7oqDuPs3AJTImLqYS+uOdQo95LMIAXqUZt7eN4nky7pWvhBekQtT/29YOdSc56tUS598T1EL7sVcMWl4DNJMPnOeSkZzj5ikHujdwAvIYqTUYxpaJn6X4f4EmV2ko6sylm7WhCHTulBm4nzK4yGQAVy7OSWN+MPi1yvvR0AehZHvohzVTKxRkk6/jR/tQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000064, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/03/20 12:12), Anastasia Belova wrote: > If address (and unsigned long) is 64-bit, the result of multiplication > won't fit 32-bit integer. Please correct me if I'm wrong. Even if we'd consider s32 that should be an object offset of more than 2B bytes within its zspage, we never have anything like this.