From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6389E668A0 for ; Sun, 24 Nov 2024 08:02:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E81EE6B0082; Sun, 24 Nov 2024 03:02:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E31E76B0083; Sun, 24 Nov 2024 03:02:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D20986B0085; Sun, 24 Nov 2024 03:02:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AFD8D6B0082 for ; Sun, 24 Nov 2024 03:02:16 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1CD65A0228 for ; Sun, 24 Nov 2024 08:02:16 +0000 (UTC) X-FDA: 82820245788.24.4B4AF19 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf02.hostedemail.com (Postfix) with ESMTP id DE0D18001B for ; Sun, 24 Nov 2024 08:02:10 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Jtv/ZSOB"; spf=pass (imf02.hostedemail.com: domain of karansanghvi98@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=karansanghvi98@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732435333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K1IUJJ7iDDce6J1FT3PFuteos2N215Dgw4ubzBI4cK8=; b=dfFIoG65mr491oLhhL/TfWLzT0OqbhjSoKO0soAWykMGkF2ZiZqDyO6jsmaGj+yeMK54PC Dq4OENSg7Z4tNEUUSb0RdOxhVb28VwoJnJT5+7Itdv20f4XEYY4Ls7tqevX3x7MOKDBFAX Cl/f1L41Kp3t0IdUcS6Mmgw07lti0XE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732435333; a=rsa-sha256; cv=none; b=f+XsX/cKWj4ztqnXbnNSJxHjbd4SBjuTGqmMBSmoShUx3jbQ5VamWIPXXtcGa5vxlyLjKw JAQjILEgkwZIYcGzAlISkG/w72JE845f6+qNAjrYogGfaE4qHG4rmsNRbsIdaTlmTj9Tuc jAMEAixbG8Poz+/o0eezVP4jzlHhWF0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Jtv/ZSOB"; spf=pass (imf02.hostedemail.com: domain of karansanghvi98@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=karansanghvi98@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-723db2798caso2978486b3a.0 for ; Sun, 24 Nov 2024 00:02:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732435333; x=1733040133; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=K1IUJJ7iDDce6J1FT3PFuteos2N215Dgw4ubzBI4cK8=; b=Jtv/ZSOBJsCUAmOgRnXTzIyj5Z8sr1PJFkpCNTzHqL/G6JIUSmX2im//m9lMG4e5DE dqUJ6siB+7NeXYGpQSGH01aZkskkg0OCUvYojaqsiMgY9KjelbXuZvGZKghEX2SFK237 57ySUfzVYY7iriKyLth1+96wEs8u341PS3ROCu+TADqKwC3+fXgv6osRduuBCFVsWc1U uFjfg7x4er7FAGTrehs1EJ2g4pmXfzFK79zt7MEhakiEwk+nS6RaybCkBBDPqI4j3AYW CkA8+hXpNw31NWuStXlMGCVADRjj8+4H71X2SvD/T4sLBdnwFgm9kQRr+ua5WAMnzGm5 eeXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732435333; x=1733040133; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K1IUJJ7iDDce6J1FT3PFuteos2N215Dgw4ubzBI4cK8=; b=Sj9mBVOYXHUjnxTImX6Oss34OUClY63DGyBXnKjjlS0h28ahL++bpKBZoEEfrnAjRF mWPV0x8kg0SqW1VrhESf95zXewWYvccFUMzBJP+A5dg/jV+cKXbXN5ixNdZsTIQjMgFn WCPKf7XOLQH77Y5/QIiZ1RfrRlcFNwRGL7rG3C4HV8pXGBg/5zp0SvYvNdHFnPo7V4kz e1lw7DpS3zkIhC+SKCIopuzdJU2OoUklPYYn8PaoPdvSIHlZwOFhZB0Wiss5RafhmIqV VmyJfeB2iUPiL9JRBlhWHwg9cHXw2wEXbPEenqk3hHZvVxIAnCQrFeCYeWGvhPGGKchU 8wjA== X-Forwarded-Encrypted: i=1; AJvYcCXzeiTETHatD38fWuLYC1Z6DoJcYVf86CZ3mZWARZeqvN6TVoGChx/y5J1cC3qgQ9A6rkAUBhk8Zg==@kvack.org X-Gm-Message-State: AOJu0YzhM9k9KuX5M486ANBncFAxGITH+XhM2v/a8/FykHbre2u1hmbk +20I03gamnva1oGhNx69n9OTEdnFpy25aiJdnnnxDyJM3w72vxKylIk3qaoTZ80= X-Gm-Gg: ASbGncvJe9WZmB8sGrpgsVawOKe/C/40I5NDAAF/RlhozTbD4F0sc44Sf5Dl9OLO9NN oL85Ie4gAa0LNysmCyas5YEj//4tLCcF95/eiCeqJnk3nB6YybwkgS9xc9U0X20phSXzISjiHSK Y4RdqutDIIG7oZZDYMc+GRwgL/cqVfIUbL2lWZfB7+MuH1R54Y9yfzmv5pcgYL4utz3jJTU2jdC OKwTkm/BXGbS2ubbuqqxwwszipPYtWklYmMO6IKwNJEvWaL X-Google-Smtp-Source: AGHT+IEyJHYn59HUVxOfQgI6lMoD4L0Eb/C4r0+f3QB1xea1sMXi82EGiYMHPOxfHRarwkmHqinZKA== X-Received: by 2002:a17:903:40ce:b0:20b:8a93:eeff with SMTP id d9443c01a7336-2129f6803c4mr115362765ad.37.1732435332601; Sun, 24 Nov 2024 00:02:12 -0800 (PST) Received: from Emma ([2401:4900:1c21:cadf:5054:ff:fe53:2787]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2129dc22952sm42576335ad.268.2024.11.24.00.02.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Nov 2024 00:02:11 -0800 (PST) Date: Sun, 24 Nov 2024 08:02:06 +0000 From: Karan Sanghavi To: Gabriel Krisman Bertazi , =?utf-8?B?QW5kcsOp?= Almeida Cc: Hugh Dickins , Andrew Morton , Christian Brauner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shuah Khan Subject: Re: [PATCH] mm: shmem: Fix variable type to int to evaluate negative conditions Message-ID: References: <20241111-unsignedcompare1601569-v1-1-c4a9c3c75a52@gmail.com> <87ttcdwr9k.fsf@mailhost.krisman.be> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87ttcdwr9k.fsf@mailhost.krisman.be> X-Stat-Signature: cxire5o6t1bjfsqwca1m6hryqjkin446 X-Rspam-User: X-Rspamd-Queue-Id: DE0D18001B X-Rspamd-Server: rspam02 X-HE-Tag: 1732435330-224856 X-HE-Meta: U2FsdGVkX1/cfOvbkds/UE68tE9/xC6319k99yWXGaHYGismxTmIMs9fD7H3KvM58o2odlGviId3d/7xtqA1gmTrbLYLov+viTPfc+2oJ3/LuqlYcodxf5GLfT+U5ydsNGyDV/DILgHBIDC1NFGcXurF5Asw/NisTV1XlKTquEigazEcBjafHAajrFE/GetPWZBLULKZH1x0Fxsj9/lOpM2OlB+yfOpmrpRe0TrfFHkfSYhgMW4cvj9/kz3oDwAyk0CJFFpl5BqCPjXmvwxEgRGlH64Sf9yBypW5YqseITq5PssnFppj5o6ng4r+SHO9+92dzmREEPPGj/pbVordZgCWFhwbhi7EO4+puGVxW7HgYTdCY9mLxdeLI57Jnx/vC9GR8DvhMBnVpXoKD3x6eoHAhId6cFIgX6vyFmx+ESW5VbJj6DOoEDYkWu4UHwwowh07yHVjAIUloRS+PSHAQ50neJnHDwkZbhAAXa+lThwKmFtSVA8klSkgLiacTeMjvO0RPblLHHZGNYHnCjxwlKKZdFuQNmrs0vgdB7fdrQ7X8Mz2HRzIRNCWK6uWdPYJM54z5zBc4F/uOBzyTN+L0pFmYh+NdjQWF7QE0VQ/qM/h3SOkY7ZpOOztAkF438kkTXukG2kBIbzJOkD9K0nRHa1fgZ8zf58zLQ//S94wVcu67MUiFce7LgFxO2ifdOsj7kSAMZfO+SnqEylxskKYRhND7vzCa+IVxyfq9HkumdmAndJVHpxDB/tJ5q2bjBdE66/XF3S97VwewT1hy/ahMY7AlxBrWPjuoQxtUHMbOJQ6zreSHMlszdbPGAcaryK0vM05E0BGjGJH0CJuNfnZWM6Y8DXgbaqICgdufDr6ADgTckeWltxdwSBOR5/huo8VD7bdHYq4/QuK9Ousuqoj/vC0ZsN5qpVI2zKzNYtjACyU8byigK448kNS7KI7eRcIAERP0JOXA1YIGb3FtWA vwxgC2Nz IMKNbn0OxRD74EgJ6Ns54s0u4qk7ZG1uYXxRZfgiS8VxWSkHFnKLBRIfoS0v9civcKOVUdiQV2wVZSaeeb+8LyRo0Bb5j86OPo20B1JO6FtkGn1y2tvZ0qwdkipymDaszkyUOQLmfuIOsxBU+VHn2gERzuLiRlrpSf1JgtHoAvegRZvQs4Kx6nKUjieiKV79HMyO7pc3N/b9CX4oDqbxPFTjbrhF3Moaq2Wcqd8MbxXm8kOVi57L/hSykPhI1wBDwat4llhixoEq9A0XoqlXE9THiGaaV2hUVBKVmz7w/ww6lgRK1g4ueGzGK6E0sSDh5dV2uHIJP3iiTdztixhj3uQUy33fIO4v4S9/RvXQBxNSBmUPPkdFl/eqBs36KN0Po1VwoaD4wnwMb8vFbOaX8a/WbzKvw7GHbJh5o1VIfJ8TEuloBA+R1eIqULxN1Ivi+FTsU7bAHbfO4e/3WSrIzvSbg4lUirXDuwXF3ZWyin2eEKGjkmVzppVvss64nfGy2rW2PhJyceYN8WR2tdL0sMgmUFA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003650, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 11, 2024 at 01:37:43PM -0500, Gabriel Krisman Bertazi wrote: > Karan Sanghavi writes: > > > version variable captures return value from utf8_parse_version > > function which can be negative, but unsigned won't > > let it capture, thus missing the further checks on negative values. > > > > Fixes: 58e55efd6c72 ("tmpfs: Add casefold lookup support") > > Signed-off-by: Karan Sanghavi > > --- > > Coverity Message: > > CID 1601569: (#1 of 1): Unsigned compared against 0 (NO_EFFECT) > > unsigned_compare: This less-than-zero comparison of an unsigned > > value is never true. version < 0U > > > Reviewed-by: Gabriel Krisman Bertazi > > > > > Coverity Link: > > https://scan7.scan.coverity.com/#/project-view/10043/11354?selectedIssue=1601569 > > --- > > mm/shmem.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/shmem.c b/mm/shmem.c > > index 7987deb2be9b..17a1d4fa8870 100644 > > --- a/mm/shmem.c > > +++ b/mm/shmem.c > > @@ -4367,7 +4367,7 @@ static int shmem_parse_opt_casefold(struct fs_context *fc, struct fs_parameter * > > bool latest_version) > > { > > struct shmem_options *ctx = fc->fs_private; > > - unsigned int version = UTF8_LATEST; > > + int version = UTF8_LATEST; > > struct unicode_map *encoding; > > char *version_str = param->string + 5; > > > > > > --- > > base-commit: 6d59cab07b8d74d0f0422b750038123334f6ecc2 > > change-id: 20241111-unsignedcompare1601569-05b5932145ef > > > > Best regards, > > -- > Gabriel Krisman Bertazi Dear Gabriel and André, I hope this email finds you well. I'm following up on the patch I had submitted linked below. https://lore.kernel.org/all/20241111-unsignedcompare1601569-v1-1-c4a9c3c75a52@gmail.com/ I noticed it hasn't been applied yet, and I wanted to see if there was anything else needed from my end. Please let me know if any further information or modifications are required. I appreciate your time and feedback. Thank you! Sincerely, Karan.