From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A229C48BC3 for ; Mon, 19 Feb 2024 14:29:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A66DC6B0082; Mon, 19 Feb 2024 09:29:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A156A6B0083; Mon, 19 Feb 2024 09:29:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 903D06B0085; Mon, 19 Feb 2024 09:29:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 818A26B0082 for ; Mon, 19 Feb 2024 09:29:17 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3A40C1C03EE for ; Mon, 19 Feb 2024 14:29:17 +0000 (UTC) X-FDA: 81808785954.10.A1A029E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf18.hostedemail.com (Postfix) with ESMTP id 103D21C0009 for ; Mon, 19 Feb 2024 14:29:14 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=CyOmQFXf; dkim=pass header.d=suse.com header.s=susede1 header.b=CyOmQFXf; spf=pass (imf18.hostedemail.com: domain of mkoutny@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708352955; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1ONaivgVj/kykIG/cXvY1zXXQU8tX6udCSGGm21f/RE=; b=c5y+Htz3acfgc0CyJkh+O75WexJf6aIz0pum+ROIrYQX9XJXGZdOfxCXzfuZBPfQHwJDQU yV2wa7n7QndmG8yTAX5riDanmrfevCrv4goj97KIy9S1OczAJsYR748VYK+VrH9STZhETb 4P/W73dqyjg3AdW6WUqVQiC5BYke2WA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708352955; a=rsa-sha256; cv=none; b=aRaRnRgLHAsf4EvnGXzZ6DCTV94fO5WBcSSyCyimAoYUtwdUyBx5Ss0SV1L9vCzpT1TlqD GXCaozt3K1Dlth4eRZn2tcE/Lelp8xolAW7FEn8odVTWdFeAPdeLNmsETo72fXrLKmIj+B lDnVADtWALC7c9nAQtiDiNRZ71Na1j4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=CyOmQFXf; dkim=pass header.d=suse.com header.s=susede1 header.b=CyOmQFXf; spf=pass (imf18.hostedemail.com: domain of mkoutny@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2521B220FD; Mon, 19 Feb 2024 14:29:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1708352953; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1ONaivgVj/kykIG/cXvY1zXXQU8tX6udCSGGm21f/RE=; b=CyOmQFXfzsrEpil59zjj1xDhLSls+8rhnUd/fyM34aCxr5PpAsA/lhdmTMzKx8PxdQA/q7 ayNWDtsEGEmotEstGlETf4VqR4ofnEUf/rDEBI9rulMxzF4Y3fUs2Gc9IQLdPOyu7nf4iS BgP9ma7+xRaMwGXQbh0NsY2UwQa8aW4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1708352953; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1ONaivgVj/kykIG/cXvY1zXXQU8tX6udCSGGm21f/RE=; b=CyOmQFXfzsrEpil59zjj1xDhLSls+8rhnUd/fyM34aCxr5PpAsA/lhdmTMzKx8PxdQA/q7 ayNWDtsEGEmotEstGlETf4VqR4ofnEUf/rDEBI9rulMxzF4Y3fUs2Gc9IQLdPOyu7nf4iS BgP9ma7+xRaMwGXQbh0NsY2UwQa8aW4= Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 0E15D139C6; Mon, 19 Feb 2024 14:29:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id mIwkA7ll02XNEwAAn2gu4w (envelope-from ); Mon, 19 Feb 2024 14:29:13 +0000 Date: Mon, 19 Feb 2024 15:29:11 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Johannes Weiner Cc: Andrew Morton , Michal Hocko , Shakeel Butt , Roman Gushchin , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Jonas =?utf-8?Q?Sch=C3=A4fer?= , Narcis Garcia , Yosry Ahmed Subject: Re: [PATCH] mm: memcontrol: clarify swapaccount=0 deprecation warning Message-ID: References: <20240213081634.3652326-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ifpowlilw3jtc7ow" Content-Disposition: inline In-Reply-To: <20240213081634.3652326-1-hannes@cmpxchg.org> X-Stat-Signature: itxex8tdds88gnrad8uae59iraamqnw5 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 103D21C0009 X-Rspam-User: X-HE-Tag: 1708352954-27521 X-HE-Meta: U2FsdGVkX1/q2V/hBLPIs+5hGn8jCDzccs18sNOrWVrqg15xtQWd47Fdvutez0RKAuVfIBWtf4ruzC5j71KB1AHVtnHt0Tuha8r3z88zgwb87FxieaGqgu5Nw+SlMG2LI2bH/StHC3OOjrinejMHBfEFEEd5bqJd9d1y5jKBDCDpX99Z2Q74P29437tcfFgpz9pHETFlWvkIMF03ApCC6Z+6r+humgv4uLEQVdGm0Q85VY8t1N0dAChZn7Q6X/Tn3hQ3+Mva7clrwa6KanbOCFSRTJqW8XZPqZ5ZPKE5Jf5UQazEBajBqjCpgALvl4X2k9nO0kqjIUmR0VBsIMHlQvCvDlzn4VXW1unIkCuwo2nQrLOG97cOw9/LOvpHtaqJTh2f1EeqikBY3fuYNY/JYhB/FZBcuCzg+tVTg7rXZiaBVVZNwdef8a/6gUHxa7tseHRbzGUoG7jOFfiOfqVh+nSRu4XXhZSheD8mYYp0s8rmUtVBDO0NPy4OnNGrbyE4Olj4yQIyG+reJS1PUhBYugcn7eNmk+RauugyFXgS6PeH9R1geMU6L3dTWkbNPnY3VpPPOIUDm5aTj5bG5dyRbLXKyTaP1q7u5+Pd93Yd6OXePi6Om6um3DyVRiq1occCCky7spIxnNINk7/fTK36G7rleC3p04rNGnlYW0kb3bBeyp4EMvvuIY6zWuyzYhLlZyVxHNBHV/zLMSRRJftCry88Nj36oCuITRq1bhp9FIL2mzWvgepczQnkaIaOgG3/xSED2PXht8WUpg2D2d/GNdIJJCgYkrl+NNqlwc22YE9AvXXQaOvTztOUDF/nmt3/S/EiVoGuth/Zkv/TjEVFCvDcRrR6vwJwfmWLVyOyRRrL0OSaqPaWMumWys5Ipuhgj/QC4e728F5NjqtvSCbmzJkZKjL+L/RVOtUmeOblowWbkPH+OnCuLxomHgDFj6ycenJvVQl0st8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --ifpowlilw3jtc7ow Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 13, 2024 at 03:16:34AM -0500, Johannes Weiner wrote: > The swapaccount deprecation warning is throwing false positives. Since > we deprecated the knob and defaulted to enabling, the only reports > we've been getting are from folks that set swapaccount=1. While this > is a nice affirmation that always-enabling was the right choice, we > certainly don't want to warn when users request the supported mode. But shouldn't such users be still warned about effectively unused option? I think `return 0;` from the param handler should ensure that. > + if (!kstrtobool(s, &res) && !res) > + pr_warn_once("The swapaccount=0 commdandline option is deprecated " commandline Regards, Michal --ifpowlilw3jtc7ow Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZdNltQAKCRAGvrMr/1gc juU8AQCiaPhuMzNBRds24LnLkLrdU13FWaz9U416QQSNSADfBwD/SBYoMGN5ze1k 0GP/LNuyKMEMrQa7zSRq6963II7goAY= =Jopi -----END PGP SIGNATURE----- --ifpowlilw3jtc7ow--