From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6B08C4361B for ; Fri, 18 Dec 2020 16:59:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4320123B53 for ; Fri, 18 Dec 2020 16:59:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4320123B53 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BBB056B005D; Fri, 18 Dec 2020 11:59:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B924B6B0068; Fri, 18 Dec 2020 11:59:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD00B6B006C; Fri, 18 Dec 2020 11:59:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id 8ED926B005D for ; Fri, 18 Dec 2020 11:59:40 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1FA49363B for ; Fri, 18 Dec 2020 16:59:38 +0000 (UTC) X-FDA: 77607014436.28.dog45_2c006cc2743f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 3A8586D62 for ; Fri, 18 Dec 2020 16:59:37 +0000 (UTC) X-HE-Tag: dog45_2c006cc2743f X-Filterd-Recvd-Size: 2678 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Dec 2020 16:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=+xN9GQRorrUGy150P3shy7r3NADexgIi08+DtMTl7Js=; b=g3Q59fqOx9DsUxJUKJorQaUhot 97VRI3w+Yrvz6gfvgXBeIg2tY0xSmaj2UyCdY5gZc09+Zya1TiyHMwn4Dqwanz0kXbDBEr0lgyq+I q2scXZvRREVhcBm4UTnz+NPIn3gud21neOLzO7c9nKU0IJHvKuzSCN1eeao0MMXx47JQhhOgY8FNa aXk5kqfHjVGkwKjkOdOD+UJjNrnbvGwsuanKMspWzolqQloccEVVescD3nMxVK8r/MR05aM7FO51I odCu6Xr9hLufdyG+ose8ND27YtuJ+IlNMJe9xiy6lIWFCsFAxOTKygvWBzBtjTKprfmS5NS1edSav OOleA0fA==; Received: from [2601:1c0:6280:3f0::64ea] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqJ6I-0006FS-KV; Fri, 18 Dec 2020 16:59:30 +0000 Subject: Re: [PATCH] add pin memory method for checkout add restore To: hejingxian , Andrew Morton , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Cc: Hushiyuan , "hewenliang (C)" References: From: Randy Dunlap Message-ID: Date: Fri, 18 Dec 2020 08:59:26 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 12/18/20 6:25 AM, hejingxian wrote: > diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig > index 26956c0..73af2f0 100644 > --- a/drivers/char/Kconfig > +++ b/drivers/char/Kconfig > @@ -560,3 +560,10 @@ config RANDOM_TRUST_BOOTLOADER > booloader is trustworthy so it will be added to the kernel's entropy > pool. Otherwise, say N here so it will be regarded as device input that > only mixes the entropy pool. > + > +config PIN_MEMORY_DEV > + bool "/dev/pinmem character device" > + depends PIN_MEMORY depends on > + default n Don't need default n, it's already the default. > + help > + pin memory driver Better help text, please. Also, it should be indented by 2 (more) spaces. thanks. -- ~Randy