From: Randy Dunlap <rdunlap@infradead.org>
To: hejingxian <hejingxian@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: Hushiyuan <hushiyuan@huawei.com>,
"hewenliang (C)" <hewenliang4@huawei.com>
Subject: Re: [PATCH] add pin memory method for checkout add restore
Date: Fri, 18 Dec 2020 08:59:26 -0800 [thread overview]
Message-ID: <cff4fee2-af5a-c77c-c085-7a2aaa6c40ff@infradead.org> (raw)
In-Reply-To: <a68df79992c04bbf8167748dbeca1fcc@huawei.com>
Hi,
On 12/18/20 6:25 AM, hejingxian wrote:
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 26956c0..73af2f0 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -560,3 +560,10 @@ config RANDOM_TRUST_BOOTLOADER
> booloader is trustworthy so it will be added to the kernel's entropy
> pool. Otherwise, say N here so it will be regarded as device input that
> only mixes the entropy pool.
> +
> +config PIN_MEMORY_DEV
> + bool "/dev/pinmem character device"
> + depends PIN_MEMORY
depends on
> + default n
Don't need default n, it's already the default.
> + help
> + pin memory driver
Better help text, please. Also, it should be indented by 2 (more) spaces.
thanks.
--
~Randy
prev parent reply other threads:[~2020-12-18 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 14:25 hejingxian
2020-12-18 16:59 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cff4fee2-af5a-c77c-c085-7a2aaa6c40ff@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hejingxian@huawei.com \
--cc=hewenliang4@huawei.com \
--cc=hushiyuan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox