From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2079ECF256D for ; Sat, 12 Oct 2024 15:38:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 780B76B007B; Sat, 12 Oct 2024 11:38:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 730BD6B0082; Sat, 12 Oct 2024 11:38:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D2166B0083; Sat, 12 Oct 2024 11:38:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3D9FA6B007B for ; Sat, 12 Oct 2024 11:38:22 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 10C1F1401A2 for ; Sat, 12 Oct 2024 15:38:16 +0000 (UTC) X-FDA: 82665356718.02.F81B72B Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by imf16.hostedemail.com (Postfix) with ESMTP id B82ED18000B for ; Sat, 12 Oct 2024 15:38:15 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=scylladb.com header.s=google header.b=yGuXIyQ4; spf=pass (imf16.hostedemail.com: domain of avi@scylladb.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=avi@scylladb.com; dmarc=pass (policy=reject) header.from=scylladb.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728747428; a=rsa-sha256; cv=none; b=cM5AWSml3C82NuZNSjorPNmLW8Hfpl7Yj4JYVCP4GzhnlWcHBjomcK+Ki4yqVgNh+kq8is CvF9+kh0Ua80fso/NvjBcUaP7gd/6EfwLqmmMCgPRXzHL1kwke8CzbyMpfsQ3A66jBHqZe /6dBi0e4KtpyeeBQORq2SJIuZt8prEU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=scylladb.com header.s=google header.b=yGuXIyQ4; spf=pass (imf16.hostedemail.com: domain of avi@scylladb.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=avi@scylladb.com; dmarc=pass (policy=reject) header.from=scylladb.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728747428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uwn5Ca2i2Jc3vkMcfe5ykCwY+LQW8NrOJmZ3u2WcC4o=; b=YuQTXwXvIWdA+bQ3kgv+MDKfNN10qwYYgUzJmLBN86/9uV4Plw2bbhfX4VNauK4vy6irjx DuSciAk9JejqUGcPcJHb2c5AYTgqEt3/0yKPowNtOEG6xjvR2CDX30hb1UU7o0eFaeKN6W E7R1aWjDrxFnFwh4OXYiAoT7uduOE0c= Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-37d55f0cf85so1088856f8f.3 for ; Sat, 12 Oct 2024 08:38:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=scylladb.com; s=google; t=1728747498; x=1729352298; darn=kvack.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=uwn5Ca2i2Jc3vkMcfe5ykCwY+LQW8NrOJmZ3u2WcC4o=; b=yGuXIyQ46xX/bfK8ZviVQ200w8k1GnjG5dtQgRraYzG+4+EoHTZTxL5iHcNJQjpreA UJA/Z67HADFiPqgKuJFgZBjT4rUuKGtiGnPQZbZLVdvneZK/U5QNg5LjTxqdKe9pimrw KL5RQ6sKI0BSmdwuEJOx716QGOizo4pV6oMS8PTGq0XfR1VjQmT8p7on7JiaGlYmGslt OgFLGOQWcgJEBBkJuZ9cfR8CZNP7RNsu/HQGOG6qTMmMKz30Th44EalYLFGj+6c+MVfI gpek76ZWrjWqS2y27j18KoV3uTdvKClQ0n+F/Y+V0MywMiLByevTJA/5xPg4cQsdr8oe n2VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728747498; x=1729352298; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uwn5Ca2i2Jc3vkMcfe5ykCwY+LQW8NrOJmZ3u2WcC4o=; b=TfZyat4QJfqQ3RKDNiqdnmkmxjNYiKt2uoRoVrryL4+k9l1hd50Dli1hO1DUc0LHB8 4e+eH929tdddfWRAn2DmgBM2UAThU/uya441VSfOyAcQ4IyzhgW5n2ottZlp1zpDb6im aNLZYg4NrPdDArUhqQpuuM7R5wR1B95WeoLlv62YgjR27Ui/ncYrLiBEYyRGsRbsASlI uXKRXKq6/Ai6n2Xw/JrShRRXsDqTRut2PCJTFPAeV27O3dhxFWCgBLRR9abgZnPIIWa2 5oCZFps5Yqvv+1QR1IA5bF3WR3QwUClhNyhxsYQN8gcHthPHfStA5nvkYesjm23f2Mkq aFRw== X-Gm-Message-State: AOJu0Yyn4Nvkfv5jnh5KqiEBEthp6AGVEGIyCJ2ZHDpGzOKC9TgODLGk nd144M6yP0292GASKfURtC1WjJ2Yv9yhNja9zGVdhgWMXZbF51Hq8Z4xyunHz49wS7Hz9Eny8X3 DMgg32ILoFAvr3sJFPOJGcNra2uJrbgcwyw78pCadrlwz7hgVsUJvWjceOHbpYyMKyYMFdwuPl9 +e/my9fSvxlJkEZcGmVNBW7VKy8N4crtfybQynU6I+sDWdMqvhhDpJBGY5aM4Wbd0/6eBygNGXF lpnuPK4NabpyrjUIpOVAr/LV338fdr6n78XcWy3IbIgXVMoziaT3/edsol5jkwvAMazpdYFzH7/ p3ZWJQ== X-Google-Smtp-Source: AGHT+IHt2pmfd1ziocVj7zagasSVS9QePCQHa+T38c+tbC0RLfDS9pAQw1IubDKWK5cOloHLTC2HLw== X-Received: by 2002:a5d:63c2:0:b0:37d:52bc:72ed with SMTP id ffacd0b85a97d-37d551c9775mr3976553f8f.14.1728747497645; Sat, 12 Oct 2024 08:38:17 -0700 (PDT) Received: from avi.scylladb.com ([5.29.124.170]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b79fa79sm6688969f8f.72.2024.10.12.08.38.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Oct 2024 08:38:16 -0700 (PDT) Message-ID: Subject: Re: Possible regression with file madvise(MADV_COLLAPSE) From: Avi Kivity To: Yang Shi Cc: linux-mm Date: Sat, 12 Oct 2024 18:38:15 +0300 In-Reply-To: References: <8ac28fb858a2394cc72c3dc5924f1fd031fc6fe0.camel@scylladb.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.0 (3.54.0-1.fc41) MIME-Version: 1.0 X-CLOUD-SEC-AV-Sent: true X-CLOUD-SEC-AV-Info: scylladb,google_mail,monitor X-Gm-Spam: 0 X-Gm-Phishy: 0 X-CLOUD-SEC-AV-Sent: true X-CLOUD-SEC-AV-Info: scylla,google_mail,monitor X-Gm-Spam: 0 X-Gm-Phishy: 0 X-Stat-Signature: hswy7euei8m5j45uoqx7odepm3xfee73 X-Rspamd-Queue-Id: B82ED18000B X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1728747495-67396 X-HE-Meta: U2FsdGVkX1+lurRXb6Nf6kOcX4KE11nPtG35IrpBM6Hl8KE0SCFr22EHC3bMXe1glr5Iv1qg5My2EkeuwLqS8gQ+EagfMfueHyOi0oo5NxTeLxLaqO+jWsQKTXYXftqPWZpQwIQKY3oAi47ZCDQuMmCoDk1A+uBa25HuKVapHqUegifRb/qBkiwRBtYP58q08eR3vTuAZjhWZGwIt2SPLJzUg1eF85D6o5q557CJlJuBh/05tIafK6JdfA7Ubj88tLNJYGov1g1BNRON+449Onk0IlInwE8SId4sD1EkmQS9pdudqcpYrVR+FVkWOMx0GC/ew7pawi85ZgsjDmSSO6/1iWPBCkVlWYkDZgnzYQtcwQH8KyIjaydlrNbtFmVuynBh7qlKfIDRUejTjGiZTFQcYjx8yaWVINA0rQshUz6iOKlBeU+4gXtJHexJfwYySZ7YTbRG9jWEayjMhqnb+gdMgGlSiJTqs5QaKmhg1M6kY/3tnlroRS1QMN3zlkSmkcEMSyFTF8an79oUoL/qhVQRCOXIU0bHT4k0wZFGQZIJZcqgcnotTn33bcQYoV8pXt0BwcqnL9ZaAhGMhVijow4sYOSu6ZjqLD5VUlM1Rx6bvDtSZM+N+/lWlSHUbFTNaaItDMOQzShWjS+vgPqH0iY/1cHdnPeIdmISec3ZCsJhZGBp4jmsJYm6Ly+aR+8xcfi2X5l/sZ9YOcnkQmvusCg2rEKjzEOeP82cfzLnJ/iYvHBJ7xMoRMwN27zkC6Gyg1B2+XVkNH3vCX53cS66Iwn0zP8FBkyV4TpmJXpT1huxrz9xUOv21hT+fEJNI9qs/LbJzxeSF/O1BA/jbvl7q7UAb67CbHSix4px9WvMFNQrxBySpg3pEG84hgTkW2hr9bKFzjxAeOFVthN4beNiPxmBHCnCZHqvZ8XAj3YatraBmUKhkWTH7uU25Y+atZOIlSak5ZBdVw9CyDlwsRD MIYMUKN4 IL5srEmKypknmUc/kDZPQdhKdorsLKp1UD5t6MCrLXfTGRaFTUySlfe8oOcB9pLkV2qg3esESLk7Ih9kB8gXrkhhS0l8B9KVomreePjmRFxbuQXUn6CqVLC3JOs4nARzR0iyOud5tIQh7p1/p1BPIvfTME22r6szWLSJ3x9YRyVxFDYauKx9cXKTJp50kGqOc+Q/miJHVH8JcRaCvXPD8qTLb/OaLjdHiVtVTt5ZtIqwH8W+qT5VTZaN0DSapR+bQOdHatCLeKSdgBbfntG6OkWqHT0Wq9SaD+6AMXE97mYvr5B36WMxLvJ6uU9Ypty+4G0jAxjXyI24Y6huv7XlhXsbqNAjbSapNCatk/mPOtxQkgMHuH4ACfROIkGtIqzrovJJo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000823, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2024-10-11 at 15:29 -0700, Yang Shi wrote: > On Wed, Oct 9, 2024 at 9:04=E2=80=AFAM Avi Kivity wrot= e: > >=20 > > On Linux 6.10.10 with CONFIG_READ_ONLY_THP_FOR_FS=3Dy, > > madvise(MADV_COLLAPSE) on=C2=A0 program text fails with EINVAL. > >=20 > > To reproduce, compile the reproducer with > >=20 > > clang -g -o text-hugepage=C2=A0 text-hugepage.c \ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -fuse-ld=3Dlld \ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -Wl,-zcommon-page-size=3D209= 7152 -Wl,-zmax-page-size=3D2097152 > > \ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -Wl,-z,separate-loadable-seg= ments > >=20 > > and run: >=20 > Didn't clang make the page cache dirty? >=20 > Having sync between clang and the execution made the problem go away > for me. >=20 I see it even with sync (and msync just before the madvise calls). Tracing shows this (last lines before syscall exit): | hpage_collapse_scan_file() { | __rcu_read_lock(); | __rcu_read_unlock(); | } so, it's not clear what the root cause is.