From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FF49C49EAB for ; Mon, 28 Jun 2021 09:46:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8307E61C58 for ; Mon, 28 Jun 2021 09:45:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8307E61C58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8CD118D0029; Mon, 28 Jun 2021 05:45:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8550A8D0016; Mon, 28 Jun 2021 05:45:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A9978D0029; Mon, 28 Jun 2021 05:45:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id 335F18D0016 for ; Mon, 28 Jun 2021 05:45:58 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 131F0180ACF62 for ; Mon, 28 Jun 2021 09:45:58 +0000 (UTC) X-FDA: 78302651196.14.86E8487 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 486F5E00024C for ; Mon, 28 Jun 2021 09:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624873556; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J1ltTZwTcbRKQ9iE5O3Ko5LzXJiJvdzX6/FepyBCXnQ=; b=ZCUO8laIvt9WYNqeI9uv2xixeGwcmYzqB2QnFaE4FrBHGGEWpslAvDy+BV7I1XMjkS7ADm Svmijl50vKgq3bCxiueUkkSD8gFeMMAEDg/dpJ+G9RJ5YdfS2VgW4GBJrPnNADTG0ORaud 7diq2toeL3MuEkMrEWyYyUj+8+BUbI0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-563-tIm5qfhbPlig-mhyNGBaqA-1; Mon, 28 Jun 2021 05:45:53 -0400 X-MC-Unique: tIm5qfhbPlig-mhyNGBaqA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 98568804143; Mon, 28 Jun 2021 09:45:51 +0000 (UTC) Received: from [10.64.54.204] (vpn2-54-204.bne.redhat.com [10.64.54.204]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6A5F65D9C6; Mon, 28 Jun 2021 09:45:33 +0000 (UTC) Reply-To: Gavin Shan Subject: Re: [PATCH v5 0/4] mm/page_reporting: Make page reporting work on arm64 with 64KB page size To: Alexander Duyck Cc: linux-mm , LKML , David Hildenbrand , "Michael S. Tsirkin" , Andrew Morton , Anshuman Khandual , Catalin Marinas , Will Deacon , shan.gavin@gmail.com References: <20210625042150.46964-1-gshan@redhat.com> From: Gavin Shan Message-ID: Date: Mon, 28 Jun 2021 19:45:30 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZCUO8laI; spf=none (imf21.hostedemail.com: domain of gshan@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 486F5E00024C X-Stat-Signature: n9zze4k411cf6yo9yz58kz5y3n464kn4 X-HE-Tag: 1624873557-22927 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/26/21 12:18 AM, Alexander Duyck wrote: > On Thu, Jun 24, 2021 at 7:20 PM Gavin Shan wrote: >> >> The page reporting threshold is currently equal to @pageblock_order, which >> is 13 and 512MB on arm64 with 64KB base page size selected. The page >> reporting won't be triggered if the freeing page can't come up with a free >> area like that huge. The condition is hard to be met, especially when the >> system memory becomes fragmented. >> >> This series intends to solve the issue by having page reporting threshold >> as 5 (2MB) on arm64 with 64KB base page size. The patches are organized as: >> >> PATCH[1/4] Fix some coding style in __page_reporting_request(). >> PATCH[2/4] Represents page reporting order with variable so that it can >> be exported as module parameter. >> PATCH[3/4] Allows the device driver (e.g. virtio_balloon) to specify >> the page reporting order when the device info is registered. >> PATCH[4/4] Specifies the page reporting order to 5, corresponding to >> 2MB in size on ARM64 when 64KB base page size is used. >> >> Changelog >> ========= >> v5: >> * Restore @page_reporting_order to @pageblock_order when >> device is registered in PATCH[2/4] to keep "git bisect" >> friendly at least. (Alex) > > These latest changes address the concerns I had. > Thanks again for your review, Alex. However, v4 was merged and it's fine since v5 only resolves 'git-bisect' friendly issue on PATCH[v4 2/4]. Thanks, Gavin