From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D54BC4332F for ; Mon, 5 Dec 2022 15:34:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA6338E0002; Mon, 5 Dec 2022 10:34:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C56A88E0001; Mon, 5 Dec 2022 10:34:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1E1E8E0002; Mon, 5 Dec 2022 10:34:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A275C8E0001 for ; Mon, 5 Dec 2022 10:34:16 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6F602C0682 for ; Mon, 5 Dec 2022 15:34:16 +0000 (UTC) X-FDA: 80208648912.07.7CB7B3D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id E7FD91C001B for ; Mon, 5 Dec 2022 15:34:15 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Va+VdYVz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670254456; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=muzN8WEUVh1Z0hOwGhW5wqwCu57eFzBWrtNL2xNCBTc=; b=x0LP4Il8SBpZljf4rYrnUfL9PYNDjbtgURuLQ8C8nnUbPiZscgIFxiSX39l0j864JxbiKo 8+BlRclF6BpzHgBpngZBWhu8Hx5xMFmGNuuLt5eIw4TKHt2eBOE4rlvISm0hNkwExiPg6Z NP/65/6upwQxziybTde0YVRS5sZhlN0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Va+VdYVz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670254456; a=rsa-sha256; cv=none; b=BWShj/LBXg0WXOpKK23rC91vjg4VO1BDi3K2T5d0McbDaowkcAhfKOgGQ84iKWn0QUp/J9 kGQ6g+9EbibjQ7HK2eFU9WjU1jBIpNELwlmFrpCcyNhPJMFkt1cRZvK8AiQacCQyRpAiw/ Mt6kE92YfyqlfGSFH3JROKVFHOglcqQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670254455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=muzN8WEUVh1Z0hOwGhW5wqwCu57eFzBWrtNL2xNCBTc=; b=Va+VdYVzdr0AgqcJqGix+3sFMFXFIymGlv3RmyuUSNTtjNc6hoklR+yyW/TsqEmGBnKebM kLJMczpNxJP5AdHOZA8kIkH8C14zxl8iz8INSjkDRFTPyvB89CfDGxrsaLcysdEUjS6aST 1xH97BWsyRQXp6v6u+H/9JA3GahuEh4= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-336-scmXu0McNqChkJBWQ7jxjw-1; Mon, 05 Dec 2022 10:34:14 -0500 X-MC-Unique: scmXu0McNqChkJBWQ7jxjw-1 Received: by mail-ej1-f69.google.com with SMTP id sb2-20020a1709076d8200b007bdea97e799so7808509ejc.22 for ; Mon, 05 Dec 2022 07:34:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=muzN8WEUVh1Z0hOwGhW5wqwCu57eFzBWrtNL2xNCBTc=; b=odxq1YvOWNPqSoDjjnmph6DkfbYdThfn4icfAAXM/Z+eNFoh7UpWvT9oTaysfUeJM8 7vbsR/eakE6n0yC/u//DYtmB7GtfBD3dROdxWxSgm3uM6bQvvxNtRdl6u2vk95RdTlsl jbULepgdLra3vk78dHW6y5LbZs3ATmeyuW9JuaOhP7AN21UYSw3CGUVOHHKnga5u383d epaWwRa683WGt+sYwKf9l/P70iIlqtH591DeqTe47vynY77wXmVmh0uAhpjjdsIrPhNh t+LITxabHe2yda41LvPWapBicLxTEHB3YPDkWXzcOr6A7ArQUB0lEthv5+nmRgxayMDZ zdjg== X-Gm-Message-State: ANoB5pkuIgp7lhtaHvpi5guZOTmuAVe2Ap1XyzCNkO6hgl3xQPttJr83 9Vj2flgl0BglE173HflvMq/m/tQwv8+/I/G5W7HWPQDjiwrBShaTMCfPj0MIgDRzkLRX5A7bE1l 1wdee+IhRigs= X-Received: by 2002:a17:906:7244:b0:7ae:2964:72dc with SMTP id n4-20020a170906724400b007ae296472dcmr45976475ejk.111.1670254452823; Mon, 05 Dec 2022 07:34:12 -0800 (PST) X-Google-Smtp-Source: AA0mqf4YSL+fUvabB9FXexYRha1NrlEMMAkmKnUeYM8sAueMcqb0lGmkqOQXVjTmnT31HWfW7O5Gpg== X-Received: by 2002:a17:906:7244:b0:7ae:2964:72dc with SMTP id n4-20020a170906724400b007ae296472dcmr45976464ejk.111.1670254452609; Mon, 05 Dec 2022 07:34:12 -0800 (PST) Received: from [192.168.41.200] (83-90-141-187-cable.dk.customer.tdc.net. [83.90.141.187]) by smtp.gmail.com with ESMTPSA id si1-20020a170906cec100b007c0dcb30103sm2659470ejb.103.2022.12.05.07.34.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Dec 2022 07:34:12 -0800 (PST) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: Date: Mon, 5 Dec 2022 16:34:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Cc: brouer@redhat.com, netdev@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 00/24] Split page pools from struct page To: "Matthew Wilcox (Oracle)" , Jesper Dangaard Brouer , Ilias Apalodimas References: <20221130220803.3657490-1-willy@infradead.org> In-Reply-To: <20221130220803.3657490-1-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E7FD91C001B X-Stat-Signature: b6ge3kcwgnuw1fc5nou4hixnwxzkkekb X-Spamd-Result: default: False [2.09 / 9.00]; SORBS_IRL_BL(3.00)[209.85.218.69:received]; BAYES_HAM(-1.01)[80.05%]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; DKIM_TRACE(0.00)[redhat.com:+]; DMARC_POLICY_ALLOW(0.00)[redhat.com,none]; RCPT_COUNT_FIVE(0.00)[6]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; R_DKIM_ALLOW(0.00)[redhat.com:s=mimecast20190719]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:170.10.133.0/24]; TO_DN_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; RCVD_VIA_SMTP_AUTH(0.00)[] X-HE-Tag: 1670254455-876692 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 30/11/2022 23.07, Matthew Wilcox (Oracle) wrote: > The MM subsystem is trying to reduce struct page to a single pointer. > The first step towards that is splitting struct page by its individual > users, as has already been done with folio and slab. This attempt chooses > 'netmem' as a name, but I am not even slightly committed to that name, > and will happily use another. I've not been able to come-up with a better name, so I'm okay with 'netmem'. Others are of-cause free to bikesheet this ;-) > There are some relatively significant reductions in kernel text > size from these changes. I'm not qualified to judge how they > might affect performance, but every call to put_page() includes > a call to compound_head(), which is now rather more complex > than it once was (at least in a distro config which enables > CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP). > I have a micro-benchmark [1][2], that I want to run on this patchset. Reducing the asm code 'text' size is less likely to improve a microbenchmark. The 100Gbit mlx5 driver uses page_pool, so perhaps I can run a packet benchmark that can show the (expected) performance improvement. [1] https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/bench_page_pool_simple.c [2] https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/bench_page_pool_cross_cpu.c > I've only converted one user of the page_pool APIs to use the new netmem > APIs, all the others continue to use the page based ones. > I guess we/netdev-devels need to update the NIC drivers that uses page_pool. > Uh, I see I left netmem_to_virt() as its own commit instead of squashing > it into "netmem: Add utility functions". I'll fix that in the next > version, because I'm sure you'll want some changes anyway. > > Happy to answer questions. > > Matthew Wilcox (Oracle) (24): > netmem: Create new type > netmem: Add utility functions > page_pool: Add netmem_set_dma_addr() and netmem_get_dma_addr() > page_pool: Convert page_pool_release_page() to > page_pool_release_netmem() > page_pool: Start using netmem in allocation path. > page_pool: Convert page_pool_return_page() to > page_pool_return_netmem() > page_pool: Convert __page_pool_put_page() to __page_pool_put_netmem() > page_pool: Convert pp_alloc_cache to contain netmem > page_pool: Convert page_pool_defrag_page() to > page_pool_defrag_netmem() > page_pool: Convert page_pool_put_defragged_page() to netmem > page_pool: Convert page_pool_empty_ring() to use netmem > page_pool: Convert page_pool_alloc_pages() to page_pool_alloc_netmem() > page_pool: Convert page_pool_dma_sync_for_device() to take a netmem > page_pool: Convert page_pool_recycle_in_cache() to netmem > page_pool: Remove page_pool_defrag_page() > page_pool: Use netmem in page_pool_drain_frag() > page_pool: Convert page_pool_return_skb_page() to use netmem > page_pool: Convert frag_page to frag_nmem > xdp: Convert to netmem > mm: Remove page pool members from struct page > netmem_to_virt > page_pool: Pass a netmem to init_callback() > net: Add support for netmem in skb_frag > mvneta: Convert to netmem > > drivers/net/ethernet/marvell/mvneta.c | 48 ++--- > include/linux/mm_types.h | 22 --- > include/linux/skbuff.h | 11 ++ > include/net/page_pool.h | 181 ++++++++++++++--- > include/trace/events/page_pool.h | 28 +-- > net/bpf/test_run.c | 4 +- > net/core/page_pool.c | 274 +++++++++++++------------- > net/core/xdp.c | 7 +- > 8 files changed, 344 insertions(+), 231 deletions(-) > > > base-commit: 13ee7ef407cfcf63f4f047460ac5bb6ba5a3447d