From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8379DC433E7 for ; Tue, 13 Oct 2020 16:13:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DCC6B25249 for ; Tue, 13 Oct 2020 16:13:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCC6B25249 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 032F0900003; Tue, 13 Oct 2020 12:13:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00B14900002; Tue, 13 Oct 2020 12:13:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E63F9900003; Tue, 13 Oct 2020 12:13:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id D7203900002 for ; Tue, 13 Oct 2020 12:13:40 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A3A11824999B for ; Tue, 13 Oct 2020 16:13:40 +0000 (UTC) X-FDA: 77367397800.14.owner29_480d50b27204 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 7D8E918229835 for ; Tue, 13 Oct 2020 16:13:40 +0000 (UTC) X-HE-Tag: owner29_480d50b27204 X-Filterd-Recvd-Size: 2706 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Tue, 13 Oct 2020 16:13:39 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D2F42AC6D; Tue, 13 Oct 2020 16:13:37 +0000 (UTC) Subject: Re: [PATCH v2 1/3] mm/slub: Clarify verification reporting To: Kees Cook , Andrew Morton Cc: Marco Elver , Jonathan Corbet , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org References: <20201009195411.4018141-1-keescook@chromium.org> <20201009195411.4018141-2-keescook@chromium.org> From: Vlastimil Babka Message-ID: Date: Tue, 13 Oct 2020 18:13:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <20201009195411.4018141-2-keescook@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/9/20 9:54 PM, Kees Cook wrote: > Instead of repeating "Redzone" and "Poison", clarify which sides of > those zones got tripped. Additionally fix column alignment in the > trailer. > > Before: > > BUG test (Tainted: G B ): Redzone overwritten > ... > Redzone (____ptrval____): bb bb bb bb bb bb bb bb ........ > Object (____ptrval____): f6 f4 a5 40 1d e8 ...@.. > Redzone (____ptrval____): 1a aa .. > Padding (____ptrval____): 00 00 00 00 00 00 00 00 ........ > > After: > > BUG test (Tainted: G B ): Right Redzone overwritten > ... > Redzone (____ptrval____): bb bb bb bb bb bb bb bb ........ > Object (____ptrval____): f6 f4 a5 40 1d e8 ...@.. > Redzone (____ptrval____): 1a aa .. > Padding (____ptrval____): 00 00 00 00 00 00 00 00 ........ > > Fixes: d86bd1bece6f ("mm/slub: support left redzone") > Fixes: ffc79d288000 ("slub: use print_hex_dump") > Fixes: 2492268472e7 ("SLUB: change error reporting format to follow lockdep loosely") Not sure about those Fixes: tag as this is mainly an enhancement. I'd only use those for real bug fixes. > Signed-off-by: Kees Cook Acked-by: Vlastimil Babka