From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60AAED74959 for ; Thu, 31 Oct 2024 12:57:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2D2D6B0085; Thu, 31 Oct 2024 08:57:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB5A46B0088; Thu, 31 Oct 2024 08:57:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE1A56B008C; Thu, 31 Oct 2024 08:57:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8BFF36B0085 for ; Thu, 31 Oct 2024 08:57:48 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3BCA6121509 for ; Thu, 31 Oct 2024 12:57:48 +0000 (UTC) X-FDA: 82733898576.26.8B69706 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 7DBBAA0039 for ; Thu, 31 Oct 2024 12:57:18 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FAHeKpRy; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730379384; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e7lqBrJGwzCPo68ZE7+NaOI9FGmTKu9VV5AzlULMSGQ=; b=BmURtTpqGMa3bDg4NgzhWGiK3aZncL9Ffcb4xdH28l6mJuFukxoqb0wVImqcuN2oiMRo+6 TcB4B19swE1+Y/QxefisWg/3wfrDyvRFE4NlsJ33Zpjlwh2Avpe3X/wT2SKqO9Wdv/YrE9 Z80EteEatCx93fjw68lJCix53hSMFHc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730379384; a=rsa-sha256; cv=none; b=YlsETiQxxLF+qe/t473SgzqvJhnuAeOoB4Ja50BbkPlmQ+pAC/acNBh2cubO2zVZZtDKmI FHJH0xvBHwHBjMfuPPyrYrN0O9BAkyCBXGzRSVB+1oNfuexr/iDFieCdbOSOe+kX/ajZJY 1ZCdTIkUKOPXsum2HvFXV5B8hab7w+c= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FAHeKpRy; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730379465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=e7lqBrJGwzCPo68ZE7+NaOI9FGmTKu9VV5AzlULMSGQ=; b=FAHeKpRy2vdsx45EQ6/J+cJ8GM6TUtc03AYTHVJQxZk2FgG9bKkDKsSScsH8xsHXNdHeWj imxN49CMdhhfiRAPNJTAp7IQebMCIffmJ2NpsvgRynGfOiGs7nY2ebkV8RgOOq2zqx6Pa7 jvymj9ZnzN0iHtbFMoKa3ugdL6qdeQY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-90-g697wmInORewEK5mdB14zA-1; Thu, 31 Oct 2024 08:57:44 -0400 X-MC-Unique: g697wmInORewEK5mdB14zA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-37d4cf04bcfso401501f8f.2 for ; Thu, 31 Oct 2024 05:57:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730379463; x=1730984263; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=e7lqBrJGwzCPo68ZE7+NaOI9FGmTKu9VV5AzlULMSGQ=; b=oDL+J30Y4Aq0QKh6iPak9Z+Y52YXU3LG1xo+oEYZIR3jIUvWQnLb89l/lkl4kIyOxZ IxA03ICtUP4m5cJshzT1sEh16fcuWDRaFxG0MBTeQM6s7dz+IgmXnT35jgnfFTuoQBYh xjXlXU0eec/XIXUQAPHE+ZbpP4F6+JaHVVLdZ1vWdtjXh8lCDvlM8iap+rfz4RNfyNrK D3xl0n7y4rfCe0pn9JivcJebL6uBaNrnlENCZKCcgUdVEUAuYq8moo6E2GLbB1kGuZou /wFVM6jHtxNNCq6a+7WHUDC1u8wbpTeGoHAJ1f+bbUIGcnUVb2gLicbG1/kVXrVicx2f xNmw== X-Gm-Message-State: AOJu0YyGaJKsL4AMAB3rYq1hDCR9lGSxAyfz3FGf8QQ3F6TQLRh3zWEP WL8WMdBjqGPMWflL+3p+2dZ+fa7Djv3l5PrraB3+dvGDAHG7a5FJMciaOXlZytZpdMyeVgrY+5k OZGkIrmOeU/ay4yEYkJ1rJ8ukkrjOzsrmwImozObZbU9WvU00 X-Received: by 2002:adf:ef84:0:b0:37c:d20d:447c with SMTP id ffacd0b85a97d-38061163710mr12935228f8f.29.1730379462821; Thu, 31 Oct 2024 05:57:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE0J9/q3tFo4XeSLVcZXz3CbWqqLIM5gE8i1e7RDDh1jFP1bZOGOFsHQwWmb0PNuPoMuLElaw== X-Received: by 2002:adf:ef84:0:b0:37c:d20d:447c with SMTP id ffacd0b85a97d-38061163710mr12935211f8f.29.1730379462431; Thu, 31 Oct 2024 05:57:42 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:ed00:7ddf:1ea9:4f7a:91fe? (p200300cbc70aed007ddf1ea94f7a91fe.dip0.t-ipconnect.de. [2003:cb:c70a:ed00:7ddf:1ea9:4f7a:91fe]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c116a781sm2057848f8f.96.2024.10.31.05.57.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Oct 2024 05:57:41 -0700 (PDT) Message-ID: Date: Thu, 31 Oct 2024 13:57:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] mm: shmem: override mTHP shmem default with a kernel parameter To: =?UTF-8?Q?Ma=C3=ADra_Canal?= , Jonathan Corbet , Andrew Morton , Hugh Dickins , Barry Song , Ryan Roberts , Baolin Wang , Lance Yang Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com References: <20241030130308.1066299-1-mcanal@igalia.com> <20241030130308.1066299-4-mcanal@igalia.com> <2c507326-3267-431e-936a-23e2ab6a3baf@redhat.com> <899284fa-953f-48a1-af29-222d0d55881c@igalia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <899284fa-953f-48a1-af29-222d0d55881c@igalia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Stat-Signature: qetw3nzegxhggna5rz463nhfwdsu8fgf X-Rspamd-Queue-Id: 7DBBAA0039 X-Rspam-User: X-HE-Tag: 1730379438-122208 X-HE-Meta: U2FsdGVkX1/RfJbo9j5IZundya8Uy2/P/vQnGi+OnEOO1kNs8HdEIZ0DCwIyE8xbuqz8gOlLEb7yVk9cXIWG7/KcCw7dgqMy/Tm3rmdJQSyFCINDiqt8TpVZbscgZcjqVVryfwrM/u09JERGLrTAbllRRuz/wJMcUUo37V2Z63QAcYhN8OdI42o8DgCSzedLqpNYvvBrYEnHnjUrB710xLFzUX41duL7BV5FQUzOyj2Xa7biRtNj+dXPDrqEhVHcGuhCMghDj5FN2uYwt5w0ANaTtAROiKmSYjmc+Yzptfa2Gzrde22q/ijHEI6sfXaT/MM4IDlg4n6ZpmRX1B4KYiqJz8vz7tmulRsjOoiQxlSDhaZl67lOaU+YuwEW6T2PNS2Zu4VZc4oJ4YgYx+lO0jYrMHuj1tcoDotLGk28+ISSOQ7jrmUCjKgu+Jkhaf4SzGrViEAPHMJx/Tv9I9hb8tCxGJuSMNT08mvKNxmVmc2SPEb4G9HbZmrF9U/89Y6pVnLd6ETVWL1+6JhoLDfmpXQXApt0xrIru1kf0i7Nq2GIu5CAJMolFyfKF0ad8HzLyY9ML49F0ILUwZrlivmOpViCY4KyVwWy48sNuqEIMfMbRH2eHpitoaCJpMuq1/fw5kzHOTZyaZi9iN3DZBwI9MnUsxK4PhGXbABEJai3PaZU0DwJOjTamhsjbe1WJwKsuqTXIRHsYLgEKM8nsK3rvtRKOJnQo8bTggDHoSg+m9ru3tOWto+dV+o8rK2dwvjhy9oi7L3iQX5AeLn4gAJ/xXJDwtEBK+aRcdqQ3bnfiUEtHCa3qbO47ehtKw1IbARhmp+uRD1fMhyIae+2EEYEZ2Szo7YPrlAwun0T4yYBLSGOqVcsuRm6hZBYUpdPemtFOai5lg6w69rxu16fWrV9bnv2+EkMz2jn3TOOQ8uKgU80v8dlCn79Ujte+6mH8yhjxq4FUW6H1EniiP5XRSB 3BgSJ89v QKwH2RtPiw9JkTfztjHg0MRJ0PJd4LiMhMq0wDNgMjMZrth54RldTAAK6UQeUEf6HaPybiImm+i5PD7/LsAbAYBBONpPCkPZnzy1PA73uQmntSs0eR1/Sm82D6DiBf3FekuoJIDSHILvtjsaA0nv6qhV9B6M2Au05iAlN3SQMs21z65bXFdc43L8t4RQQa1fhRQmKx8NiwDxBArvOm0okugzyrGnzYzt3Rz5IbvXHU2k8wLyXl3UALVMXO9Xqx2xLYIfh4+NHC6yVDXxrerH3saGm7i9WrQQlJij2u0oc/QrKKLi0HKR2888i+vJk8tIk26QSSS8pWjPJ7r9AI3T1NKECIq+ABwNngHEomoa09xAsP9CsNp1HHylWvSZWCJYPiwEea+D7jvD0E766shBiRWYlBYFhmT5tqQi/dIslqsudq837htWyjHXTxD/SZAxInPw5Pww8FBBfblKqi6IaCTVLlzgwcBNhtWg1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 31.10.24 13:51, Maíra Canal wrote: > Hi David, > > On 31/10/24 09:37, David Hildenbrand wrote: >> On 30.10.24 13:58, Maíra Canal wrote: >>> Add the ``thp_shmem=`` kernel command line to allow specifying the >>> default policy of each supported shmem hugepage size. The kernel >>> parameter >>> accepts the following format: >>> >>> thp_shmem=[KMG],[KMG]:;[KMG]- >>> [KMG]: >>> >>> For example, >>> >>> thp_shmem=16K-64K:always;128K,512K:inherit;256K:advise;1M-2M:never;4M-8M:within_size >>> >>> By configuring the default policy of several shmem hugepages, the user >>> can take advantage of mTHP before it's been configured through sysfs. >>> >>> Signed-off-by: Maíra Canal >>> --- >>>   .../admin-guide/kernel-parameters.txt         |  10 ++ >>>   Documentation/admin-guide/mm/transhuge.rst    |  17 +++ >>>   mm/shmem.c                                    | 109 +++++++++++++++++- >>>   3 files changed, 135 insertions(+), 1 deletion(-) >>> > > [...] > >>> diff --git a/mm/shmem.c b/mm/shmem.c >>> index dfcc88ec6e34..c2299fa0b345 100644 >>> --- a/mm/shmem.c >>> +++ b/mm/shmem.c >>> @@ -136,6 +136,7 @@ static unsigned long huge_shmem_orders_always >>> __read_mostly; >>>   static unsigned long huge_shmem_orders_madvise __read_mostly; >>>   static unsigned long huge_shmem_orders_inherit __read_mostly; >>>   static unsigned long huge_shmem_orders_within_size __read_mostly; >>> +static bool shmem_orders_configured __initdata; >>>   #endif >>>   #ifdef CONFIG_TMPFS >>> @@ -5027,7 +5028,8 @@ void __init shmem_init(void) >>>        * Default to setting PMD-sized THP to inherit the global >>> setting and >>>        * disable all other multi-size THPs. >>>        */ >>> -    huge_shmem_orders_inherit = BIT(HPAGE_PMD_ORDER); >>> +    if (!shmem_orders_configured) >>> +        huge_shmem_orders_inherit = BIT(HPAGE_PMD_ORDER); >>>   #endif >>>       return; >>> @@ -5180,6 +5182,26 @@ struct kobj_attribute thpsize_shmem_enabled_attr = >>>   #if defined(CONFIG_TRANSPARENT_HUGEPAGE) >>> +static inline int get_order_from_str(const char *size_str) >>> +{ >>> +    unsigned long size; >>> +    char *endptr; >>> +    int order; >>> + >>> +    size = memparse(size_str, &endptr); >>> + >>> +    if (!is_power_of_2(size)) >>> +        goto err; >>> +    order = get_order(size); >>> +    if (BIT(order) & ~THP_ORDERS_ALL_FILE_DEFAULT) >>> +        goto err; >>> + >>> +    return order; >>> +err: >>> +    pr_err("invalid size %s in thp_shmem boot parameter\n", size_str); >>> +    return -EINVAL; >>> +} >> >> Hm, mostly copy and paste. You could reuse existing get_order_from_str() >> simply by passing in the supported orders and moving error reporting to >> the caller. >> > > Can I use functions from mm/huge_memory.c here? Yes, that's the idea. -- Cheers, David / dhildenb