From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C7E5C5B549 for ; Thu, 5 Jun 2025 02:43:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40AA66B014C; Wed, 4 Jun 2025 22:43:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 320758D0007; Wed, 4 Jun 2025 22:43:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 199F66B0145; Wed, 4 Jun 2025 22:43:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DC2B16B0135 for ; Wed, 4 Jun 2025 22:43:27 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7DB381412BF for ; Thu, 5 Jun 2025 02:43:27 +0000 (UTC) X-FDA: 83519800854.05.EBCD142 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf27.hostedemail.com (Postfix) with ESMTP id 80A4740011 for ; Thu, 5 Jun 2025 02:43:25 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749091405; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=opI5Vn/uafQmj6agNgSrbaBjYXRzwgyKQsbw8Rxw0Rw=; b=oBWtlwQcQgDV4ojSBkeu2CfN8Y1pUu99Wka47SOntEA2g2PxmZpnTSuzV9AXizZCs5xEia n31w6gMCSJaCR5oqlAhpTzftXPKmm1Ys0cGPuadGbnWhf5hpy5k1L7CxpuGzdsWVvJ0E8A kL1qr+SuKOoB3pT4nC2c00lz3XSkR5A= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749091405; a=rsa-sha256; cv=none; b=RIuUTdJE1LYvoSYlz2LMaZbD2dJeb5Ftx23DCrlgNfgPxQHVCzmnCoFdHLjOQ2V2GNdxdW Q6m9+O7HmH0Fjv/fCQzi4XcLwxnupnWJb9ZaqgYhNygg5bhfYH7Zywym66YJu48/7cliGy uh6gdggSag9RgwzfliEjUu4lLQf/luc= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3DC66169C; Wed, 4 Jun 2025 19:43:07 -0700 (PDT) Received: from [10.164.18.47] (a077893.blr.arm.com [10.164.18.47]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 561843F673; Wed, 4 Jun 2025 19:43:19 -0700 (PDT) Message-ID: Date: Thu, 5 Jun 2025 08:13:16 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: rename CONFIG_PAGE_BLOCK_ORDER to CONFIG_PAGE_BLOCK_MAX_ORDER. To: Zi Yan , david@redhat.com Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, isaacmanjarres@google.com, jyescas@google.com, kaleshsingh@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, masahiroy@kernel.org, mhocko@suse.com, minchan@kernel.org, rppt@kernel.org, surenb@google.com, tjmercier@google.com, vbabka@suse.cz, Oscar Salvador References: <20250604211427.1590859-1-ziy@nvidia.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250604211427.1590859-1-ziy@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 80A4740011 X-Stat-Signature: uhyepqdkgdzr6gw5k519tod5c76bhjhu X-Rspam-User: X-HE-Tag: 1749091405-673095 X-HE-Meta: U2FsdGVkX1832+QPLZlRIF2ns8DCERWNm+RIUhi74bQ+TxVsoT4pcWG4Zt0hMN+qJqJ8fhTug2QB8FyJXkf/O7RXnMo3sAw7WW6yZ1MUwACbQU7wNRoNbHvWfMG/4GSLLc6XlOyxRp0bbwf7kSiPbESuKfeohgH2jlDEeN2ZjsbcSYFuALFJaIYskn7mV+KQ5ecVIC5CdbaHslO7zmgvxKweRRz1w4q56wZ5pFrj6e4tsQ5CWCNOSSaAG6OcmbEuMquePaXcx/GprpnKr/LwfZsE8n1yoxVq8loDMSchT3sbbtm9RNDF2VJLBVb88lDztQ8/Kh2ihznKnZUcW9Sbu8TcGWLY8Gb8PYvrjNdG+a1Vqr1D2GPWUV3fp4Th9Vg6J3U5DJ5A+cXXgOMnCIt/DWDO/CikwmMvnP+PkRZqJtXdICYX7JmWoaz60SFXPyU52SNtI0hH6JrzIjRRJx207UiygylVl2Cpc6qGZsQUB2aybRajDM+qzsskswhc2x+ZPGIMPJbem8QJEuqkHU9fr6iR6EPhctREwzOyOBOKhawOZvAK10N9lISU1LAEg1JfXBC5NCqc+96xYDEXpZNj5ueYexOQtHsI18x1qepnUGmQzfcAwtYoVSKky3SpN3u85OOdchLn7TNaNZuMw2/IyQDUiz6wucZeIEZewowe+umu0hAW2M+rAsn6f0wmrt8DNGaOdDC9WED1MQ8OKyZ7f875a62KF2YtLHKtuAfoVMwoipejIUaM7YNbsdy+Syx4uQobLulWWwQl2AxmZnOF8151G9i/nWAkFFP32G1IAVTUsYGBzG9slqf1ezRISyodeSQEkp8O+vggpvmAmEF3HGptDvRaYFb31RD405pklerIt4p1H+6onCOPyKKE1LjnTstEuytllgDX4v3huuIeFUqHNFoUpjSuM3O4iZw/1aGtq50NM0q6UuNGnSmKRXl5/7wPzB/1So/0yzNX4C8 1nPAyF6i HMxYhflGEMQ4t1AuaI2/C4GRcSGV9lqJAEyugKqfYDUwKP2kXmd8GPBY9E0NKYONHICmgvDzQC65zmB/rrbKDxU99FRbYlnrJJ7tZaVVllktkQlPIPXRGntR5rNDFYnpsQOeB5BpLli5GAroEWqBc5KqSmeUE5Z8sLlbfIP/vd1w6JrwZk8m4BMbNZ8gED8W2jRQm70Vp5ewXwObYSzpnU0EblJrP/CEH3AKUoRQw9ZOSEg4ZgMeIr1q6P4lYyx8vZQgetr59uByviKVnAmEo3jgVW474a7L3SJff7FWoYEh/lhBXP2mjbaHQcfBN/nPCrUaUDw4BPvP2+5QuKpShvxSgHtVgqfhii3PVvCilNmW/ND8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/5/25 02:44, Zi Yan wrote: > The config is in fact an additional upper limit of pageblock_order, so > rename it to avoid confusion. > > Signed-off-by: Zi Yan > Acked-by: David Hildenbrand > Reviewed-by: Oscar Salvador > Acked-by: Juan Yescas LGTM. Reviewed-by: Anshuman Khandual > --- >>>From v1[1]: > 1. used a new name: PAGE_BLOCK_MAX_ORDER, > 2. added the missing PAGE_BLOCK_ORDER rename in mm/mm_init.c[2] > 3. dropped the Fixes tag. > > [1] https://lore.kernel.org/linux-mm/20250603154843.1565239-1-ziy@nvidia.com/ > [2] https://lore.kernel.org/linux-mm/202506042058.XgvABCE0-lkp@intel.com/ > > include/linux/mmzone.h | 14 +++++++------- > include/linux/pageblock-flags.h | 8 ++++---- > mm/Kconfig | 15 ++++++++------- > mm/mm_init.c | 2 +- > 4 files changed, 20 insertions(+), 19 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 283913d42d7b..5bec8b1d0e66 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -38,19 +38,19 @@ > #define NR_PAGE_ORDERS (MAX_PAGE_ORDER + 1) > > /* Defines the order for the number of pages that have a migrate type. */ > -#ifndef CONFIG_PAGE_BLOCK_ORDER > -#define PAGE_BLOCK_ORDER MAX_PAGE_ORDER > +#ifndef CONFIG_PAGE_BLOCK_MAX_ORDER > +#define PAGE_BLOCK_MAX_ORDER MAX_PAGE_ORDER > #else > -#define PAGE_BLOCK_ORDER CONFIG_PAGE_BLOCK_ORDER > -#endif /* CONFIG_PAGE_BLOCK_ORDER */ > +#define PAGE_BLOCK_MAX_ORDER CONFIG_PAGE_BLOCK_MAX_ORDER > +#endif /* CONFIG_PAGE_BLOCK_MAX_ORDER */ > > /* > * The MAX_PAGE_ORDER, which defines the max order of pages to be allocated > - * by the buddy allocator, has to be larger or equal to the PAGE_BLOCK_ORDER, > + * by the buddy allocator, has to be larger or equal to the PAGE_BLOCK_MAX_ORDER, > * which defines the order for the number of pages that can have a migrate type > */ > -#if (PAGE_BLOCK_ORDER > MAX_PAGE_ORDER) > -#error MAX_PAGE_ORDER must be >= PAGE_BLOCK_ORDER > +#if (PAGE_BLOCK_MAX_ORDER > MAX_PAGE_ORDER) > +#error MAX_PAGE_ORDER must be >= PAGE_BLOCK_MAX_ORDER > #endif > > /* > diff --git a/include/linux/pageblock-flags.h b/include/linux/pageblock-flags.h > index e73a4292ef02..6297c6343c55 100644 > --- a/include/linux/pageblock-flags.h > +++ b/include/linux/pageblock-flags.h > @@ -41,18 +41,18 @@ extern unsigned int pageblock_order; > * Huge pages are a constant size, but don't exceed the maximum allocation > * granularity. > */ > -#define pageblock_order MIN_T(unsigned int, HUGETLB_PAGE_ORDER, PAGE_BLOCK_ORDER) > +#define pageblock_order MIN_T(unsigned int, HUGETLB_PAGE_ORDER, PAGE_BLOCK_MAX_ORDER) > > #endif /* CONFIG_HUGETLB_PAGE_SIZE_VARIABLE */ > > #elif defined(CONFIG_TRANSPARENT_HUGEPAGE) > > -#define pageblock_order MIN_T(unsigned int, HPAGE_PMD_ORDER, PAGE_BLOCK_ORDER) > +#define pageblock_order MIN_T(unsigned int, HPAGE_PMD_ORDER, PAGE_BLOCK_MAX_ORDER) > > #else /* CONFIG_TRANSPARENT_HUGEPAGE */ > > -/* If huge pages are not used, group by PAGE_BLOCK_ORDER */ > -#define pageblock_order PAGE_BLOCK_ORDER > +/* If huge pages are not used, group by PAGE_BLOCK_MAX_ORDER */ > +#define pageblock_order PAGE_BLOCK_MAX_ORDER > > #endif /* CONFIG_HUGETLB_PAGE */ > > diff --git a/mm/Kconfig b/mm/Kconfig > index 65089552e124..3afac26d3594 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -1017,8 +1017,8 @@ config ARCH_FORCE_MAX_ORDER > # the default page block order is MAX_PAGE_ORDER (10) as per > # include/linux/mmzone.h. > # > -config PAGE_BLOCK_ORDER > - int "Page Block Order" > +config PAGE_BLOCK_MAX_ORDER > + int "Page Block Order Upper Limit" > range 1 10 if ARCH_FORCE_MAX_ORDER = 0 > default 10 if ARCH_FORCE_MAX_ORDER = 0 > range 1 ARCH_FORCE_MAX_ORDER if ARCH_FORCE_MAX_ORDER != 0 > @@ -1026,12 +1026,13 @@ config PAGE_BLOCK_ORDER > help > The page block order refers to the power of two number of pages that > are physically contiguous and can have a migrate type associated to > - them. The maximum size of the page block order is limited by > - ARCH_FORCE_MAX_ORDER. > + them. The maximum size of the page block order is at least limited by > + ARCH_FORCE_MAX_ORDER/MAX_PAGE_ORDER. > > - This config allows overriding the default page block order when the > - page block order is required to be smaller than ARCH_FORCE_MAX_ORDER > - or MAX_PAGE_ORDER. > + This config adds a new upper limit of default page block > + order when the page block order is required to be smaller than > + ARCH_FORCE_MAX_ORDER/MAX_PAGE_ORDER or other limits > + (see include/linux/pageblock-flags.h for details). > > Reducing pageblock order can negatively impact THP generation > success rate. If your workloads use THP heavily, please use this > diff --git a/mm/mm_init.c b/mm/mm_init.c > index f2944748f526..02f41e2bdf60 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1509,7 +1509,7 @@ static inline void setup_usemap(struct zone *zone) {} > /* Initialise the number of pages represented by NR_PAGEBLOCK_BITS */ > void __init set_pageblock_order(void) > { > - unsigned int order = PAGE_BLOCK_ORDER; > + unsigned int order = PAGE_BLOCK_MAX_ORDER; > > /* Check that pageblock_nr_pages has not already been setup */ > if (pageblock_order)