From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC994E77188 for ; Thu, 2 Jan 2025 11:21:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA6AD6B00A7; Thu, 2 Jan 2025 06:21:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D57696B00A8; Thu, 2 Jan 2025 06:21:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1E866B00A9; Thu, 2 Jan 2025 06:21:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A41516B00A7 for ; Thu, 2 Jan 2025 06:21:26 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 114AC47247 for ; Thu, 2 Jan 2025 11:21:26 +0000 (UTC) X-FDA: 82962270384.28.CEBFA07 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf27.hostedemail.com (Postfix) with ESMTP id 12B0740006 for ; Thu, 2 Jan 2025 11:20:29 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735816837; a=rsa-sha256; cv=none; b=HcFPivWm/sYMa9+vyZy5b28YKQQr8xDygxOSscJun9QTbqOaAMcg9SL7qYvnLEcuGWYBfH Mnded2VVQQPWojaHKGExzNf63FH7a5NJWdOh1rb7Jjp5PAmABeVWt7s9xx6w+lwKtpCVMx mxSYiroprSLU6PmnffS6wHdcR5Npj6U= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735816837; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gO9bmjsI39BWHRZcqR+1gP7etCcs1Id/CGJMNLo3JHk=; b=eaCwM4pSp9xnjYOIclGSrTNYqaND0yjP5nLncU91JLnciBUXNoyt8i99GdzdoSTH0aAA7Y mCSShVhMl0FzcjbzQrRCo5HuY9NtiEeW3OXVbsL8WuYfTXCtS+GCV6hzp1dvyU0IPX5CE4 VyLtnFeK09GCCwIjEYvv7tHD6L4owjU= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 263E011FB; Thu, 2 Jan 2025 03:21:51 -0800 (PST) Received: from [10.57.92.209] (unknown [10.57.92.209]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 47F0F3F59E; Thu, 2 Jan 2025 03:21:18 -0800 (PST) Message-ID: Date: Thu, 2 Jan 2025 11:21:16 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 02/12] khugepaged: Generalize alloc_charge_folio() Content-Language: en-GB To: "Christoph Lameter (Ampere)" Cc: Matthew Wilcox , Dev Jain , akpm@linux-foundation.org, david@redhat.com, kirill.shutemov@linux.intel.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, srivatsa@csail.mit.edu, haowenchao22@gmail.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, jglisse@google.com, surenb@google.com, vishal.moola@gmail.com, zokeefe@google.com, zhengqi.arch@bytedance.com, jhubbard@nvidia.com, 21cnbao@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20241216165105.56185-1-dev.jain@arm.com> <20241216165105.56185-3-dev.jain@arm.com> <5e716fd3-2393-8d41-bb68-9f589e4db290@gentwo.org> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 12B0740006 X-Stat-Signature: tqmhdumhe9sictakkxi4e196tghywsda X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1735816829-681092 X-HE-Meta: U2FsdGVkX18C/W1deUyOfllipxpDHO6Z0LgldE74B2LiPNi3L6W0WQuMcWIJtZAUxnJMZu7k7rh76VdPrg2kNjuifNIk+O1WnlEjV4AwJr8Hch0+3LPJ3Lxa7xm3k0j0rAl1501MGTulUWgvHj7RbvtUXPSle4bCeLmE/V0U0itZc++O1Mzd37eMgcN2gc6rwUnuJSNs9a74s3dLvzTt2eb5EdQmKoLH4sN1KT7/Eq71xs2Ykyk76n8bymgSbTk5taZusOsezeo+tDYnDx3QuNbc3UKpCVKTpYWh22ZQswfbI2uME2YUtIKdihkrFn44tvMm7fuVwlYjm4dt9QvVtCDmmnCmXX8rQERiMDqifcdmEDbl5Xlxcd3VZ8cqJgJ5IXzMUC1aJ+odwgqBXrxWTjJ5XPzu/antWLNhOpGAlXqYzqAwoDsWh97aLOg8d+L/eEMJ2RGkbenRkC3FGNdAwI6p8hFs4WwyqMAS2mYsL31XmHsbMQz/HAuetj0nLe7hZP0FOjmEVMD9eekA/UBowFj7cXnLBoCcPVQjXoTQ5ahJdjFPbJUxtDbQ738/7da83E3hXrFmEKtNRuZ1uffwGvmfLlZ0LpJ9Td9OlbfLMRdQKXEpaXzOiGpp8eZvBpcnyGDjd43NpCyeJNQvYl6jmtX/wrHg8FoHq0Wx5y+2D26rjbbJR76DDR4ULF3ev3cV/bkLmc5C6I22jT/nudjbcwWVZaoOYLBY+jEgZphjuLAYYJn5ZOPCSB6aNXSpbGdV39srPYRpyuAYj5lBPqrjzUWjrnQoPZfqGR4uotQam7XSCUdjyq009ySOzjZIAR5FHsqvMIgdj23/lvq+aEB/t4esv7V/b5Gst0G5sKq8YAIctr5+iaqcS1gUDsSeSHcgx5PYkK09eMNd7rRBU24soTW7aHbS1qfmCWtaqbVFl8FQvTpXZ8gjtHh2/DQiBzI3fk/XfxdGmXoWBbZZpwI ocV90OIv emQA6xgbdLykBpHQ5wqjCKuWGRpTq0sC8pOvjuPchCllf/piKR0ykXTuXrB0Y0PJJfK7veRT7OZAByUVw17vDkyflMzUZAyK9kXt05kcaM+FSAGQEXx/0KRNSSOhJq30/nfhBO76ZCDQ3AZeoF36eNNyrwiWziBaMWY1RlllW6pOnt2nHwMPTEsoSM3CVfizYb1Pa0Gzgnj4mH4VG4DEl4Hi7snGX3D1L0E85NGc6HVWt/pd4iB37rxRz+3mrv53OE1SY5VJ2/usy1FI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Sorry I missed this before heading off for Christmas... On 20/12/2024 18:47, Christoph Lameter (Ampere) wrote: > On Fri, 20 Dec 2024, Ryan Roberts wrote: > >>> Could we move all the stats somewhere into sysfs where we can get them by >>> page order? /proc/vmstat keeps getting new counters. >> >> This is exactly what has been done already for mthp stats. They live at: >> >> /sys/kernel/mm/transparent_hugepage/hugepages-kB/stats/. >> >> So there is a directory per size, and there is a file per stat. > > Then lets drop all THP and huge page counters from vmstat. Previous discussion concluded that we can't remove counters from vmstat for fear of breaking user space. So the policy is that vmstat THP entries should remain, but they continue to only count PMD-sized THP. The PMD-sized THP counters are effectively duplicated at: /sys/kernel/mm/transparent_hugepage/hugepages-2048kB/stats/ (or whatever your PMD size happens to be). Thanks, Ryan