From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37B76C83030 for ; Thu, 3 Jul 2025 18:53:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9BCE6B0250; Thu, 3 Jul 2025 14:53:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C733E6B0251; Thu, 3 Jul 2025 14:53:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B42856B0253; Thu, 3 Jul 2025 14:53:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A2B496B0250 for ; Thu, 3 Jul 2025 14:53:07 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2E95BC050E for ; Thu, 3 Jul 2025 18:53:07 +0000 (UTC) X-FDA: 83623850814.25.4E2CAE3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 8DBC8140005 for ; Thu, 3 Jul 2025 18:53:04 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="MT/Q1YjM"; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751568784; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UQFG5MIaFwRZAWTQLa6aA71YVsgcQ46O+CEYjW8Cdj0=; b=SNQOVPzKqP1NovxlmoxawMuTRRYBpSkJAj69caZdWdIBoFTvV3z3xv1coI+YDYbx7Rh44m d9rtLmk5edPZZ4n1M/M9OGSFP3taiWK/dKF739oXmKyvffXBvv3evroZrRdaSZDimgkYNe BWaIjZCfpj2VFlofpJwegYGptOwYYwo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751568784; a=rsa-sha256; cv=none; b=UAgjFymkWlsw6Ny2PDZb3Ws6GIqTdXlQ5SwO0hnJL4cXQUi++CVBMUQufEWhNWhn2gOr09 +PnZ8JZeGpCtQLT1gzz6DyHt2MTYT5pTuAG/qzygvV9wv/7HWFQpTaoMkqeKOmYXEU9X4y zQ7imwI2TwCCJc7DTY+RHX6xK7rWYfo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="MT/Q1YjM"; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751568784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UQFG5MIaFwRZAWTQLa6aA71YVsgcQ46O+CEYjW8Cdj0=; b=MT/Q1YjMP3Gu8RJjtwXkvb5JWd/8gANqwzIgARRITPShHkcgpIizbjOMdzn8dL+OyLjY6C 5T7Ojq6TBk6dXuC16bVlzIEVRu5XVfGQzllU5SdljXmwYI7TcWh4LJhXo7ScGHKMq+c9Mg aUgwu2SEbPuuOCqwlBYQyXzfJU9/Dnw= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-fpAVy8kTNP-1WQ9jyZEtEA-1; Thu, 03 Jul 2025 14:53:02 -0400 X-MC-Unique: fpAVy8kTNP-1WQ9jyZEtEA-1 X-Mimecast-MFC-AGG-ID: fpAVy8kTNP-1WQ9jyZEtEA_1751568781 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4537f56ab74so711085e9.3 for ; Thu, 03 Jul 2025 11:53:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751568781; x=1752173581; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UQFG5MIaFwRZAWTQLa6aA71YVsgcQ46O+CEYjW8Cdj0=; b=kX3xsAe2fIiHS4Gg08qZN9WsId/UXvWOQKh3UseAaOkdD3TodbknguZ97ruXvjFyVp COtFg6I8g9QrQHaynpixMswDJdS+FrBQxe2QJc0y/IWTwy0EZ/1DTxNdmnbAm7JtPZV1 fQEMV6F4XJ3ZuwuCKN2VlxKBo9DO1MVYEgR4yoN+yqQP6ysW7WPFDTzhD8LmMBWX5wmb zF9HNyNnpdDgLM0Ds8Q5UCT5L5r6MiFwoI8G4hBda/TVmAtoA2FUcCrLlUKT/RTl8O0S 3PyPSER5lxcP5IBUsgBYpIk2uY763ZOmX+9wItx8zGiPPD61HpyeAhrDSVrmCPfPzZq3 7dYw== X-Forwarded-Encrypted: i=1; AJvYcCW76ZLZlnQgEi2IHyHU+ysfejfk3XUUeTEKLU+M+jP5UkhPUKYsSOGRift7VvIUSykauD2CBN157w==@kvack.org X-Gm-Message-State: AOJu0YyxAq1KqxL7pgkstR9PMXNg3AOAHDJ4WXkJgXHvmS0m+Df9Ug6N qys0YRW07kQ1cvOTNrbHsVrrBoJ4nUaGJQoWGWZ4q97YrNBwGbJv4sGrjx7ssWEy1W3Ckrm05pj Hrx/k0UuQGarZ3MJBy2+WlFVWzkJzwEPQ2cd5sMh0PUzwbOTOOlA2 X-Gm-Gg: ASbGncsA7tXkOT2n+GgFGk5Uu2VxdpQ6mfKf9r4W/jd1HNYtuGTBdUZNqKOlKx/GM/v pIlQBYDyrWg0fwBd20WAKLpTK26BsxnNkAD4uxHpY3kKnQDi2bWUgegkRjtLnAoVXZ0SqgEE3Vt +zC0d6OqNUvof+WcCB/HfVqYGO3NWNdqkoNPYJouOC+s/xlB2lk0G2mneV9uig1/xG1co9xbZrK c9d5+O2hFjrYB/E/MDQGJfjyvTnSDwP8P5Yg23HsaSwyPD4UaWPm6HsEHE1TKkqzH1jhrnOcRSa l4YTmHbu01lnu8DG640N2mc/N6yC+bw3HVrVw71pPmRqkqzkfDV32xmTSPf3SckS9aO/mqiBvuN IF0zOEyUUnrgfLQhTuGnFpkv8Btd5HOf2UcVejR8v8haC839vSg== X-Received: by 2002:a05:6000:440c:b0:3a5:3b56:974e with SMTP id ffacd0b85a97d-3b32bae0ab0mr2281810f8f.6.1751568780859; Thu, 03 Jul 2025 11:53:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGC4kuZoJnTTQ8GzNjW4/Ni/tUzuIYJ3R5heK52xsq/73GJotrEymQXLDWyMbFRJetWfQMZLQ== X-Received: by 2002:a05:6000:440c:b0:3a5:3b56:974e with SMTP id ffacd0b85a97d-3b32bae0ab0mr2281800f8f.6.1751568780440; Thu, 03 Jul 2025 11:53:00 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1b:e700:2bf6:1031:382d:5a85? (p200300d82f1be7002bf61031382d5a85.dip0.t-ipconnect.de. [2003:d8:2f1b:e700:2bf6:1031:382d:5a85]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030bd42sm473211f8f.5.2025.07.03.11.52.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jul 2025 11:53:00 -0700 (PDT) Message-ID: Date: Thu, 3 Jul 2025 20:52:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] cma: move memory allocation to a helper function To: Mike Rapoport , Andrew Morton Cc: Alexandre Ghiti , Oscar Salvador , Pratyush Yadav , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20250703184711.3485940-1-rppt@kernel.org> <20250703184711.3485940-4-rppt@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250703184711.3485940-4-rppt@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: OxrWRKJ8g6Om7vmxYn6zG7p34Gf_Z7EgeIlUfZMAoas_1751568781 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8DBC8140005 X-Stat-Signature: ooeugj4pzxt7wa6afznwztmt8fbszmaa X-HE-Tag: 1751568784-180960 X-HE-Meta: U2FsdGVkX1+XTyiUnwiCQ4PaMTRYPL7BH7D3QsBMdLeT9fDQ62N+BRztUrO6Av6ot0rc4Cm0TMGpVORqdjE6eZ32sUnxdSLYNVI9aFfu4Z1hdAQMptPkZXSm+SIlk5Pv6DMhj10+f9eRSzW11ZatVXArJfrGHi1tPpzcQILMxWLu/cAGTM8MrL464P9oR9UbLNYPJTxpb7wqHZe/7bF+zHdHi5TIrklF4ZHjCn2Gw8eYINepxDSD7mPW9X88rthczItKBBTG52e5YtLC7wtmasPuxMQjdHm4AXdxFZtgn8WuTtQtY1MWQInImsS0dHtcg/9rEZMh4AovbS1XHcU3UICIwjlcpmrIAdbXiseiTnK7WEvBL0RE79K9k/1FtMBoEauug3vyjDZwRVpA2Ji85AYiYfP91t70dJbfdjeEQuWOkrvSNjDimHqk2y3sACSUwpYdyJ4ZET5aNQedmzvY5J4SfCWoNJaR99Yj7MFNoh/ysnq6g+s6KGPxGTiZQAAfIfB7S7K9i0f5lGvxjMNYNE108EYfYuD2jszU8uJ/9w/WYR1ZUVjtiBe7KEWDHl4VTrdl3syLAOLQKWJifMQhRGKC04JWGkraThEer6emfWV+jbHQBXWh1juDGgro/osFenewS97ERRxYUZmH1EsFPpipqK32G9aSsTmMuXz1Fz6jEQJIYswDgi16PMlHmmz0yjVdg56nnyGQl3XM7VNuqAtHP/VPIX3lhxtYKKG3+TbMRa3egpgbL0w78tqZsTK39us1FPrBK6yj14IVNdsVhltdAsMRsyO8G64PyWlSB5cfuEXd+smN8aS5x1P/9zJQUrScG83dKhYvIO215SeBKvfWHnOunfpkS+2WCO8XT+bMILWAJ0Ru6+ryal/XENGQ+rdusGL8QDIt7G9DFoIutxGTLPzLc1PLdTcHoTXOnQGkzFIG5yeOvj8UBCUnEl+mc/edzugjfN7rGvqabsw vJOk5wpy zfvs1d4t4Ub+EN5LKxlAtPWUXqQOEkbJxXY6Ai6+BBjp3bYgbV4N6z3gwLTW+d2ttDN0fFjw7bqf55KXyutPBSWqaFQcNAHPkAiDXjrCDbIPLz1YVBFXOVvg1IXw9rjuSFKaJ89RiyoTUcP46uJkWFCrQbDK5eLh8T/DYajZgU0LaizooUSV2KTqhVBjHxIh72yfLVH92CJygRkuPFhwP20MDdWxOKBZQcq6Jh6yvf8DGilHUYVvw1aaXWHI4t0wqOlsP1IK9Mv19enJv+nFa5uky5VXs9M7DtI84kANwHez+131fJInVByUW+N7x5+KLeeFqiDVXj/zXaMoSUb4KEleBLlP2whS/INZsLQYe+OhdyaPWOeLuuz5wIX0WeYaJb5LEtFSlcxICtTdIEjnhhmx3MwWSAUTof1Ey04VhTsW0uTrhg77nIOfvIavpVzbW9j4sUvcGASQQJSVE/SuywJSAY2ZN5zo+OV3/TYcxiQNFOfwqWHcmb5U0GhQuS8bs5W4tAXa4rJ/wbzozs7sxHC0x6A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.07.25 20:47, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > __cma_declare_contiguous_nid() tries to allocate memory in several ways: > * on systems with 64 bit physical address and enough memory it first > attempts to allocate memory just above 4GiB > * if that fails, on systems with HIGHMEM the next attempt is from high > memory > * and at last, if none of the previous attempts succeeded, or was even > tried because of incompatible configuration, the memory is allocated > anywhere within specified limits. > > Move all the allocation logic to a helper function to make these steps more > obvious. > > Signed-off-by: Mike Rapoport (Microsoft) > --- LGTM, thanks! Acked-by: David Hildenbrand -- Cheers, David / dhildenb