From: David Hildenbrand <david@redhat.com>
To: Mike Rapoport <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Alexandre Ghiti <alexghiti@rivosinc.com>,
Oscar Salvador <osalvador@suse.de>,
Pratyush Yadav <ptyadav@amazon.de>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 3/3] cma: move memory allocation to a helper function
Date: Thu, 3 Jul 2025 20:52:59 +0200 [thread overview]
Message-ID: <cfc1c95f-3e3c-4856-b831-bffaa6457c03@redhat.com> (raw)
In-Reply-To: <20250703184711.3485940-4-rppt@kernel.org>
On 03.07.25 20:47, Mike Rapoport wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
>
> __cma_declare_contiguous_nid() tries to allocate memory in several ways:
> * on systems with 64 bit physical address and enough memory it first
> attempts to allocate memory just above 4GiB
> * if that fails, on systems with HIGHMEM the next attempt is from high
> memory
> * and at last, if none of the previous attempts succeeded, or was even
> tried because of incompatible configuration, the memory is allocated
> anywhere within specified limits.
>
> Move all the allocation logic to a helper function to make these steps more
> obvious.
>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> ---
LGTM, thanks!
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-07-03 18:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 18:47 [PATCH v2 0/3] cma: factor out allocation logic from __cma_declare_contiguous_nid Mike Rapoport
2025-07-03 18:47 ` [PATCH v2 1/3] cma: move __cma_declare_contiguous_nid() before its usage Mike Rapoport
2025-07-03 18:47 ` [PATCH v2 2/3] cma: split resrvation of fixed area into a helper function Mike Rapoport
2025-07-03 18:47 ` [PATCH v2 3/3] cma: move memory allocation to " Mike Rapoport
2025-07-03 18:52 ` David Hildenbrand [this message]
2025-07-03 18:54 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfc1c95f-3e3c-4856-b831-bffaa6457c03@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexghiti@rivosinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=ptyadav@amazon.de \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox