From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38760C761A6 for ; Mon, 3 Apr 2023 07:55:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8FD66B0072; Mon, 3 Apr 2023 03:55:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C164E6B0074; Mon, 3 Apr 2023 03:55:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A908E6B0075; Mon, 3 Apr 2023 03:55:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 91D0E6B0072 for ; Mon, 3 Apr 2023 03:55:54 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6E1731A0440 for ; Mon, 3 Apr 2023 07:55:54 +0000 (UTC) X-FDA: 80639321028.12.FF29E3B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 1ED671A0013 for ; Mon, 3 Apr 2023 07:55:51 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=P1xoj2rq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680508552; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sVQLi5QSZyMPwG4jud4CiER62DN4sgoj+A/Lhx1bVMM=; b=ZJ/AwstJz0Yl6yEhxRNP/jidLrCFOicy8R7EQ0ipPry5qxXX18NbUZ76zxbDVbbs2f/xuU 50mrB/oKyiPAZcFABVdRqVat2TNVMkjq6xlRZDoRqZmQOcQQvTa47ylzOPU1Pb5eVyus1O 4o/Xl81hdLuku0N8TzhLRkKoSZMOkCE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=P1xoj2rq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680508552; a=rsa-sha256; cv=none; b=oTtGp65XJdLbhpV/Lpy/dr9EaI+p1pKDTAyXw0Rmbs4ppS/77hcc9XtY4mQN9Aj3wUVrRb gRA/eK1Xn7Dlx8QDjUCXwfKGIoW9YYcZYGoksb9SKw2RkhV5zdZy5RDVDxotvnFRatJ9Mg QSPGIAxEZc5rA7d3sOr/N8KlbTc/psA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680508551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sVQLi5QSZyMPwG4jud4CiER62DN4sgoj+A/Lhx1bVMM=; b=P1xoj2rqmYmXhM9mAKgAxqtiav3gkvRHIZlVAc4x+BwTnX/40AnlIr3FNOfblyGfI5YIys SuBUZExCGQFUp5+Tv4liuUg9m3MVXX3pmm7qDuSNHi1jtK2PE6cahjxsnVdCFnXtLbHFh3 OOcL+HocWEfPqHxL2/8BDVxIroF507w= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-ldYKn3SjPEuiR7T8py5wuQ-1; Mon, 03 Apr 2023 03:55:44 -0400 X-MC-Unique: ldYKn3SjPEuiR7T8py5wuQ-1 Received: by mail-wm1-f72.google.com with SMTP id n3-20020a05600c3b8300b003f048e0e09eso708301wms.1 for ; Mon, 03 Apr 2023 00:55:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680508543; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sVQLi5QSZyMPwG4jud4CiER62DN4sgoj+A/Lhx1bVMM=; b=qaxhlgR6dbPbjVnlP1ybzoezN6HQqnV2TYsezwS5OZ05FbsUy/jPfTrSrw4yBU3hB3 ZzGBSgDeeeE7kwNG3HtgNxLBF73sx6CMu6YJH/e9S0DoKpkB8eORRPF1o8qOv2UetQfh JNGhBn8/YOupZJOU7CBYiWj3eFJ5Pg0eHEPufxYtOJzi2Qs5yVJS/H74O7SlUdjcHc19 wtVjFMNeMN3hsIlbqm8eCBrvPm5wajsxeLDu+iRLmBr+OTnzmlf1b/ZokKWn9W1ib6Gd gRtGa0rKp3WQ8Levdb8rS8XJBBW31i41UO/0OVWLbQbgOBM0q5jr/vT35UgUVvXt1lXB WqvA== X-Gm-Message-State: AAQBX9fF4aLPshE2rqSz1kNEF6eDIZzShOQnOjSunxIBAkw2OlaAWSdg dcbYvAyZMi6bfzKPxt/Zp7kDy1kV0UZqXAGfYo8AMeBiY2g134GLBlN6WpjF9jnvppftxx6Cg0F B9X11hWIOtkg= X-Received: by 2002:a5d:414c:0:b0:2d6:4e98:5f32 with SMTP id c12-20020a5d414c000000b002d64e985f32mr24902090wrq.23.1680508543496; Mon, 03 Apr 2023 00:55:43 -0700 (PDT) X-Google-Smtp-Source: AKy350biYQRdaJzXlwNnzia2dMdfasRhuzALSoeVME3YQUzTMjBhElnTS15MLjaTNBVgoLfB5ualLQ== X-Received: by 2002:a5d:414c:0:b0:2d6:4e98:5f32 with SMTP id c12-20020a5d414c000000b002d64e985f32mr24902068wrq.23.1680508543183; Mon, 03 Apr 2023 00:55:43 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:5e00:8e78:71f3:6243:77f0? (p200300cbc7025e008e7871f3624377f0.dip0.t-ipconnect.de. [2003:cb:c702:5e00:8e78:71f3:6243:77f0]) by smtp.gmail.com with ESMTPSA id m17-20020adfe0d1000000b002d1e49cff35sm9038705wri.40.2023.04.03.00.55.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 00:55:42 -0700 (PDT) Message-ID: Date: Mon, 3 Apr 2023 09:55:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 10/29] selftests/mm: Test UFFDIO_ZEROPAGE only when !hugetlb To: Axel Rasmussen , Mike Kravetz Cc: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Andrea Arcangeli , Leonardo Bras Soares Passos , Mike Rapoport , Nadav Amit References: <20230330155707.3106228-1-peterx@redhat.com> <20230330160714.3106999-1-peterx@redhat.com> <20230331183726.GD12460@monkey> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1ED671A0013 X-Stat-Signature: fshh9afbokcnpei8h7hu1az686o8sibs X-HE-Tag: 1680508551-461897 X-HE-Meta: U2FsdGVkX18BQNGWcH/Jbzb7A0gokolN03tnTrHWl4wwVNv5WEdlRdIZmm2x4oxPbJxH/2cokouhZLe2r/+bqqct1TfWeY4oKY53DZ5xXQvdkuIHkQOYk+Yc96wSexjUQ+L7DFz+EmiA6mS2kmejrobTEOGyMhSaVcDfj60un9cP1OF/vKZAdvcvlb6FL1fuonWEZSBWhBLeoZ3fQt4QfbRevcMH06iOry3kDU0S7RHRdKClXnwJuANAPputh5NlsxTq2mrcEOlyTnclIoCN9FcPnjefbzj4RUA422fzOGp97smNiB/gYdfA8rrwsgkR8Ftpc+T66nFX0YBqVKk5zhmZmtODA0hUur6ITPCOdS8RcwnCnyFJf6vltqlnEXTZe1+wAhIaroxFLCGqF0LuDUheYevAxQoknBY6UYlZdbo3Nf37KqXSdC70cuVO7o3i+8zf+waWoK3I/G6eg9PFqY90o2PVGAo7+X/rAyiV28aUax9uGh8I+24+v7k7lxGRIJYSXOnB8ES434P+Ag+fsXY+E+qcaKF6G1Bv3D/1uyXncv8Hp2KH5mFX92mX41nLTCgKt6yM4nlIDzAao7Ao0xComGJXHY1s+WQmJu7FxRDgEBcLYOthITyCobCKS+TUWOgCQgg31gSqMaW7nStSbiY1uQoPiNXyRHsPOpAeIrLYJw1tT/ScSYclXxMkAbDiUk7L+BCVqPT4/Do8EV2OVnTc89Id71I9xlEUUVo1oVfoefqImdLwkgbIn+CONEbLncvk4nYgaYbDRz0b4ly5x+q5FOuodOjSzw3d5u5Rkyf20/TqMXWGq/W/inm++qFHfIjc17hIGS0jYxgTWGFQ5ZchwodzKo3xvH0lVGu0B9H670xYosKLKASSuB6x5Xn8YDW3UPUmVfwAUhzdBhUZgycbaux4uuOd50CLWSJ5ZCV5HOpAsWGivZVZE4/3ISv+XLjzpoQ+dmBUFRVfAyf MhN21vyK Ra8u3P3OJ4cg7Y4J9BzjMwiT2eAfCinpeO3gYrjOoOLaUYAkIstQ/E6y5IYFyEVjLDIX5SSwV+/bJYP9QE5HJncy8tkcrSNjDPsrtdCHN0i1R3LqOt9se0FGHUBcrbpJFVGwNb4LvYFMkuWc7te9LTamHohFOe+5fYwG9GxCD2zgbU4bw7Y1pG6oRcnL4OG3A6fgM9/nVNBT6VdIMqJf3TqSWBI3+vEF+dGSn3IVXLtkBqOrOdruqS4j0DHM/Oer9LeupQV7RQieIla1a+0svsx2LQ//b7KUHdORw97Xbgn7j24U35IkVLZV6ULXEmfm0/SQ4HvbDZCTFqYla6tXGHq4i7cOTS30KDNxBSg38smcQ3BXP8/geo451YAPf5KVpZREyu8+m3/PSasrr91jpqyibD4s+rHkcobyA4VVvf0MtryPp8CLVyTGKrWlHP2vhs2zrqJFSrFX7cWcq43ANFhnI7FhHy4Ave6Oq2GzYx4QTLEnuBaa66caUgpBpO7dF/Yrs+Mz66RCI5L3I+vJk++6oRJvbFtQU3Q9nibqVbgzu/09fdp00dz7LEu+ajpMu0ZnKGQpWobFUavTEM1ZzGNF88HPgHD2mBsaZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000068, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.04.23 03:57, Axel Rasmussen wrote: > On Fri, Mar 31, 2023 at 11:37 AM Mike Kravetz wrote: >> >> On 03/30/23 12:07, Peter Xu wrote: >>> Make the check as simple as "test_type == TEST_HUGETLB" because that's the >>> only mem that doesn't support ZEROPAGE. >>> >>> Signed-off-by: Peter Xu >>> --- >>> tools/testing/selftests/mm/userfaultfd.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/mm/userfaultfd.c b/tools/testing/selftests/mm/userfaultfd.c >>> index 795fbc4d84f8..d724f1c78847 100644 >>> --- a/tools/testing/selftests/mm/userfaultfd.c >>> +++ b/tools/testing/selftests/mm/userfaultfd.c >>> @@ -1118,7 +1118,7 @@ static int __uffdio_zeropage(int ufd, unsigned long offset, bool retry) >>> { >>> struct uffdio_zeropage uffdio_zeropage; >>> int ret; >>> - bool has_zeropage = get_expected_ioctls(0) & (1 << _UFFDIO_ZEROPAGE); >>> + bool has_zeropage = !(test_type == TEST_HUGETLB); >> >> It is true that hugetlb is the only mem type that does not support zeropage. >> So, the change is correct. >> >> However, I actually prefer the explicit check that is there today. It seems >> more like a test of the API. And, is more future proof is code changes. >> >> Just my opinion/thoughts, not a strong objection. > > I agree. The existing code is more robust to future changes where we > might support or stop supporting this ioctl in some cases. It also > proves that the ioctl works, any time the API reports that it is > supported / ought to work, independent of when the *test* thinks it > should be supported. > > Then again, I think this is unlikely to change in the future, so I > also agree with Mike that it's not the biggest deal. As there were already discussions on eventually supporting UFFDIO_ZEROPAGE that doesn't place the shared zeropage but ... a fresh zeropage, it might make sense to keep it as is. -- Thanks, David / dhildenb