From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 300F3C25B76 for ; Mon, 3 Jun 2024 06:40:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2F526B009A; Mon, 3 Jun 2024 02:40:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDFC46B009B; Mon, 3 Jun 2024 02:40:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA9E96B00AA; Mon, 3 Jun 2024 02:40:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8F4146B009A for ; Mon, 3 Jun 2024 02:40:06 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 48027407F9 for ; Mon, 3 Jun 2024 06:40:06 +0000 (UTC) X-FDA: 82188627612.03.F5AA18D Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by imf22.hostedemail.com (Postfix) with ESMTP id 07050C0002 for ; Mon, 3 Jun 2024 06:40:01 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717396804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RINLfXeQHbOppNLaJxgDFun/nAPvjxPzFW0NJef8qXA=; b=wqNa/SVRTNzmM753xT+Mn/26EMlQdrbcXx2CuCOsFG35fB9yIK6QrqC/NQWA4BWlY/WvLy PgfjofgD+nOuoS8sfeiiWDVOHQhT+INfThMnI/iOV1Il3fHnYCA0BVutMwtKreMUl+jBYd XiJs7MhC6IlsOew6GKVadI6OrhZ2wOA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717396804; a=rsa-sha256; cv=none; b=t2TVaGZRlLDPGiX1HavQXXZoO9aKVtxic/+uJ4oUNJ9Tvft6l1FCIZjcbfDo2ie6b03GoH udUkOrkmCTAtI8J1nywXIcVDYLTuq6sveGXuZ9VTvbbAf49Ys1K12TZsf1gKuAbNXX8xu5 Kt9aiNjjHU67UMuhFwX5g+mW2VePnjc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4Vt3xH00RCz4f3jcv for ; Mon, 3 Jun 2024 14:39:46 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id 8BF1E1A0170 for ; Mon, 3 Jun 2024 14:39:56 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP1 (Coremail) with SMTP id cCh0CgAnQAk8ZV1mZHu+OQ--.43911S2; Mon, 03 Jun 2024 14:39:56 +0800 (CST) Subject: Re: [PATCH v2 8/8] writeback: factor out balance_wb_limits to remove repeated code To: Tejun Heo Cc: willy@infradead.org, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240514125254.142203-1-shikemeng@huaweicloud.com> <20240514125254.142203-9-shikemeng@huaweicloud.com> From: Kemeng Shi Message-ID: Date: Mon, 3 Jun 2024 14:39:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:cCh0CgAnQAk8ZV1mZHu+OQ--.43911S2 X-Coremail-Antispam: 1UD129KBjvJXoW7ArWDJr1UtFy7KrW3AryfCrg_yoW8Jw1fpr WIyanFyF4DtF4Ig3ZxCayxZr9IqrsxZry3JryrJrs3tr1a9rn7KF9xZrWruFy7Cr1DGa15 Zr4DKas7Gws5CFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUyEb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxk0xIA0c2IEe2xFo4CEbIxvr21l42xK82IYc2Ij 64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x 8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE 2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42 xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIE c7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU1wL05UUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspam-User: X-Stat-Signature: hr5midjp84ot3q1j47dpq8rhg1qdjnfw X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 07050C0002 X-HE-Tag: 1717396801-758749 X-HE-Meta: U2FsdGVkX1+Zx8+KogoaVfOzi6n/4Dz73fiyD/JNe0OjgRHzUv4CEwKbVns/aerXJ6pcEd1uCdutoF9707VBD//E/HR9LAUDe/32uU2LFL199g9zGe5++dIu8zw6g1GUbNFrrI+gRC5NrGyqzkELg7EDPXi/eFKZ19NwPz47wzsP/om6qs/GnLmRyTU52lLqyO9cDw0/W57NZFMKWJX/6vv2PFXh0Ehsxw5lduUUSn8rxTd/5hrquZhYbsudHHb+TEdam6+YJs7zFQ9mBixdVPj1gjdRuQ8O/rK1rMJnhhJ4gjp9ozipX5/qn4ily9dU6LJgPV/tCAs3hdMFTRl8V/2YIXi09hlsHNnEtntWWoORmgIbbgtl/sRPhvYZNUaYSYJCsrjX5nQ7Sc0elkW3EU7nuqkZcdar3APO2PJBoiE6r6BZPWSFQ/zwvqKDzRFuxkxWPvtQ3b9sTlRMsO0AH2CHF6hEJP7YhgMHIgbuwB5USz8KswvPpHNfg3zBaSeB4sqnA47OPz79YJBjlmA44/7VUZSpkOXhuvtngMfUBHvOoELGyxsrCHl1NZNzLZgWm3GVtikpHZD5SZOofODyDVwkS0QiqLiROJKmtT54u7dsm+Xl+To9PEVuxC9eWLdtKXswyp+QyBuXY4mXmX+ckraeqAKy3QdmD2KRfBi3B1zEK858bYk7t6quacKLZe5XkHFeIOGus8fFt9Q85noYmoTczhaLw4TpqcbcAnEYBmm0vDvdETGHIdjKkpCHi567cujuC1bZLAmmrX0N4OpWLF7TsyR2p68RI5hdw4FLRl4XRU6O972D2gd4WBISONIeITnHW+Ptduvk84/+ifsAR2CFolT53qZMS9zatX4oySI7Xhy97laJ/lNQsY/Lu6JmtGuqXZT5bf1HPpn62mObnCKbWY8AAYaAO2QKeV3Eh40ewke+QIe+ma40TOCjMQELTcXnVJQwauCIj2NleH9 AmdkhQuU 5KCnPsp9myuUIo5iVCCaxsxFKT7eH53w384q4pC39EaNdk6XcFQ1yPs003tqtd6TOD5GLxSUcLrcUzGEyOLt35NELNBOLO2f11+k4dauk0URMG6t1dxOcisP1+eIrZWmG3FNErJFUrP1R1n8CZsiPW5m2OFdxcsDS2qb0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, on 5/31/2024 2:33 AM, Tejun Heo wrote: > Hello, > > On Tue, May 14, 2024 at 08:52:54PM +0800, Kemeng Shi wrote: >> +static void balance_wb_limits(struct dirty_throttle_control *dtc, >> + bool strictlimit) >> +{ >> + wb_dirty_freerun(dtc, strictlimit); >> + if (dtc->freerun) >> + return; >> + >> + wb_dirty_exceeded(dtc, strictlimit); >> + wb_position_ratio(dtc); >> +} > ... >> @@ -1869,12 +1880,9 @@ static int balance_dirty_pages(struct bdi_writeback *wb, >> * Calculate global domain's pos_ratio and select the >> * global dtc by default. >> */ >> - wb_dirty_freerun(gdtc, strictlimit); >> + balance_wb_limits(gdtc, strictlimit); >> if (gdtc->freerun) >> goto free_running; >> - >> - wb_dirty_exceeded(gdtc, strictlimit); >> - wb_position_ratio(gdtc); >> sdtc = gdtc; > > Isn't this a bit nasty? The helper skips updating states because it knows > the caller is not going to use them? I'm not sure the slight code reduction > justifies the added subtlety. It's a general rule that wb should not be limited if the wb is in freerun state. So I think it's intuitive to obey the rule in both balance_wb_limits and it's caller in which case balance_wb_limits and it's caller should stop to do anything when freerun state of wb is first seen. But no insistant on this... Thanks. > > Thanks. >