From: David Hildenbrand <david@redhat.com>
To: Mike Kravetz <mike.kravetz@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev>,
Axel Rasmussen <axelrasmussen@google.com>,
Mina Almasry <almasrymina@google.com>,
Peter Xu <peterx@redhat.com>, Nadav Amit <nadav.amit@gmail.com>,
Rik van Riel <riel@surriel.com>, Vlastimil Babka <vbabka@suse.cz>,
Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Wei Chen <harperchen1110@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v9 2/3] hugetlb: remove duplicate mmu notifications
Date: Mon, 14 Nov 2022 10:06:18 +0100 [thread overview]
Message-ID: <cfb2e9de-3bf8-6380-f336-dc3d7a5ecc29@redhat.com> (raw)
In-Reply-To: <20221111232628.290160-3-mike.kravetz@oracle.com>
On 12.11.22 00:26, Mike Kravetz wrote:
> The common hugetlb unmap routine __unmap_hugepage_range performs mmu
> notification calls. However, in the case where __unmap_hugepage_range
> is called via __unmap_hugepage_range_final, mmu notification calls are
> performed earlier in other calling routines.
>
> Remove mmu notification calls from __unmap_hugepage_range. Add
> notification calls to the only other caller: unmap_hugepage_range.
> unmap_hugepage_range is called for truncation and hole punch, so
> change notification type from UNMAP to CLEAR as this is more appropriate.
>
> Fixes: 90e7e7f5ef3f ("mm: enable MADV_DONTNEED for hugetlb mappings")
> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
> Reported-by: Wei Chen <harperchen1110@gmail.com>
> Cc: <stable@vger.kernel.org>
Why exactly do we care about stable backports here? What's the
user-visible impact?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-11-14 9:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 23:26 [PATCH v9 0/3] fix hugetlb MADV_DONTNEED vma_lock handling Mike Kravetz
2022-11-11 23:26 ` [PATCH v9 1/3] madvise: use zap_page_range_single for madvise dontneed Mike Kravetz
2022-11-14 9:05 ` David Hildenbrand
2022-11-11 23:26 ` [PATCH v9 2/3] hugetlb: remove duplicate mmu notifications Mike Kravetz
2022-11-14 9:06 ` David Hildenbrand [this message]
2022-11-14 19:30 ` Mike Kravetz
2022-11-11 23:26 ` [PATCH v9 3/3] hugetlb: don't delete vma_lock in hugetlb MADV_DONTNEED processing Mike Kravetz
2022-11-12 19:37 ` [PATCH v9 0/3] fix hugetlb MADV_DONTNEED vma_lock handling Nadav Amit
2022-11-14 0:09 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfb2e9de-3bf8-6380-f336-dc3d7a5ecc29@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=axelrasmussen@google.com \
--cc=harperchen1110@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=nadav.amit@gmail.com \
--cc=naoya.horiguchi@linux.dev \
--cc=peterx@redhat.com \
--cc=riel@surriel.com \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox