From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BC98C021A4 for ; Fri, 14 Feb 2025 18:52:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2D1E280009; Fri, 14 Feb 2025 13:52:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ADD71280002; Fri, 14 Feb 2025 13:52:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A4AD280009; Fri, 14 Feb 2025 13:52:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7E1E6280002 for ; Fri, 14 Feb 2025 13:52:00 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0D619C08A7 for ; Fri, 14 Feb 2025 18:52:00 +0000 (UTC) X-FDA: 83119444800.17.1617F3C Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by imf28.hostedemail.com (Postfix) with ESMTP id 1D2B6C0006 for ; Fri, 14 Feb 2025 18:51:56 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=XxWdfxuS; spf=pass (imf28.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.12 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739559118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kBV0RymUgLKkjxZDXQHxQVbSaE5mdwNFRGm7rYDX+ZU=; b=IN2qyS0QVFNpsOqdAZBtEP70T3WFMTqDEgT91jMvIUe4G5QT4r/lykMmoDoi3KATpO3W6P jhf4GCYZbcyBmTovTlCCdN4zpSXzpl4dgs8Jf+yhGb8mEyd3+oCUvVnAP7WzPl6J5SKAr2 VWUnjCCQw/mOovGeDf9xore/QEsjBXI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=XxWdfxuS; spf=pass (imf28.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.12 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739559118; a=rsa-sha256; cv=none; b=P8JQFzNE7RiUB+EgXh4IY74d9mUxtbigMCHFqdpl6QFURVYSQi54eOECYvQIOexqZwL5iw P4TLDbONBnKoJwfIPIo0vSXdLdnA/MTMnx06mqXfRDt1ca9A4R+Tp3Td+Kyvf4T/XF3c07 Vsz/HFjPxBJ+vZngJjdSShqZdxaBTuo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739559117; x=1771095117; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=MaSVqZxrNY9IQD/tdXmpCeFc2YnxxHUucY/tpy+CXss=; b=XxWdfxuSk39/jdXlCA2tTgbjwneqMwkLaFMMzwffeJ8IF0e9QquecX/A ln1Bhwlmlt0wB5zO/pS/vw35kj37BdCISvljMLHnEl/bv0583rBQ2OeZy nZEhQNEARGoxcl+aWnkOxMSHH2UM9i6XYirTcpaF/f0zkDw9NwJMncmmw 47UXPotmbBQIgid3mTu45G849g7vxwPNOhPHUSFl6/x996vHfOMq0NrVr TbnkCs2b/DFfhQ27LxctnxMVHT6nzr+mKGX9kAoeXv7/2PNTTqxlJ20+T i6mgaObrxu9x4V0L7wmZAgzkEQdjppcGtTzroCta/WpDmSFV2ZxmeqYCT w==; X-CSE-ConnectionGUID: dle1GsZdQZm/pQeBTh8FZg== X-CSE-MsgGUID: y3c2P9aySxaS+hRqHyRBYQ== X-IronPort-AV: E=McAfee;i="6700,10204,11345"; a="51721539" X-IronPort-AV: E=Sophos;i="6.13,286,1732608000"; d="scan'208";a="51721539" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2025 10:51:55 -0800 X-CSE-ConnectionGUID: Kw+cwZ9nRNmoQImvv7FKPg== X-CSE-MsgGUID: bjeFwl9ETiCuHsD3QDNMfQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="113401022" Received: from tjmaciei-mobl5.ger.corp.intel.com (HELO [10.125.109.21]) ([10.125.109.21]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2025 10:51:55 -0800 Message-ID: Date: Fri, 14 Feb 2025 10:51:58 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 08/12] x86/mm: use broadcast TLB flushing for page reclaim TLB flushing To: Rik van Riel , x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-9-riel@surriel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250213161423.449435-9-riel@surriel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 6sm88kxtmp1i5wkaq5mb73n69mgntozz X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1D2B6C0006 X-HE-Tag: 1739559116-227616 X-HE-Meta: U2FsdGVkX1/nFKNBAY/B9mBLlsVobBZ3J8OWTHYAig3TZ6OXhrt+RctV6rRPk0iVsRyBPVAJvP30hz8deZ3zFY8/NEJjPX9m75OkAkeq2MB+uP3qoMKINnpiE25zI55Qj4Z734jNnoEWSyRY6nXad8sgWt/2CakEg0O4k7be2sER1O0sTMJQ2l6rtfgoZd8R8BqaQLQM8tfvKqBS0J+L7RfoqDCBBBnzFOssWeKPbwsnsVApHmhpsS/1fl8PHm+yyta95x6WuzCpu5L5Ung18df94ED0UTgA0KdAQnh4jqK62XW4tMDPt2MbJSVlOws1X33PQsjKA5jL6aJi58JBjT0mDWUzRp0uNYXZGsAyZWHRZIErRVWjOwCI3IOKJZ6FUxzWF+hmy1XgvjjSXS0VSE2AOovb0qGKEqCQje+KUydIDOeDD/FKaLb/czvcOMjl69yKHQ1nP4ZICnJmqCVmgTGOMhwy6WZGgq+avjDdBVegD0vUw/te4z/ZHl1K6LWNugC3cEveeg2NZIPsZmwnBvJcTgGFWDK8VLlAsO7XM+88cUIiRgwX+dfWALBQNORxc4WhDgav0InTCF/Iu7b4/5s/lXU6ndB7m0UATF+aKUHVxJqWK9RuIxJ6yimAaazUY4PmYeeMwvO8BiU9eCIzTxBi0EkKVwGH7487OgVLLTY8uhJFw7qLGYRxteU7d354EGyTZYHL0p4wg+FDS0u2kVKskSEXGeoieOunKMjWkuFQMxtPLTdgTU49JivFy5MHilBXbOptMvL3orUB5obs4/Q38f2uOz+yGSD9DxSk8lFllRPhRwJKm0darVKZ8Krql84GqmmaQvJ9nSikbBX/DMuFl07d5ZY9UOF6pdjbqofVtZk3Yy7hgJKUAnx/29yU4cItoqiRjFk5iee7UU4i8c3fiQVK4p8QCI3fhYGM5/1XWrc4rIFlfq1EdCqwlCFILyplS3SMYWiN8MaVrvH Sks35tyg ZOMyFTJu/DksfXpUD3HuYpCiMbdLIdW9eIAQlbO7xrGNClJ5ov/9kgCiEt3kMQzYNmIMEZgif/f9fEPJUw3NwalrR3wYcp1KTACqbTxcKDQBeAsl2k7idaZt01rsqumrlnQ5c29KGd2z8zFn+FsdfFABebvp4PMFKugySmfPjawqSipduoGpZ4f8cVIdPkZLjD04bUATu8/gbKqjs9vpW3aaZaG47fQ7xNvL6GcavJXYoBtAukdQpHj9GW5bpjjbIM/iKjZU+ze+T700AeF2zgGLCBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/13/25 08:13, Rik van Riel wrote: > In the page reclaim code, we only track the CPU(s) where the TLB needs > to be flushed, rather than all the individual mappings that may be getting > invalidated. > > Use broadcast TLB flushing when that is available. The changelog here is a little light. This patch is doing a *ton* of stuff. The existing code has two cases where it is doing a full TLB flush, not a ranged flush. 1. An actual IPI to some CPUs in batch->cpumask 2. A local flush, no IPI The change here eliminates both of those options, even the "common case" which is not sending an IPI at all. So this replaces a CPU-local (aka. 1 logical CPU) TLB flush with a broadcast to the *ENTIRE* system. That's a really really big change to not be noted. It's not something that's an obvious win to me. > diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c > index 3c29ef25dce4..de3f6e4ed16d 100644 > --- a/arch/x86/mm/tlb.c > +++ b/arch/x86/mm/tlb.c > @@ -1316,7 +1316,9 @@ void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch) > * a local TLB flush is needed. Optimize this use-case by calling > * flush_tlb_func_local() directly in this case. > */ > - if (cpumask_any_but(&batch->cpumask, cpu) < nr_cpu_ids) { > + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) { > + invlpgb_flush_all_nonglobals(); > + } else if (cpumask_any_but(&batch->cpumask, cpu) < nr_cpu_ids) { > flush_tlb_multi(&batch->cpumask, info); > } else if (cpumask_test_cpu(cpu, &batch->cpumask)) { > lockdep_assert_irqs_enabled(); The structure of the code is also a bit off to me. O'd kinda prefer that we stick the pattern of (logically): if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) { invlpgb_...(); } else { on_each_cpu*(); } This patch is going a couple of functions up in the call chain above the on_each_cpu()'s. It would be more consistent with the previous modifications in this series if the X86_FEATURE_INVLPGB check was in native_flush_tlb_multi(), instead. Would that make sense here? It would also preserve the "common case" optimization that's in arch_tlbbatch_flush().