From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BB22C433F5 for ; Wed, 6 Oct 2021 12:16:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B736461163 for ; Wed, 6 Oct 2021 12:16:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B736461163 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 2F500940007; Wed, 6 Oct 2021 08:16:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A4EB6B0073; Wed, 6 Oct 2021 08:16:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16C9E940007; Wed, 6 Oct 2021 08:16:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0067.hostedemail.com [216.40.44.67]) by kanga.kvack.org (Postfix) with ESMTP id 0920A6B0071 for ; Wed, 6 Oct 2021 08:16:02 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BB6412D4A1 for ; Wed, 6 Oct 2021 12:16:01 +0000 (UTC) X-FDA: 78665909322.21.2298D66 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 6B1BF9000A8A for ; Wed, 6 Oct 2021 12:16:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633522560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pO4PlWo7HtXIXRFXm7PKxdfb4eUPK7D//T+BQxzSe24=; b=Gdn5U7Kll/BAWroqjv4LUVxCNO27IZPHT8CFB55KkYWNozZ7p11J1TTaLhpvAf5DOgm0KE YeX+pK1BrSYfPJrY5fGQZ+OyjIHpc/aFt7G1F9bXcr8bpERG68Xr8rwlSy/gyh5SFd7ot3 sSyMLG+//zpk4NSZRaEjoytSGO44IF8= Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-256-Nktxyy5cOf2sdRcJ5MWkpA-1; Wed, 06 Oct 2021 08:14:37 -0400 X-MC-Unique: Nktxyy5cOf2sdRcJ5MWkpA-1 Received: by mail-io1-f72.google.com with SMTP id j14-20020a6b310e000000b005db4ba30be6so2006016ioa.0 for ; Wed, 06 Oct 2021 05:14:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=pO4PlWo7HtXIXRFXm7PKxdfb4eUPK7D//T+BQxzSe24=; b=sngU7RPM5h8Xv704/wyMy//FMOqcpeMxEPvNnSEeAb4kkHjvh7iKoNzZduWbBOIACk JeoQMDrQJ0nDx0lj2igr45pNID+lb3ibtIsokwOf3h9L3GlL1f1Ac2M1GmOUrsCColVa nPdzEZqJNi0/XN7WYusgSiasLkYVGjZbd3RR9TdaP1YE+12oAY8yCLGDPG/be1HfNBo/ rK5yoT+D/3eAhHoN13b1VejarcPTlkCx+DQjl6rhVYKWZfNex54OpxG9VdnRHmfhpJ5X asA8rX8+L8/+4xa14mDN08bGNmbV/2LVWXKpwWkPOwybopQWNN0Ohx6f0kq6Z5Q9Qjhy LYvw== X-Gm-Message-State: AOAM533Rai45sHOT/7Heifk4v7i2B9KvjWRaoVh+Cd03cVrFoLJIHvFc /1t8j3P1ncpO72lBGMl220gDLiJF1TLL9XrbU9fGJ0Axrb9P4fKv8lsoie6YLHFLowdZOi8xefZ s+b5Bxpm8Gq8= X-Received: by 2002:a02:998a:: with SMTP id a10mr6959473jal.23.1633522475461; Wed, 06 Oct 2021 05:14:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUzM5RufE+kX+JI2YU2VehZCyjN0dYG5quERcJmLyHP4rvBAFs45Zc48/UnZnKXY676Eimsw== X-Received: by 2002:a02:998a:: with SMTP id a10mr6959444jal.23.1633522475012; Wed, 06 Oct 2021 05:14:35 -0700 (PDT) Received: from [172.16.0.19] ([172.87.10.244]) by smtp.gmail.com with ESMTPSA id a5sm13238251ilf.27.2021.10.06.05.14.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Oct 2021 05:14:34 -0700 (PDT) Message-ID: Date: Wed, 6 Oct 2021 07:14:33 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: WARNING in __set_page_dirty To: Hao Sun , agruenba@redhat.com, cluster-devel@redhat.com, Linux Kernel Mailing List , akpm@linux-foundation.org, Linux MM References: From: Bob Peterson In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6B1BF9000A8A X-Stat-Signature: hz6e1zs3qwg8i1h8sr5kzfqbfqesjcbp Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Gdn5U7Kl; spf=none (imf23.hostedemail.com: domain of rpeterso@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=rpeterso@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1633522561-281040 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/6/21 3:50 AM, Hao Sun wrote: > Hello, > > When using Healer to fuzz the latest Linux kernel, the following crash > was triggered. > > HEAD commit: 0513e464f900 Merge tag 'perf-tools-fixes-for-v5.15-2021-09-27' > git tree: upstream > console output: > https://drive.google.com/file/d/1Tqtv5Qcx5LDPwnv7b2uJS2bilqpGfipG/view?usp=sharing > kernel config: https://drive.google.com/file/d/1Jqhc4DpCVE8X7d-XBdQnrMoQzifTG5ho/view?usp=sharing > > If you fix this issue, please add the following tag to the commit: > Reported-by: Hao Sun > > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 19902 at ./include/linux/backing-dev.h:286 > inode_to_wb include/linux/backing-dev.h:283 [inline] > WARNING: CPU: 0 PID: 19902 at ./include/linux/backing-dev.h:286 > account_page_dirtied mm/page-writeback.c:2452 [inline] > WARNING: CPU: 0 PID: 19902 at ./include/linux/backing-dev.h:286 > __set_page_dirty+0x50b/0x6e0 mm/page-writeback.c:2500 > Modules linked in: > CPU: 0 PID: 19902 Comm: syz-executor Not tainted 5.15.0-rc3+ #21 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS > rel-1.12.0-59-gc9ba5276e321-prebuilt.qemu.org 04/01/2014 > RIP: 0010:inode_to_wb include/linux/backing-dev.h:283 [inline] > RIP: 0010:account_page_dirtied mm/page-writeback.c:2452 [inline] > RIP: 0010:__set_page_dirty+0x50b/0x6e0 mm/page-writeback.c:2500 > Code: fc ff ff e8 d7 0a f1 ff 49 8b 87 a8 01 00 00 be ff ff ff ff 48 > 8d 78 70 e8 a2 42 de 02 85 c0 0f 85 18 fc ff ff e8 b5 0a f1 ff <0f> 0b > e9 0c fc ff ff e8 a9 0a f1 ff 48 89 ef e8 f1 ea d8 00 48 8b > RSP: 0018:ffffc90003e7bd08 EFLAGS: 00010093 > RAX: 0000000000000000 RBX: ffffea000083a140 RCX: 0000000000000000 > RDX: ffff88810e1b8000 RSI: ffffffff814686ab RDI: ffffffff853ccbb6 > RBP: ffff88800ce0bec8 R08: 0000000000000001 R09: 0000000000000000 > R10: ffffc90003e7bbb8 R11: 0000000000000003 R12: ffff8881100ecc98 > R13: ffff8881045ac000 R14: 0000000000000293 R15: ffff88800ce0bec8 > FS: 00007f72d08c8700(0000) GS:ffff88807dc00000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000000000000003 CR3: 000000001a0a6000 CR4: 0000000000750ef0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000600 > PKRU: 55555554 > Call Trace: > mark_buffer_dirty+0x1d4/0x2b0 fs/buffer.c:1108 > gfs2_unpin+0x74/0x460 fs/gfs2/lops.c:111 > buf_lo_after_commit+0x6b/0x80 fs/gfs2/lops.c:750 > lops_after_commit fs/gfs2/lops.h:49 [inline] > gfs2_log_flush+0x9ba/0x1050 fs/gfs2/log.c:1108 > gfs2_sync_fs+0x3c/0x50 fs/gfs2/super.c:644 > sync_fs_one_sb+0x40/0x50 fs/sync.c:81 > iterate_supers+0xa7/0x130 fs/super.c:695 > ksys_sync+0x60/0xc0 fs/sync.c:116 > __do_sys_sync+0xa/0x10 fs/sync.c:125 > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > do_syscall_64+0x34/0xb0 arch/x86/entry/common.c:80 > entry_SYSCALL_64_after_hwframe+0x44/0xae > RIP: 0033:0x200008ca > Code: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 00 00 00 00 00 00 00 00 00 00 00 98 4a 2a e9 2c b8 b6 4c 0f 05 00 > 00 40 00 c4 a3 7b f0 c5 01 41 e2 e9 c4 22 e9 aa bb 3c 00 00 > RSP: 002b:00007f72d08c7ba8 EFLAGS: 00000a83 ORIG_RAX: 00000000000000a2 > RAX: ffffffffffffffda RBX: 0000000000000009 RCX: 00000000200008ca > RDX: 0000000000004c01 RSI: 0000000000000003 RDI: 0000000000400000 > RBP: 00000000000000eb R08: 0000000000000005 R09: 0000000000000006 > R10: 0000000000000007 R11: 0000000000000a83 R12: 000000000000000b > R13: 000000000000000c R14: 000000000000000d R15: 00007ffe4f7c7800 > Hi, This is a long-standing problem we've known about for years, and there has been a long-standing discussion about it. I've made some attempts to fix it, but none have been satisfactory. Some people in the upstream community insist there should be a 1:1 correspondence between inodes and address spaces (which is the root of the problem), but there seems to be no documentation to back that up. What we do know well is this scenario, which does indeed make that assumption. While we ponder the problem, it seems to cause no harm unless you have lockdep set, so it's never been our highest priority to fix. Regards, Bob Peterson GFS2 File System