linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Byungchul Park <byungchul.park@lge.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: peterz@infradead.org, mingo@kernel.org,
	akpm@linux-foundation.org, tglx@linutronix.de,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-block@vger.kernel.org, kernel-team@lge.com, jack@suse.cz,
	jlayton@redhat.com, viro@zeniv.linux.org.uk, hannes@cmpxchg.org,
	npiggin@gmail.com, rgoldwyn@suse.com, vbabka@suse.cz,
	pombredanne@nexb.com, vinmenon@codeaurora.org,
	gregkh@linuxfoundation.org
Subject: Re: [PATCH 1/3] lockdep: Apply crossrelease to PG_locked locks
Date: Thu, 16 Nov 2017 21:48:05 +0900	[thread overview]
Message-ID: <cf8aa555-7435-ea00-a4ee-3dcfd33ab5a0@lge.com> (raw)
In-Reply-To: <20171116120216.nxbwkj5y3kvim6cj@dhcp22.suse.cz>

On 11/16/2017 9:02 PM, Michal Hocko wrote:
> for each struct page. So you are doubling the size. Who is going to
> enable this config option? You are moving this to page_ext in a later
> patch which is a good step but it doesn't go far enough because this
> still consumes those resources. Is there any problem to make this
> kernel command line controllable? Something we do for page_owner for
> example?

Sure. I will add it.

> Also it would be really great if you could give us some measures about
> the runtime overhead. I do not expect it to be very large but this is

The major overhead would come from the amount of additional memory
consumption for 'lockdep_map's.

Do you want me to measure the overhead by the additional memory
consumption?

Or do you expect another overhead?

Could you tell me what kind of result you want to get?

> something people are usually interested in when enabling debugging
> features.

-- 
Thanks,
Byungchul

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-11-16 12:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-16  3:14 [PATCH 0/3] lockdep/crossrelease: Apply crossrelease to page locks Byungchul Park
2017-11-16  3:14 ` [PATCH 1/3] lockdep: Apply crossrelease to PG_locked locks Byungchul Park
2017-11-16 12:02   ` Michal Hocko
2017-11-16 12:48     ` Byungchul Park [this message]
2017-11-16 13:07       ` Michal Hocko
2017-11-24  3:02         ` Byungchul Park
2017-11-24  8:11           ` Michal Hocko
2017-11-24  9:38             ` Jan Kara
2017-11-16  3:14 ` [PATCH 2/3] lockdep: Apply lock_acquire(release) on __Set(__Clear)PageLocked Byungchul Park
2017-11-16  3:14 ` [PATCH 3/3] lockdep: Move data of CONFIG_LOCKDEP_PAGELOCK from page to page_ext Byungchul Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf8aa555-7435-ea00-a4ee-3dcfd33ab5a0@lge.com \
    --to=byungchul.park@lge.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=jack@suse.cz \
    --cc=jlayton@redhat.com \
    --cc=kernel-team@lge.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mingo@kernel.org \
    --cc=npiggin@gmail.com \
    --cc=peterz@infradead.org \
    --cc=pombredanne@nexb.com \
    --cc=rgoldwyn@suse.com \
    --cc=tglx@linutronix.de \
    --cc=vbabka@suse.cz \
    --cc=vinmenon@codeaurora.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox