From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AFE7C43215 for ; Tue, 26 Nov 2019 09:42:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 538702073F for ; Tue, 26 Nov 2019 09:42:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 538702073F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DCCBD6B02D1; Tue, 26 Nov 2019 04:42:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D7D186B02D2; Tue, 26 Nov 2019 04:42:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C92836B02D3; Tue, 26 Nov 2019 04:42:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id B1AF26B02D1 for ; Tue, 26 Nov 2019 04:42:40 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 6DC918249980 for ; Tue, 26 Nov 2019 09:42:40 +0000 (UTC) X-FDA: 76197938880.24.word09_345e80ccd3e40 X-HE-Tag: word09_345e80ccd3e40 X-Filterd-Recvd-Size: 3408 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 Nov 2019 09:42:39 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 00A3C30E; Tue, 26 Nov 2019 01:42:38 -0800 (PST) Received: from [10.163.1.41] (unknown [10.163.1.41]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CDA173F52E; Tue, 26 Nov 2019 01:42:35 -0800 (PST) Subject: Re: [PATCH] mm: fix comments related to node reclaim To: Hao Lee , akpm@linux-foundation.org Cc: mgorman@techsingularity.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20191125142018.GA21373@haolee.github.io> From: Anshuman Khandual Message-ID: Date: Tue, 26 Nov 2019 15:13:22 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191125142018.GA21373@haolee.github.io> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/25/2019 07:50 PM, Hao Lee wrote: > As zone reclaim has been replaced by node reclaim, this patch fixes related > comments. > > Signed-off-by: Hao Lee > --- > include/linux/mmzone.h | 2 +- > include/uapi/linux/capability.h | 2 +- > include/uapi/linux/sysctl.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 9e47289a4511..7e3208f4f5bc 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -747,7 +747,7 @@ typedef struct pglist_data { > > #ifdef CONFIG_NUMA > /* > - * zone reclaim becomes active if more unmapped pages exist. > + * node reclaim becomes active if more unmapped pages exist. > */ > unsigned long min_unmapped_pages; > unsigned long min_slab_pages; > diff --git a/include/uapi/linux/capability.h b/include/uapi/linux/capability.h > index 240fdb9a60f6..dd6772f16eec 100644 > --- a/include/uapi/linux/capability.h > +++ b/include/uapi/linux/capability.h > @@ -273,7 +273,7 @@ struct vfs_ns_cap_data { > /* Allow enabling/disabling tagged queuing on SCSI controllers and sending > arbitrary SCSI commands */ > /* Allow setting encryption key on loopback filesystem */ > -/* Allow setting zone reclaim policy */ > +/* Allow setting node reclaim policy */ Does this point to the capability for accessing vm.zone_reclaim_mode = 0 sysctl knob ? In that case we should not be changing the name here as the interface still retains the original name 'zone_reclaim_mode'. > > #define CAP_SYS_ADMIN 21 > > diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h > index 87aa2a6d9125..27c1ed2822e6 100644 > --- a/include/uapi/linux/sysctl.h > +++ b/include/uapi/linux/sysctl.h > @@ -195,7 +195,7 @@ enum > VM_MIN_UNMAPPED=32, /* Set min percent of unmapped pages */ > VM_PANIC_ON_OOM=33, /* panic at out-of-memory */ > VM_VDSO_ENABLED=34, /* map VDSO into new processes? */ > - VM_MIN_SLAB=35, /* Percent pages ignored by zone reclaim */ > + VM_MIN_SLAB=35, /* Percent pages ignored by node reclaim */ > }; > > >