From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E586C3DA64 for ; Thu, 1 Aug 2024 09:28:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC3FF6B0089; Thu, 1 Aug 2024 05:28:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4D046B008A; Thu, 1 Aug 2024 05:28:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89F466B008C; Thu, 1 Aug 2024 05:28:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 674F56B0089 for ; Thu, 1 Aug 2024 05:28:53 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1A5FC1C2250 for ; Thu, 1 Aug 2024 09:28:53 +0000 (UTC) X-FDA: 82403152146.08.C31A2FA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id D3E6C20013 for ; Thu, 1 Aug 2024 09:28:50 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="FUExsWF/"; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722504475; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zHpp359X9k0N0Pwsm/JB02XcbstIh3/H6VLDG6eFvUw=; b=TppC5UU5lyIomlqA2LevDwfIDM3fS5pNQrtufpuoHBfaclhN0OQ86D3gUFLGAN3HU6xXJZ v7plKrFGaZKzPbIU9NUFUyzlzPHeKzJHbn++XZ8Hq7KKxmrYrbohUBn3K5WDtAU8z+8rs9 GRHX9hY/qW1BnKM44p4bJYLUlLxZZzk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722504475; a=rsa-sha256; cv=none; b=S/HxwJznr/3IdH9srT6I5fmvwpeciXOHL9Xd8HJZiXxG2LkLkOFaXcbjgMZflylXpDNF7E lva39ZSY5qYkyc0LMHVgmEIuKJrmRMgXw8R+5TS3BcE7r0+plFVWak6Z3e6dY2RI7AV/G5 cY1suIX0g0KVIzo6AhEMCsjqorBTUsQ= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="FUExsWF/"; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722504529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zHpp359X9k0N0Pwsm/JB02XcbstIh3/H6VLDG6eFvUw=; b=FUExsWF/Lv04WCAkkhc2Dh+UXwsogRvonDBwIdBSz0O7WnHisOlI8AaqIbin7vbdjriWGn BYdqK2WmCseQvPkYb+yGaWYAwd0fo5SlJoCaUf+tr7wazHJH7Zr5KWF9+eWJoL/p7LLqem qLxLiWSWAw3uqXagoxlj1kiXNfqIiA8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-209-nPvPNNOTNwiM4od-u2qSnQ-1; Thu, 01 Aug 2024 05:28:48 -0400 X-MC-Unique: nPvPNNOTNwiM4od-u2qSnQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42816096cb8so59855035e9.0 for ; Thu, 01 Aug 2024 02:28:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722504527; x=1723109327; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zHpp359X9k0N0Pwsm/JB02XcbstIh3/H6VLDG6eFvUw=; b=LI+jqOqRlbkOIYZjNV647WZEuWQKkaxzCYsHq630ZBbHXZjMc0BG1XPV62zlZDRQze jy2dbq2cK/acW6u7m2mdeS8FoVjb5tAv4y3N/sOhPskzpM6Thz/D/39vbdHKjFJIfYAz 3Nd1WhajTyw7cBgWNavzodcvtu6xGj0XLcXY38nKbIzvwP+YIMG7ypxuBsdWSmF9sroc qj8zjRISAN1PZ4lwCaY4aL8lFVcLGVtB0cvlb56iRZaAH1khoHep3ayeJAEIuydZjarE mGTA+XseJHiek5snAAB7gLkSj2w0oDwShqvTHz2+APDUwdKEBzuEGBAp6jOG+0Q5z9ad VsKg== X-Gm-Message-State: AOJu0YwfqNdUsKwJ1H07+8ORwPGOY3k5QFdemyzCvINnsX4DND8GM8Cx sgV3WbsGYnIFZn+r2EyGgqCiwVaKjApHo1EQm7bHanpOCCGLWjfBhSrF23Dgl1aTiJOP8aIJI0I xnPITZYwZwZs22Bnj5U+mrlyRE6hnSUhugNd2GQ6/DR8FQ0j0 X-Received: by 2002:a05:600c:1552:b0:426:690d:d5b7 with SMTP id 5b1f17b1804b1-428b8a1b1cemr18663255e9.25.1722504527069; Thu, 01 Aug 2024 02:28:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEpSauY45TG3d6gUSUvXBj9ZIpLCRWrjG1X1kDugKeupuCGkfRbZ13T7CuZwXK/ZlTtxir94Q== X-Received: by 2002:a05:600c:1552:b0:426:690d:d5b7 with SMTP id 5b1f17b1804b1-428b8a1b1cemr18662975e9.25.1722504526513; Thu, 01 Aug 2024 02:28:46 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:5c00:e650:bcd7:e2a0:54fe? (p200300cbc7075c00e650bcd7e2a054fe.dip0.t-ipconnect.de. [2003:cb:c707:5c00:e650:bcd7:e2a0:54fe]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4282b8a251dsm50341745e9.10.2024.08.01.02.28.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Aug 2024 02:28:46 -0700 (PDT) Message-ID: Date: Thu, 1 Aug 2024 11:28:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/cma: Change the addition of totalcma_pages in the cma_init_reserved_mem To: Hao Ge , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hao Ge References: <20240729080431.70916-1-hao.ge@linux.dev> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240729080431.70916-1-hao.ge@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D3E6C20013 X-Stat-Signature: jhxdy17b7a4prgxcgaeb9egf4m4hqh8y X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1722504530-272675 X-HE-Meta: U2FsdGVkX19JGK+vGL8aLcsHOUfTkszGZUgvFr3bJTWJV3VJqQgUvlrz4js1X3nwCqXC94vDkPzMBZTgSYs4uiSKOoK9WXpECzMb7YCnvfr0NUOPLoyMn0RH+9uBvYDD/2qw2nfop3HqQ9LQDAgRQ4hu4BPOwPqS7oyUl0DSZjRevXIXA1Ce7g1+aQiH77TbhdFVZHnERIhb+TkWNLc9sLEZW3Yw0ovec1oAGj1ezko3aABEiQTA44vdLz7yjigj2iFg77UixtA+PHojdjG8z6Wl2K5gdrGAqDBbP08/HD3mkdP3ofGHZ7LkBmtu9uoF++qtFGT786ODdbjRMiz0K+dokYzgv2+y1Mww7HlLOA/Yu7JhCafKyIr10g60LfrXYuh2/z3Sd7V99CEI6FJlRuxsAsvueBLTtP0draKLlXAt6kL+Mp7LYZr2a5/8Fk5SseL/Dl7mcGcLyfFficvaeUX9dgXoe15zuT6YXllrmrfX5i+HwqzViVNvgeigF5CpZpRWe5kHSkmZR6gSyZqYfEHI0UclmktXYb7R+WfYBzQt5JWpctWBfeojZKhncUqqdDzZKhu6nyvViyr9iot9JhfUu7eFFQY0MR/vfoXVOOFu9jtF+rsqLoZuYS9zSVJ3DKGbHcUSfxEqgGMb+2fQhamOowPi/JM6idppif7Y2Cynuvrlbm1SqThOwZK/MgOgU+wvZon3hTBoqlrZ1I5s+fXJFCRYVm36u4ZU8YBlvSG1y4T8QMg7VzGvFqxawRdsoVHeEImszVl2aWNIoDg8RQv+mkUiDveUZlk7azI4Lnzrp5EVctEqY5ahHq0zvSetv7G8FFu/Kzt8Wvhe5lcSS99xj9WBTrHET+3wfaG9cu9/qVc0J4ztr+Y7A2KVuTUtxxKrne8pbtPThY2vM40z68wL+JZOwCYoT0lr3fhLEMZtT68ZSa1jYCV9HtLsCQX1F6id1lz+6YpLcJA3ft0 mfTD4qb4 XrqBd/F3MxrfGr1WvQJ3eXD6GsxRHDY8MhaRfc3tz78PLe1r70c7NoddqTo32l7Pvj0f48VVbwWoA9xKTbmHeHZjDgu1Z2g4lE5/vlbbV6mqswi+3++jnE9uIrg7AFOfcv4uIa9uqD35Mm2pEEPAEYzalvGre6bq/XgXDRESe9hqUD3yhOOkkWAL3TpRxu/1l1d6hXm0sJ6nOhb92CSHxRPeCOQE0X4REKZFjtHQ3ezvAO4DAUZHxbVFoGM11Fpna6ggILfyt9PO96NMvuuv3uAIabX+am9diPoFtXQviLm1S6QXgTeV4uFQo+jt1pfch2vON+NyzjEMDyHdjlB9J2ixG59xhErsrvfGzIgS3rlmMAfSUg/6TEjI+d+Dz3QxHrYcv+rqqNSAGuEtw9Cu0jtBFGEmBlyvRgKT7q8suH4vhtF7g8hXvANf5KQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.07.24 10:04, Hao Ge wrote: > From: Hao Ge > > Replace the unnecessary division calculation with cma->count > when update the value of totalcma_pages. > > Signed-off-by: Hao Ge > --- > mm/cma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/cma.c b/mm/cma.c > index 3e9724716bad..95d6950e177b 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -202,7 +202,7 @@ int __init cma_init_reserved_mem(phys_addr_t base, phys_addr_t size, > cma->order_per_bit = order_per_bit; > *res_cma = cma; > cma_area_count++; > - totalcma_pages += (size / PAGE_SIZE); > + totalcma_pages += cma->count; > > return 0; > } Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb