From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 055C0CF649A for ; Sat, 28 Sep 2024 05:40:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51D9A6B0185; Sat, 28 Sep 2024 01:40:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A6B36B018C; Sat, 28 Sep 2024 01:40:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 394A16B018D; Sat, 28 Sep 2024 01:40:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1C2216B0185 for ; Sat, 28 Sep 2024 01:40:22 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 69434803C6 for ; Sat, 28 Sep 2024 05:40:21 +0000 (UTC) X-FDA: 82613046642.19.A92A665 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) by imf01.hostedemail.com (Postfix) with ESMTP id 938594000C for ; Sat, 28 Sep 2024 05:40:17 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=KW9y1xCc; spf=pass (imf01.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727501896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3G6MJxlUtYVBaUZll/5jjDyeLSE35bLoeWF0+hX/w2o=; b=R7t1SsKocQbu1GvYxAGB2oS4d83YZhZxnO8SoahJwyH/uUoO2Xj86KljpYlXbPMLjma3pJ servccsKHBm7XsqoS/7QWQHRtZFj3K5gJkB0Jqc9ExbEFF01ncFPag6zRPBzG4UHgrcI2f Gg1TBIUHTsa91rgQs5vzzaNKOAy9HAU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727501896; a=rsa-sha256; cv=none; b=8dYz8Ayk+YXHLVOiIC+UW0j50ZRrd/mMwppvyFunvXNueTAjFlHzGDmn4nVpiEKCauw5sb m+W1eILJQiruLkhpI1djKiiM4dGc6dvMPYsDtf+deS8CzaeHIydmbOVBr3ELLTLeFKgQKR zyp2TWx44UFis+P3kun4jEkHkSQWAxA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=KW9y1xCc; spf=pass (imf01.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1727502013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3G6MJxlUtYVBaUZll/5jjDyeLSE35bLoeWF0+hX/w2o=; b=KW9y1xCcJ78BdGBjKE6FR7lMoPqpgFcEXj3f3fGUzsqovH6hTILiU+KRS2u6cw5wPZSTd8 2wK0ByWIKdhUQMRiSWV3zyTUy5b+ilcEPb65q95Gj4MRbyH1jIwJG+ZFsCFwGp0/HMUi/4 JJiY+f6t/4xiVFGC3mIzWrGl6ise+mg= Date: Sat, 28 Sep 2024 13:39:51 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v8 1/8] mm: Define obj_cgroup_get() if CONFIG_MEMCG is not defined. To: Kanchana P Sridhar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, usamaarif642@gmail.com, shakeel.butt@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org Cc: nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com References: <20240928021620.8369-1-kanchana.p.sridhar@intel.com> <20240928021620.8369-2-kanchana.p.sridhar@intel.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20240928021620.8369-2-kanchana.p.sridhar@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 938594000C X-Stat-Signature: rwztw76cmwo8opeemcp4jyyxxhpc1s6g X-HE-Tag: 1727502017-126204 X-HE-Meta: U2FsdGVkX1/9TKrseukJgqIwwDRx/mSOcQjl4yCcIbdSJj78+W4KmlmlnSIEvO4F9eAP02siD06hVzmm+/IJEzhP94OlvrCZYiKIqpAlr5Q367Iriw52t+rR5a2Wn4vOnw6pKuq2nBev4UBi4djxel/k7zAgoxz1nDFY6d6WWMKxXobQshjBdx756MH0g7Zt8jd/6FqZt4K+kyrwx7JxJWwKtlsvKfo5+JmgNq8+9kBfVRBd1iH43Za4Ai869Z/bmX/k5t4mj3KSUStsAufEdAq/r6rbhgkvSN3rsZBCbow3Koi6Bot//Nm20+d0JPwBv9dZs40uWnYT/GfvrNVEGZkzhJUSfvFkgjycnYimq3L2TWkKFYpByhWSj0iKKtS56vf4ZUFXSpX4iH98iIq+f2dmMeK+aUhE2rLmAYihGZU0eMyukCB8EZDUelTZhO+FUnG9hgcR8nuGjFc2/am1916kH8H8wkPANoo5HSvQgjbwA+UtNv3n7HSvoEcFl+w/fE+F5NOXwQxkfq6dJl/6KtylK19qpDcpQZhfJketPUz1nV5ttSSqdO0NERspRcivITlkgqNrE1DBnstz0rUYUfHudf4L4/qAmKrqDXUvi9PiL8VPFpVfng1SGdWj48pU9X84xQgbMDBsjEe9HcIm6UfzkbZAkQEXQTSCAyrsZ5+q5UJHOxS+83xFbB84wAvQYs4mFQ5CbmP0OEXGn8fcy+yI02NW5d0T64gRjDtcIfBwEaqUkIORyawuLlfCHXS2sXyJPQNXR40vikzmurvqS/wSNmT964RIKalZkHvfdowRvos5fb213jMlh0hhxkr6Z9RIPEMghLe8lHjiydS+26T5BHWj7gF+15ODIlbxAaZ3AWIllkdraUJpF78M3gR7Ut6NrVmBWkN9dQ/oIwiqWEqvn7H7/CRVtAg28A0REXaf/nju6ZF8bxdl5KT6wAn2ycebQ0ieRG8Ixir/qD9 Z3NGmTXz ryr7EVoFxnGGF3wFNkt41e0FRg3pNJE8guNPqWP7+vbwMj9212Oe7QYfKuNJ3pkZB4n6ZNCIR9AiHPYPfwihThR8nY+1rlpJQuxrL9Fsex3rESBYC5cpy5+4Q+GFJAQ6cXFgiQN8O8lAAbp8h2FperO1DJnD4KKicbaD65UvH0ccib2NwdOfQZyYpE1jfPz98zxd1PZ/RzqxMv/oHx2CtlICnP0b3RVshMEThNyI3GP8aIkMsgL/cbbhUxw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/9/28 10:16, Kanchana P Sridhar wrote: > This resolves an issue with obj_cgroup_get() not being defined if > CONFIG_MEMCG is not defined. > > Before this patch, we would see build errors if obj_cgroup_get() is > called from code that is agnostic of CONFIG_MEMCG. > > The zswap_store() changes for large folios in subsequent commits will > require the use of obj_cgroup_get() in zswap code that falls into this > category. > > Signed-off-by: Kanchana P Sridhar > Reviewed-by: Nhat Pham Reviewed-by: Chengming Zhou > --- > include/linux/memcontrol.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 34d2da05f2f1..15c2716f9aa3 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -1282,6 +1282,10 @@ struct mem_cgroup *mem_cgroup_from_css(struct cgroup_subsys_state *css) > return NULL; > } > > +static inline void obj_cgroup_get(struct obj_cgroup *objcg) > +{ > +} > + > static inline void obj_cgroup_put(struct obj_cgroup *objcg) > { > }