From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2438EC77B7A for ; Tue, 13 Jun 2023 08:16:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 803AF8E0003; Tue, 13 Jun 2023 04:16:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B3128E0002; Tue, 13 Jun 2023 04:16:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A1F58E0003; Tue, 13 Jun 2023 04:16:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5A8F18E0002 for ; Tue, 13 Jun 2023 04:16:23 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 109C0120434 for ; Tue, 13 Jun 2023 08:16:23 +0000 (UTC) X-FDA: 80897017446.18.A14A9FB Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf01.hostedemail.com (Postfix) with ESMTP id 15C8B40003 for ; Tue, 13 Jun 2023 08:16:20 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=hO7vn83i; spf=pass (imf01.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686644181; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6TAJg6eHsmjSOvv6+q3DUn7ukvlGnJfAy3fxeLTBdwI=; b=bhd83bH7ivMPyOgZRWsx6Gz0DGtN9bhGujW9xRjla0XG5ozQ0C9KCi8cDsIb0dRtaZ8xQq VFosYbRJHDlgvD6p3D3G/w0XT/T3v/cwySofpm8Go1oe3k55AMilY2NNu5AbaP0LQ50+jo hAeJQHt1s3VbfIBlZJMbPqMDOm59bhw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686644181; a=rsa-sha256; cv=none; b=Kntwqtt2DhxtBv2ZVZtAY8HZpnrWMpogoh+UY793M4Z48RWE61zEF0Km/eUZFIHY1IaxWl 5ULOpDYMGOVZMMRerJbnR9DYUI8BWRSliJNebZH3pVvRZC7cbWgoGVdwM0F9OA7QUSeWsC Rb7UW5Jau0M9ID+Imv/ewUsdIeTjT4E= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=hO7vn83i; spf=pass (imf01.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com Received: from [192.168.10.54] (unknown [119.155.33.163]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 1ABF86606ED2; Tue, 13 Jun 2023 09:16:16 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1686644179; bh=23nB+nTv3KCcOlVRmQT97LpYYVvrc8jbpP9qb6C81us=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=hO7vn83iGsoPMQ+DTS+RAHvOkpTsmthC2Fn31D1IGPll3ujIv2OV3ql9BpdJ9se3J c2JoYUPtlplbg6zGgNkSckcSca3gJcYH4nkTBOYB24ztZW2fm9/sisbUaZ4UXXM3Ow DIr4yW7vRnLJyYPZbKNnb7Kj8cYFEaAqj5KjluL3t6oOv/LOi36zcaqp4fwY5bTMK0 EfPxd54u8W0lVHPsoGSXJsuRqU1pUhRQQcb7svcuU3Bf2GAFdRzLWZD3TbSRxCVekB jF3u4UxoHawFeKq3O+J9K8Jnk7gSJXUXTgVBskfxnJLIj44g0Mr7luT0BkaFUMJiqN /5fb555dPbQEg== Message-ID: Date: Tue, 13 Jun 2023 13:16:12 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Cc: Muhammad Usama Anjum , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, jhubbard@nvidia.com Subject: Re: [PATCH] selftests: lib.mk: fix out-of-tree builds Content-Language: en-US To: Anders Roxell , shuah@kernel.org, Andrew Morton , "open list : MEMORY MANAGEMENT" , John Hubbard References: <20230613074931.666966-1-anders.roxell@linaro.org> From: Muhammad Usama Anjum In-Reply-To: <20230613074931.666966-1-anders.roxell@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 15C8B40003 X-Rspam-User: X-Stat-Signature: 3i37f44343i3urupou9tdnocp8k8xtyr X-Rspamd-Server: rspam03 X-HE-Tag: 1686644180-548818 X-HE-Meta: U2FsdGVkX18Z53EgDO9XO5978bfUfVCBHnmj+SS09/TBT1qz6HyOCzjY2RGpI3J6BmK5BEcAH32w+FXjpdArMHaDaQb8tCdby4BzW3lpcrCJH8MQrCDTCxB26dvcOVFXM1ZWxvwIwQsK7p5tTzo97m5k7+rqUINjajCNQ/HGrAk0l6TCEJ4OXaJKvr65iKv+MBMin0UqWrSKugD4AXwxwPzM/3Uv/DmRy3RxWA8iPfSHYavTZ+1AQIxizJIug2QfyvMbhp3Q6YT988WBpwIfYPTXwIboPTcI3qEDapiSK968SngjUIaqtE/wq3Y9PfOjIZisHnLoK5rVLEIcNMs0EmdTxvDOTNuwjwcEHWjcsRqzgB965arM0bEufwRZmZ6fwt8W29MIV/HdGL9VQpNwykHfW4jCONv8iCDI4S9CST88NRBmRpqJ5H2yMgAn6S5nftw1WKlR3kX45/cnU1N15RJdYNHv0m6q6FedEOkqU9TMRtgt3cTDo0aYF/jbMPrtfvmePSG10+vg469beOsYyD8+1wylxOYgq5/LZANW27tYVazyyZauvepICwKzYUpxdOv3KoytVau7hxGL+zuEY7nboBsHMdYd8VzGu5rqeGz2fzZw7pXecXhS5NZVZiHmb0oyFPrWY3c1HBtJeO+Edh6+15ssmYE5pDMbJkCRDZlEkqhMWqMZhFjPzBOufjaKjHq41CLbbxglq5n/HTct+C6XQDjEd5XtH646/XSbabd715bUvq526iPYGA/GBVu9h4s9UitBgai7SATOuOsgqsfY5cr6DKdsGJN35JvC3mz40q4U6QeFCZ/y885sij1EhfpNI66KNAQDGOSZHyma695hxnS2zPPSr41ZspM2fIg8eGAn0PV2eKAhsUKNXtz3Djn4oMw5kQmxisaziLRtp02qlc0ZtdW5Lz6VJD+lesnWC8QtDBkqv6CoVnO/mAu48chQnH1HEq9CU1O2N3M yDgF+dc5 nLaARnGrRS6XzTPUVU/vG90rugmquZ7I6p8hkkifTrn6yiE3J6VqFUpdsQltMOObGJZcxL/D9iVKGtcZdgOlWPlsaHeW84S83izmmg3CPmhxcVUfiCKmDzGkpx4lKGBVtdGK/nvk0srYcXO+iq+ypvH6FfzyInuA7RAKD3FJuzyURCt7Z+5GTZQ2bPH1xIeo4KQTK7RQqJaG0ac4gUCguvFmO7GJyBCqg5hgwnuwOm7aTCagUJ/hmr2fAL2g8T7OuRiB3K7zUH7KYVuoQPdSsT5RMZBgw5xBeoWdrPUmtOpGveGhSADr6YqWWP9SH3NS0SiwB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This patch needs to go through mm tree as the commit which it fixes is in mm. On 6/13/23 12:49 PM, Anders Roxell wrote: > Since commit ("selftests: error out if kernel header files are not yet > built") got merged, the kselftest build correctly because the > KBUILD_OUTPUT isn't set when building out-of-tree and specifying 'O=' > This is the error message that pops up. > > make --silent --keep-going --jobs=32 O=/home/anders/.cache/tuxmake/builds/1482/build INSTALL_PATH=/home/anders/.cache/tuxmake/builds/1482/build/kselftest_install ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- V=1 CROSS_COMPILE_COMPAT=arm-linux-gnueabihf- kselftest-install > make[3]: Entering directory '/home/anders/src/kernel/next/tools/testing/selftests/alsa' > > -e error: missing kernel header files. > Please run this and try again: > > cd /home/anders/src/kernel/next/tools/testing/selftests/../../.. > make headers > > make[3]: Leaving directory '/home/anders/src/kernel/next/tools/testing/selftests/alsa' > make[3]: *** [../lib.mk:77: kernel_header_files] Error 1 > > Fixing the issue by assigning KBUILD_OUTPUT the same way how its done in > kselftest's Makefile. By adding 'KBUILD_OUTPUT := $(O)' 'if $(origin O)' > is set to 'command line'. This will set the the BUILD dir to > KBUILD_OUTPUT/kselftest when doing out-of-tree builds which makes them > in its own separete output directory. > > Signed-off-by: Anders Roxell Please add fixes tag. ("selftests: error out if kernel header files are not yet built") Tested-by: Muhammad Usama Anjum > --- > tools/testing/selftests/lib.mk | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk > index b8ea03b9a015..d17854285f2b 100644 > --- a/tools/testing/selftests/lib.mk > +++ b/tools/testing/selftests/lib.mk > @@ -44,6 +44,10 @@ endif > selfdir = $(realpath $(dir $(filter %/lib.mk,$(MAKEFILE_LIST)))) > top_srcdir = $(selfdir)/../../.. > > +ifeq ("$(origin O)", "command line") > + KBUILD_OUTPUT := $(O) > +endif > + > ifneq ($(KBUILD_OUTPUT),) > # Make's built-in functions such as $(abspath ...), $(realpath ...) cannot > # expand a shell special character '~'. We use a somewhat tedious way here. -- BR, Muhammad Usama Anjum