From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3A57C02198 for ; Wed, 12 Feb 2025 04:18:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B66E56B0082; Tue, 11 Feb 2025 23:18:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B16256B0083; Tue, 11 Feb 2025 23:18:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2B776B0085; Tue, 11 Feb 2025 23:18:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 856376B0082 for ; Tue, 11 Feb 2025 23:18:45 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 289DEB13FA for ; Wed, 12 Feb 2025 04:18:45 +0000 (UTC) X-FDA: 83109986610.03.629B7E9 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf18.hostedemail.com (Postfix) with ESMTP id EC77E1C0002 for ; Wed, 12 Feb 2025 04:18:42 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739333923; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xMe8Wzs/eC/K2NHhONXHtfebYgRfq0LdG3OgBm6zO8Y=; b=qe6sUlJb5rRxYVNb3kdq03ZYWcsAXlFnsB0ng739m6rcRbOux8NUUQ+Y2o5nEUdKBBAVHV sSgJF0Yzx/Drci+L7yNDkzYnz6cpwvnlV/rpzVr/sY0oqXFJbajY+kIDMUnvnt0mLX6HKv 9fiimVssegQqx35AN2zLErfKJdfjYSQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739333923; a=rsa-sha256; cv=none; b=7clmN3GQ48U8P1OJ6zNOkZB1QJQR91VDxz5E2Wy3UeUdiGED7bYEL/D3qWliaoijq1uoFr lorFprkDqd8+QKBWDK1evpzsA3zYqGb2/C174tSPJo9HEYvAFNwVoSEAdv20OWrSMk2XAQ haNRFYK8lUfWIKIZez7YXBU+I5v0mm4= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D137D13D5; Tue, 11 Feb 2025 20:19:02 -0800 (PST) Received: from [10.162.43.26] (unknown [10.162.43.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1525F3F5A1; Tue, 11 Feb 2025 20:18:30 -0800 (PST) Message-ID: Date: Wed, 12 Feb 2025 09:48:27 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 00/17] khugepaged: Asynchronous mTHP collapse To: Andrew Morton Cc: david@redhat.com, willy@infradead.org, kirill.shutemov@linux.intel.com, npache@redhat.com, ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, srivatsa@csail.mit.edu, haowenchao22@gmail.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, jglisse@google.com, surenb@google.com, vishal.moola@gmail.com, zokeefe@google.com, zhengqi.arch@bytedance.com, jhubbard@nvidia.com, 21cnbao@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250211111326.14295-1-dev.jain@arm.com> <20250211152341.3431089327c5e0ec6ba6064d@linux-foundation.org> Content-Language: en-US From: Dev Jain In-Reply-To: <20250211152341.3431089327c5e0ec6ba6064d@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: EC77E1C0002 X-Stat-Signature: zemacx1egz4okm5pkkwuuhmi9qbyd3zk X-HE-Tag: 1739333922-561556 X-HE-Meta: U2FsdGVkX1+b/5XWmAmzzSRSEEhddDHN0J4/ki6v85njNr3W8BRp0RqxE0GVJsrkJ8fiW0eILzsAP24Ydq/GgmmTzZ5GOVODaz66VqNUSWN1xzI4whAVQyepDG6dXa3wXZRN2OcDW1jxwBYn+81aXmXeYWEAe5crcDWT8F7IyTr0JKMQl3okmnHVcZnuFIgby9D90Otdua4fBUVPHtpPreVGuSHeQwEZkBNAriQQHYlDxVoPZG3SgWRSsWy6KIYK2WUp3H+GW49kLd398PO1zoHVfkHs3AigVWQH+O/QMEeqNV48LRahXuifvOxnwNyMbUSfXp5+91SpHHwqfL6IBUtsc/d90oi+WGqSqWl+3h9PJdxacznJtDGXf1pRKwdcm1dsrGD+rkssTUrlwOH3px1ybhvw7iVyVsf+hjuWf4c4ZhZEf+ssbHgekfR4Fo3jQ0jC32f62clKgyCJhACOVf2Ps5anoPSWt8krjMBHAtlV1rOaTr3iYV6+EAkjOE/mdqibcwOv1dSGMca5/2SWoGB9AG9bnXBCHMtg863nm6cBE05YtHd38KBg7FMLAlP1YKpUjMEV3SKI3FGrDYfBQc6w00LfQPbSWePl/ie4h3HX9aw9ddZ3F8qozyxq4q6oA3RRtcbdYdP8AW9HNT+ufb29tj8ok5sDCIEc+J4duTOPeQXHZhAjtGVBzQLto7itroQswA1oCvOK/PxcWy21kwKTspKSwWyFyb8GP/H431BoEXwQLUOjx2dBc8X4FZ0TczovxOI3II65G/FxEESy7yXi2cHBP/WfxG5Zu5QnBxF0DZp0g3lDyNeeoLQFy9UGeVsI+REV04sCFy2PO8a4QGuazInoTMzD8Q7vFU8Mrzc1dA3SF/nlnJstua0GcmgkgfKXQTNsG5PRumn+we86D3E+dsObT6CwwrGq4d6v1ODRIt0vG7z/lvTilgbPhEcylT1uUuvJOGymYIhoygf 8sgVjaj/ hvPMNb4dXqrfxCxNoUjSZ/Rxa1ilkCNpDSB7st/mvHhYBVSmFlA+9yUzIaREfH79Q4m+EDpdUj/4VhCsVFR8jxbqkiSL2oXvFylJdi9J0C3Bz2SU5ljvVH4rYVBXSLp81eo39k49z5vxZCH7uX7IN8Z7k9Vq6dvOK4ubR8dEo1ZE5U/zLevhLRMepUz3CWeLEsWrWS8rYVDOrlKGKIju53dwvcc1mS+vjnINKmiii3RBRaXhBORe1YYnzQkUawMSUS1tGyiAfeefKtdqghVpXkYx+WQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/02/25 4:53 am, Andrew Morton wrote: > On Tue, 11 Feb 2025 16:43:09 +0530 Dev Jain wrote: > >> This patchset extends khugepaged from collapsing only PMD-sized THPs to >> collapsing anonymous mTHPs. >> >> mTHPs were introduced in the kernel to improve memory management by allocating >> chunks of larger memory, so as to reduce number of page faults, TLB misses (due >> to TLB coalescing), reduce length of LRU lists, etc. However, the mTHP property >> is often lost due to CoW, swap-in/out, and when the kernel just cannot find >> enough physically contiguous memory to allocate on fault. Henceforth, there is a >> need to regain mTHPs in the system asynchronously. This work is an attempt in >> this direction, starting with anonymous folios. >> >> In the fault handler, we select the THP order in a greedy manner; the same has >> been used here, along with the same sysfs interface to control the order of >> collapse. In contrast to PMD-collapse, we (hopefully) get rid of the mmap_write_lock(). >> >> --------------------------------------------------------- >> Testing >> --------------------------------------------------------- >> >> The set has been build tested on x86_64. >> For Aarch64, >> 1. mm-selftests: No regressions. >> 2. Analyzing with tools/mm/thpmaps on different userspace programs mapping >> aligned VMAs of a large size, faulting in basepages/mTHPs (according to sysfs), >> and then madvise()'ing the VMA, khugepaged is able to 100% collapse the VMAs. > > It would be nice to provide some evidence that this patchset actually > makes Linux better for our users, and by how much. > > Thanks, I think I'll skip v2 and shall await reviewer input. Hi Andrew, thanks for your reply. Although the introduction of mTHPs leads to the natural conclusion of extending khugepaged to support mTHP collapse, I'll try to get some performance statistics out.