From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C15B6EB64DB for ; Tue, 20 Jun 2023 06:45:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56C788D0002; Tue, 20 Jun 2023 02:45:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51CC78D0001; Tue, 20 Jun 2023 02:45:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3967C8D0002; Tue, 20 Jun 2023 02:45:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 278958D0001 for ; Tue, 20 Jun 2023 02:45:52 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EC3D21405BA for ; Tue, 20 Jun 2023 06:45:51 +0000 (UTC) X-FDA: 80922190902.02.5481624 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2080.outbound.protection.outlook.com [40.107.101.80]) by imf26.hostedemail.com (Postfix) with ESMTP id DA9D7140011 for ; Tue, 20 Jun 2023 06:45:48 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b="D/uMWka1"; spf=pass (imf26.hostedemail.com: domain of Christian.Koenig@amd.com designates 40.107.101.80 as permitted sender) smtp.mailfrom=Christian.Koenig@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687243549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7FP0khkDo7XVVLXOsc0YO5tFywdc9jJYG0y71MKW79k=; b=6IVmDInOxi0TRnI0omkj3EuBfMNXC8RoZqggSOIBo4gJoq3/nXy6n2+U5UbZvTrswIl4KE 6KfE7RMJ82Y87sYEXBxo8SvktKlpPDwn/csbbXZMBKLnL8+/HeNkVRt9TBl+mIH0MBtSaE CFYc7WJ/KOOGylcMuEIy59KZVCTDJn0= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1687243549; a=rsa-sha256; cv=pass; b=aVu+854Z7M1EVaWJT2ghpUJ4hvk7+z1xL8Jjf+FW5tzPO5H0veop3n+/8iuDqDJFr4Thjh ikSy/PhXd0+aPRAuqYPs/ZtNaQ//mxVbiNhQcZp+tqWwq7dwgnQz33kobvvLnP8ao2iHDt Z/uSjD/GslgWkyTfED1U6EpadPSqSWI= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b="D/uMWka1"; spf=pass (imf26.hostedemail.com: domain of Christian.Koenig@amd.com designates 40.107.101.80 as permitted sender) smtp.mailfrom=Christian.Koenig@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JVuG6IkSjOCXqdEWXeI92ag5xTvrmKMxrpCSv+GMb2F8l+Naqo5b4Snt/I/JL8RKdSUfAAZHgN47ImgOrmC+cstFMtMhVtphHNkDWZnmbVtAAQD8ypUMxPpFXpUAOEIPqMbyvlidtR9c6CPgHQaA2iCi1FEo9M9dvN5YpoUYHlP+0GgW7CH/wB8XZJswklkQozkbU0vpsQhN/FgcIMTHWdZS1YW1gX9C5ZigrK27pArP2JiOe8OIat6DzVFVJwCdy9DkywZfXjGinoiGE4tFIxJsVb0l3IwbO7d2iWRnzxaAMt8R5WBZHCyM9mRVVwUTx/lroBeZv78kdwMmBR5pOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7FP0khkDo7XVVLXOsc0YO5tFywdc9jJYG0y71MKW79k=; b=fnmBxZ1Ws3VnSA/dsfNlAZ4h8B3eGC3MfJ4rAI9hF1ecuwMitkCqswajLw9zT+2uhf6CcYCf0NIiMm27+H0rhO2+impBSuYx3+zZ2PiylKVqN/vkHUafsLVhDjXMs/Yhvkl4qL3GeUft1SZt8P6vM2OZ6s2TH+Aqgj2lY/pfv7W47HTyE97nBaS5TaeL1AjgdYPZH2+GdeOU98DCfR9FGLfZ+AU2o8o3J/gmRX6StqYFJ6hkeTTVpDl6uz/QfXC9oVqPy/QTHSlII+X/ECnzX/Fj57FOck1523i9W4VnUS30UNW4pUXwgcIrnjO3HEb8pyC357NgsuJNZ4jSZKMZOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7FP0khkDo7XVVLXOsc0YO5tFywdc9jJYG0y71MKW79k=; b=D/uMWka1QW8Yog3XikL/DBZ8pu0O8t8W5IXHrfLTp94dfoGDhbtzowaudMfBIETr4jLUbHM/QWijnqccTduIoEGrb7x2UlRE+nIxd0mP0bD0jryx5rvAhTwXK4UeSnrxXqLcBfYljIGYL5hAk+Tu+WNvYULLogGDma0U1FIk09I= Received: from BN8PR12MB3587.namprd12.prod.outlook.com (2603:10b6:408:43::13) by SN7PR12MB6692.namprd12.prod.outlook.com (2603:10b6:806:270::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37; Tue, 20 Jun 2023 06:45:45 +0000 Received: from BN8PR12MB3587.namprd12.prod.outlook.com ([fe80::384a:95a4:8819:ee84]) by BN8PR12MB3587.namprd12.prod.outlook.com ([fe80::384a:95a4:8819:ee84%7]) with mapi id 15.20.6500.036; Tue, 20 Jun 2023 06:45:45 +0000 Message-ID: Date: Tue, 20 Jun 2023 08:45:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings Content-Language: en-US To: Danilo Krummrich , airlied@gmail.com, daniel@ffwll.ch, tzimmermann@suse.de, mripard@kernel.org, corbet@lwn.net, bskeggs@redhat.com, Liam.Howlett@oracle.com, matthew.brost@intel.com, boris.brezillon@collabora.com, alexdeucher@gmail.com, ogabbay@kernel.org, bagasdotme@gmail.com, willy@infradead.org, jason@jlekstrand.net Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Donald Robson , Dave Airlie References: <20230620004217.4700-1-dakr@redhat.com> <20230620004217.4700-4-dakr@redhat.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= In-Reply-To: <20230620004217.4700-4-dakr@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0240.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b2::15) To BN8PR12MB3587.namprd12.prod.outlook.com (2603:10b6:408:43::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8PR12MB3587:EE_|SN7PR12MB6692:EE_ X-MS-Office365-Filtering-Correlation-Id: 8c58ac4e-1b54-4ef0-7e05-08db7159f96d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NXM5juGnqO0M0gw7+gJLCwHIbhH8JMHcurLMLY8cWJkXLWbHItCAMyLGk2fnVDHFHxr2QxMzZfPtQTFI48i51C3eGvKryjF6VDEpwN6BMnb5ySultXrCYJ1GRjcrcpO7ZQ7Dad0Fy+Wa3DAhorZD/lCz3+kRsvW2BA/9IPKZ/iZxt4D7AmwKuDf+R0cjXVQP2zLKDeajsge4fp9n/hENwgSR+mqU+agTkWWlH4gdIgtOdWwSMzNxMxbspjSQL41gdWXaSmbBoJuFtXqKTy2x/1Wn4uoKcUsryTnT93jKPopopqjp8Mk80fI9V/n3GS0I73c1ogXq0wAql6uV4iRfky1LT25DwAOrw9FxpqVmUXSW/qQeJIUyn/HvV17otX1DAtVYl6cllZn54W5pe57y48moZNCzR0yCVOs9VQbxjLuxYT2N/rX8YjykPAgoFbg07oVF9/bW7OR7NpOfJzy768Ra9QjhYlwzwHogU2XiUi9VVEyoxbXTt9lQlRZq3oz0Bk0IUo8qyA1FaYwCHxDnANEAjYNGEmbVWs2u8ag3GPwk2SRIb/LYMgcVgPgAMq//7xsOfC0DCZiwBVFdo9nHCLRMZvOk1bf3XsrPeiD3X+lTvGYgyiNeBrg/8ymwvlnZ3OTd966PZU1cZ6T/3z10y1w62IElw+l+yg5KhmbUn1M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR12MB3587.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(346002)(366004)(376002)(451199021)(41300700001)(5660300002)(8676002)(8936002)(2906002)(7416002)(36756003)(86362001)(31696002)(6506007)(6512007)(26005)(478600001)(54906003)(186003)(6486002)(6666004)(66476007)(4326008)(66946007)(66556008)(316002)(38100700002)(31686004)(2616005)(83380400001)(921005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUxqdDl4U21EZmdQQ01GUW9LSHVaK0dCeUR0NkQrTnRuTHUvZXNZTVNtUTk1?= =?utf-8?B?Y0hFM0pjSms3WDhPYU5TdDR1TWx0NWJYaDRjdHN6SEZxNlh3Vlk2T1F3QXZT?= =?utf-8?B?Z0F5ZFJ4d0ZSNFlMcUMxS2V2S1VlYTNHSUlGN04zclFTQ28zZjFySG1DZ3dG?= =?utf-8?B?Rlp2dVZQVDJKWkJBVCtOdE1PVzBQTGNkSXB0d1I4b3I1c3k1Rys4UHJQM0Vq?= =?utf-8?B?ZzVZa3BrMWZlRVZQUDVuTmdDWDF5N2lta0JmMVh5bVFnYnhvaG1CMGlvVCtB?= =?utf-8?B?QmljQ3AxbVA2U3JaS1VlcDVGSk5ONzBySWttMGF3RVFQTlVLajl4Tkx5elRu?= =?utf-8?B?NDJZRi9mL1FmcGhzcDJLcmkyNkNoaElwR0I3R25oOFhCdEdZUWtCSnVJcEVt?= =?utf-8?B?YkNBNVlGQUR6SlVxaXNITnlIaFFUNGpmZlhDOXpBd2kyQUhod29hSzZ5Sitn?= =?utf-8?B?bnkzbWY5RE9wTTRPOE1tczRDZCtXQ0t3QnJlWHlqZFNZalBSZ1FsYkFmSGFF?= =?utf-8?B?ai9aeHNUZ1Y1b3Y0aTZoT01SY1FaVDBxMGE1ZjFQMTd4Z3VmaWVnYmxmb0VQ?= =?utf-8?B?ejYxdFdrYlFzZGIzYlBWYzM0NXJlUXJFVExzcURGb0orVjg5NGttZ3pqNDgy?= =?utf-8?B?RmtZRzlhMW9ZMEdIUU9HSTBSL0NaVDFRc3l5TTBoMGZkdUVzM3FRZGxKM3Mz?= =?utf-8?B?U0NHMHVyUjlOL29adDdVNFpUY2dvTndSOUNZUmVYQVVnajRDZUlMaXRuSDNj?= =?utf-8?B?eGJBWVhhcTFndm5nYXhETnhYTHAwbWRIUUJCNkVWTnlnZnZDN1JmdEZTd2Ir?= =?utf-8?B?aXE5L0VPSEYxQkpNTjlGU01IR3NCSk95c3V2ODBUTVcxcHRSQVhqN1FmNE41?= =?utf-8?B?V1pURWY3dnBRV2FvWjlXWS9xVC9UbWs3dmxjT05Wc1B2ODJZRXF2RHRkWGxt?= =?utf-8?B?Unlybnhhb2tUWHNWZ1pyMTZUdy9MMWlxTHUvdHJKeC9GR2l4UUNIRSt0c3lR?= =?utf-8?B?Z2JZTHFld3FGN05GbXFXUzhkRUR0eUk5Z2RVYnR6aFlERG9QWlVaSXF6TzlB?= =?utf-8?B?S2k0MTNiWlJ1YzAzcTJ5bm1xNCtQU3YwMkJNSk9Gb2R2VVVTWWM4RURKaisy?= =?utf-8?B?bnRVNGx0ZkxTdTRLak9tbitSdlpYNVpnTzJjKytOaTgyNE5scCtpeDJuaC9t?= =?utf-8?B?cTBNQ3ZVcFc1cUx6WFRNMzNtbllnRFNCYnJZbUlwdHlvRjNKNGgzc0Nla3Vz?= =?utf-8?B?TkxyYmVwU1d6Sk5ZU1YwaXRlWG5QUnJBQjVNcllMV0hwRlVsODJSMkpyQUg2?= =?utf-8?B?SDhxUEdmT0VjTDF0UWJ1akxFM2h3R2tPTVdOWllWVXRvY1ZYZTBqNzVwVHhw?= =?utf-8?B?V3pKRzAxcSttRDhQbDBja2ZtZ0xWb1o2NU8vL2NDU1ZPQTdUOFFvbHZrQUpW?= =?utf-8?B?WTlrZHZMekZ4QXRKTDRwU0tkaEpWejJJQWZHTm1rM1g0SFQ0Z0k0ZE5tcWFX?= =?utf-8?B?Tjd1Q3h1ZFRWMzVQU0MwUVhGRHVsanZzZ0hIUXRiVlR3NjljcVVXMi9wckIy?= =?utf-8?B?L2RvZ0lRNE43eXpRWkE4Vnk0eC81ZzBpaFh2U01PZ3NvY1NyRUZhSVVYOGpX?= =?utf-8?B?L01Rb1oxc1VGSWtHV3dTNWV3cVBmSTVVbkl6SDFscU5ld01EYzdXL1VTbExH?= =?utf-8?B?TmJFL1ZMeGl2bTA0bXJXSVNOYmNYVDhMdjlWY2RTYi9ITkVROUJUa053bkpP?= =?utf-8?B?c3JuZnYwTkRZT0cwUmdPaDVvVURYOVNOUk0walo5Vk9yd0JGcTArdHpxelR1?= =?utf-8?B?Z0c1NmlySlp2TkZqUHR1MnVNZzVQYWpWamw0MEhSYnRTd205TEgwMjdmZm14?= =?utf-8?B?STU1T29Jck5PVVR3Rlovb0ZkYlpmZnU3MVdRNDcxTUdRS3hreHplZnVUWjRN?= =?utf-8?B?N1A1eFBUMkVkeUltMVBQOHhhR0hnR25Geks3ZGkwUE5MK05PVWdYY1VwUjRa?= =?utf-8?B?THJLZjk4d1pnWnVrMFIzSFFsRXF3cGczY1NBcWYzWmw2OVA5SS9zbHIvd0VX?= =?utf-8?B?amtyak5HZW9JMUZQUVlJbHVZZlIwaExvSS9SdkhsRW4wU3FHNFAxNXVQSWti?= =?utf-8?Q?DzH2icqrkSULk4QA62OKneTIz?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c58ac4e-1b54-4ef0-7e05-08db7159f96d X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 06:45:45.7074 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uOvcmq9iNz0c4Y0irlKS7+fnH4/R06Wj/qaJ6dNUPmcz5QhEUkJ53mqzRy6Gxdp4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6692 X-Rspamd-Queue-Id: DA9D7140011 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: zc97gdqypit9k9mnu7y8ucyqee8oay1r X-HE-Tag: 1687243548-310546 X-HE-Meta: U2FsdGVkX1/soIL2KM/31Fh0nyY4/mLItZDThWdp8TptCtOsWtn7/fGIk6u/YW9nWZHuZLtv1IvAhitws4QZ+PhztnBNhmhfxWJ/SuaFonbkD16nnEwZ/qO8X1hovhgikT40Z9mCJfPBlr7tDYswUETI/YBOVfLxwIpBpgTRShijIE1l2cgV8ktjEATa+r8HqPTMMbaLftIR/AE2rYCe/kzyPNrW63++Uw/vcUUA/begu5lsWAHSwE5Tdf9wqV4FQsnZj8ETUv14OEWtyIhTmiXcxISM3HHa3z5wCbKvFM3XEB9lSBaX6BWqSQuCyTwYO6Tbx/JqTGqKpQwP49T2kWK1YUcu2FZUE/ubvVlr2ibpyTqFrCYfdx+vhLL2kixFGQ324P6dENep6zhDhPD1PAPdBNM7YuPKq1fhlgLxnf0TZTf9zBiZMu6DfWtkfKqTV/Kyr403zomhD6UpS6G046LIqhNWm2CAw96gLDrWeOnxPWdDWAVCHjRcCG7uyTzA4zSnw5C5eNd3KN9+TdDspqmCYesk6H1czD4goMkucRHfU/PUSOZjwhr9M+5G/28ai9FFe+6m4Und/h8hnFMO6Sbu4xdEqf6NnJDOA0RMhXRSbZsleDbuM2bYi84DG98UK3tnnuIhHAXkVIpI5ph5ToxHcDmlZTrQR1H7mDUNmRPQFh0RhJDfUjfshdpsqkgkas7ZcezEdCuzD4OOjOpMDAJJ125W/dYTixCSbBGkBg2Lv9mhlCo8DmJ2E6gUcxVwVKzpP7tAm6LhU/o9qSr5n70K+4FU6oa+75Uibqy25lsaQkM59rCRh4LKQeoLQ0+Z0O36ejaer6UKYc7aU25EUy9n89tiQRKoumDxcbH98W3RDNYovsONeKsHsmAImwQx+lWbS1h11jiL4LjAtQUa4FVZ8AHfTSD5GmbMyJsHGpfq1864BJ20tvD4zQ16Bj+xDMv7bz7xBUD4O01G/M5 FGX/CM5g 3uA7fj9TwmYFrGKGMkVe6dT+BNstvoydSJQWLEImEoMK5LFad3fo2drv2pOWkTx6aJIWFYlV0oqWXtdVteLDpvFzODB2fu/Eru7ShFZjsekW6XSPn++Es42Wo3Xe3N1JOceqtCMf68XYofl/W9/pJzMKn9XpNEnnBAH/42+UBbLaBzK4/kGvJYeJMAROtr5fDaxOfaYWiAhEnc8dTlCc1lr2We2Pd9NibbR40NQV6n39Dt18= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001700, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Danilo, sorry for the delayed reply. I've trying to dig myself out of a hole at the moment. Am 20.06.23 um 02:42 schrieb Danilo Krummrich: > [SNIP] > diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h > index bbc721870c13..5ec8148a30ee 100644 > --- a/include/drm/drm_gem.h > +++ b/include/drm/drm_gem.h > @@ -36,6 +36,8 @@ > > #include > #include > +#include > +#include > > #include > > @@ -379,6 +381,18 @@ struct drm_gem_object { > */ > struct dma_resv _resv; > > + /** > + * @gpuva: > + * > + * Provides the list of GPU VAs attached to this GEM object. > + * > + * Drivers should lock list accesses with the GEMs &dma_resv lock > + * (&drm_gem_object.resv). > + */ > + struct { > + struct list_head list; > + } gpuva; > + > /** > * @funcs: > * I'm pretty sure that it's not a good idea to attach this directly to the GEM object. As you wrote in the commit message it's highly driver specific what to map and where to map it. Instead I suggest to have a separate structure for mappings in a VA space which driver can then add to their GEM objects or whatever they want to map into their VMs. Regards, Christian.