From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52934C48BC3 for ; Wed, 21 Feb 2024 09:27:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD0016B0078; Wed, 21 Feb 2024 04:27:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B58CB6B007E; Wed, 21 Feb 2024 04:27:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 983CB6B0082; Wed, 21 Feb 2024 04:27:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 84CEB6B0078 for ; Wed, 21 Feb 2024 04:27:18 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4DC3B409A5 for ; Wed, 21 Feb 2024 09:27:18 +0000 (UTC) X-FDA: 81815282556.05.F9663F0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 226A880011 for ; Wed, 21 Feb 2024 09:27:15 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YFslji75; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708507636; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JqDQzqQUNVGgLXFQ47h2MyrP+vNxqZ2Sfg76FoOL2Z4=; b=ekB2tqRIZMpFxaDHgXC6wR6MKQf1Mk7tmEDFYPpEJbkcMJ8Pn+Vfs3KlcUVXn78aGKxCgQ JB06IMzOIWswpdrWGAZRNtxkyFre6dZf63xMWE3M81h6eIgfuF4EscDhOIqi2CjWlZAzs+ dJMr6zAHbOKdQZvl0wAM02jCvgBJBmY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YFslji75; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708507636; a=rsa-sha256; cv=none; b=XPs8mp+8ZezeFEmqrW8QJVfvrV7ta2+hVWqDMX+XX0SC6YSIRrFuvw7Mc23NKuGTRdgGlZ fDR5TrkPth/k1JXE7bGquI8ZH/e51FmQR+B92KVm6eCNYL2cEdXvdHUzWgFz7T22iUgcuh cpfNEEjNgf4JWiCoBnRy4jXEmoF7npA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708507635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JqDQzqQUNVGgLXFQ47h2MyrP+vNxqZ2Sfg76FoOL2Z4=; b=YFslji75Q/eCXAx0UssqFmxyG3kw6PNQutqWTAhzWGqemHH90Qy/ZsSjYVD5bs3xhw4+Ay kk5tdK+z+Z4z466S0BvdPSZ6DmHzLl7Ncrp8ZPt2r8+f4VrBaRqgzr3AVZh6CvzqiBo7Wt rksXrZuZKnrcjyTluPpYzbJrdvpksZk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-342-7gdV0Bi_OZO8Fe41QR8aTw-1; Wed, 21 Feb 2024 04:27:14 -0500 X-MC-Unique: 7gdV0Bi_OZO8Fe41QR8aTw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4126c262040so9744755e9.0 for ; Wed, 21 Feb 2024 01:27:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708507633; x=1709112433; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JqDQzqQUNVGgLXFQ47h2MyrP+vNxqZ2Sfg76FoOL2Z4=; b=c6MTbDvCOrHOSxg0l+HO8xwFGtqOJWLgu1bJo5PSnvmUNiNK2IiCDo5cHlY12Q6f7f vVf5DhB0SHgjsedYEdOx88TOZcRlJ9ziIvtqf5Abqymce/Q/+f0Lgd6NHXCEnzNakZxZ L+Ia+GJe5SOVvK0g2s8abzOfhc1pz3H+nbuXw7bap9yVBlJKa94lqGCpoP1TeRthpxQH D5a1wtwf2OmZyS8r/bOfmqkZEum/0VxiOkZ0y/tMOLz2aQeWKkwWfjWI3QzWvd+2OKJ4 f+IssSsuS9EKhS+u1f9rmfKXdnr0o9UMe4IN0xneZlewTVKXk90mSUXGSmXcy7dzc0l1 xzcQ== X-Forwarded-Encrypted: i=1; AJvYcCWmGzidoeugOVMknwLJRw4auUMne9etWN8eYu32HL+9WsGQPS1yskCPgyC+kqR+ViDKJ4pWnk6w5d3112HOFmkLHY4= X-Gm-Message-State: AOJu0Yxd1T+qP1pNjgPiPupr25CxYm6gZiry0jyhQUonWqPODA0DPRNl WTGdXiVeInQl07lUFlY0rq7wOeNSPWVY82JHywSPm6FzgrtUu0HTDmERuCn88jIS47BIDhqg9sY XpJOFpJspV7J698u7JRwjDGau0qBTlrbWz2ZeIp7G/TIIpPBz X-Received: by 2002:a05:600c:19c7:b0:412:5296:9737 with SMTP id u7-20020a05600c19c700b0041252969737mr13136546wmq.12.1708507631919; Wed, 21 Feb 2024 01:27:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IFJ7FuH/em5oiRt/ZTOR4oMLbXYFTRabnhBDn5rQM4tupeTaNWMPYn2RFDHXi6wWaSGqKntiQ== X-Received: by 2002:a05:600c:19c7:b0:412:5296:9737 with SMTP id u7-20020a05600c19c700b0041252969737mr13136504wmq.12.1708507631270; Wed, 21 Feb 2024 01:27:11 -0800 (PST) Received: from [10.32.64.237] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id jj2-20020a05600c6a0200b004126732390asm1837805wmb.37.2024.02.21.01.27.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Feb 2024 01:27:10 -0800 (PST) Message-ID: Date: Wed, 21 Feb 2024 10:27:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] mm: pgalloc: support address-conditional pmd allocation To: Christophe Leroy , Maxwell Bland , "linux-arm-kernel@lists.infradead.org" Cc: "gregkh@linuxfoundation.org" , "agordeev@linux.ibm.com" , "akpm@linux-foundation.org" , "andreyknvl@gmail.com" , "andrii@kernel.org" , "aneesh.kumar@kernel.org" , "aou@eecs.berkeley.edu" , "ardb@kernel.org" , "arnd@arndb.de" , "ast@kernel.org" , "borntraeger@linux.ibm.com" , "bpf@vger.kernel.org" , "brauner@kernel.org" , "catalin.marinas@arm.com" , "cl@linux.com" , "daniel@iogearbox.net" , "dave.hansen@linux.intel.com" , "dennis@kernel.org" , "dvyukov@google.com" , "glider@google.com" , "gor@linux.ibm.com" , "guoren@kernel.org" , "haoluo@google.com" , "hca@linux.ibm.com" , "hch@infradead.org" , "john.fastabend@gmail.com" , "jolsa@kernel.org" , "kasan-dev@googlegroups.com" , "kpsingh@kernel.org" , "linux-arch@vger.kernel.org" , "linux@armlinux.org.uk" , "linux-efi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "lstoakes@gmail.com" , "mark.rutland@arm.com" , "martin.lau@linux.dev" , "meted@linux.ibm.com" , "michael.christie@oracle.com" , "mjguzik@gmail.com" , "mpe@ellerman.id.au" , "mst@redhat.com" , "muchun.song@linux.dev" , "naveen.n.rao@linux.ibm.com" , "npiggin@gmail.com" , "palmer@dabbelt.com" , "paul.walmsley@sifive.com" , "quic_nprakash@quicinc.com" , "quic_pkondeti@quicinc.com" , "rick.p.edgecombe@intel.com" , "ryabinin.a.a@gmail.com" , "ryan.roberts@arm.com" , "samitolvanen@google.com" , "sdf@google.com" , "song@kernel.org" , "surenb@google.com" , "svens@linux.ibm.com" , "tj@kernel.org" , "urezki@gmail.com" , "vincenzo.frascino@arm.com" , "will@kernel.org" , "wuqiang.matt@bytedance.com" , "yonghong.song@linux.dev" , "zlim.lnx@gmail.com" , "awheeler@motorola.com" References: <20240220203256.31153-1-mbland@motorola.com> <20240220203256.31153-3-mbland@motorola.com> <838a05f0-568d-481d-b826-d2bb61908ace@csgroup.eu> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <838a05f0-568d-481d-b826-d2bb61908ace@csgroup.eu> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: 6fcaao9f9k7h5ta4cs741ofkitwcxt63 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 226A880011 X-HE-Tag: 1708507635-509775 X-HE-Meta: U2FsdGVkX1/6g8BAJjZinqirllOFzXA+ZcAw9/BYC2UCotXf+sKYqfmC5WmAZUJMvWNG80kyJl5pgKgxT+XzMSyOd4yT7IHUuGvmj3T9DnzcsUNYgvgyXvfe5u+nxoL/NWVL2Js7tG9WTgsmjyr9vIiWLg6vW5nonPzmngArvyn9DZymG5LFy3yA08VyAs7iU5B67MHDb3CKU4GczS2nLCZWOsmpnU03AG07wBhb0HeTIcDRK579JScyB6JYdzSggj81KCSFwpxqpBBBddHc/e5hxKpKQoSL7/oJ+KcUWxaLdglVyjtZCWit5idMWUgwA9zsM02Niz8FBpHrC8h8Syc6vCBDu9uwtLfXCMNpvOnF51fVBII7QXPUVV8S8L4AIHRNYWsQ/ibLXoybh5MwtgQvq7NFDyDEwdCucdan99XsKZfJjbfRpL19Y+5W4kjbEc6xlJGTLbgOECjy2a4x91VFd66p8Awq71pDiBjFLNSUvplzAvQdpBi2hFpdPnOatIV+5Pfok7AzKR1wkU9s8KGRd7B1XVy/OAUsqb5JhOnsk4iKb3CZop6jY7BNt8ShLXeBW8T6aPz6MAOCy2615jsoMOvmz1zmA55yqjikAt1p18Qej0ufiNMOxXJTOACGHYzR/qT4dVPyBv83e1bl6OtPvD+S7/O90Zqvo0AeEvjeGmO62B5Rfe4HAfkmdEScQ5Ss+mhAerH30cNHDfIErK9Rrg7bKBhWXjMXPcmBz6mSbYXLviEsyngQW602upCyXeDpSwNZHqlwoJevmMra3SwI2R68LX1HXF0igxbMhcypZftYztZj3AajS/1oRIs6/lGd0yThx73zNBxOPEFnTIEe6TgwjYVkMqgTVzeZeVtczn3BOHp9eQGcCfSD63btFCIGgFI+2Yp6Ll6csmGN08eqYgKzXWvYUWD63tmemgUGHhhbc1YURcz+V2PgieWRyXoanD5c/YGaq67t33P J3bw3xvS z+QjrtF0i4SjSKJU2o0sEmAWpB4l5R20puONN/WDD9KZ4LmfKvD3Jixo2S9SvHZ46WDTSopZXHCmusPSVe/NTUnLXJoFcJpc+icRamNwTUs63/jZKohlbC6yLFka3s6PO4fcE9QVrX/vfEcxizgxeC6gE7Js0qCltYxl7+9GBGJO7f6fTbeQc7MR4pimEg3zOFvFOWZUvslJyrwaphRPQ2LdjZWewzRRqAOT32UoPeuY8ioGoROurMlbfDVTIWb9LEPpS0HSYEPmmgnmgCkFqdm6J7g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.02.24 08:13, Christophe Leroy wrote: > > > Le 20/02/2024 à 21:32, Maxwell Bland a écrit : >> [Vous ne recevez pas souvent de courriers de mbland@motorola.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] >> >> While other descriptors (e.g. pud) allow allocations conditional on >> which virtual address is allocated, pmd descriptor allocations do not. >> However, adding support for this is straightforward and is beneficial to >> future kernel development targeting the PMD memory granularity. >> >> As many architectures already implement pmd_populate_kernel in an >> address-generic manner, it is necessary to roll out support >> incrementally. For this purpose a preprocessor flag, > > Is it really worth it ? It is only 48 call sites that need to be > updated. It would avoid that processor flag and avoid introducing that > pmd_populate_kernel_at() in kernel core. +1, let's avoid that if possible. -- Cheers, David / dhildenb