linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Oliver Sang <oliver.sang@intel.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
	oe-lkp@lists.linux.dev, lkp@intel.com,
	Linux Memory Management List <linux-mm@kvack.org>,
	Oleksandr Natalenko <oleksandr@natalenko.name>,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>,
	linux-block@vger.kernel.org, ying.huang@intel.com,
	feng.tang@intel.com, fengwei.yin@intel.com
Subject: Re: [linux-next:master] [block/mq] 574e7779cf: fio.write_iops -72.9% regression
Date: Thu, 1 Feb 2024 07:30:53 -0700	[thread overview]
Message-ID: <cf5236e6-a79b-455a-9afe-b5dbf27d33e9@kernel.dk> (raw)
In-Reply-To: <ZbukvbmE3K8y+JdJ@xsang-OptiPlex-9020>

On 2/1/24 7:03 AM, Oliver Sang wrote:
> hi, Jens Axboe,
> 
> On Thu, Feb 01, 2024 at 06:40:07AM -0700, Jens Axboe wrote:
>> On 2/1/24 12:18 AM, Oliver Sang wrote:
>>> hi, Jens Axboe,
>>>
>>> On Wed, Jan 31, 2024 at 11:42:46AM -0700, Jens Axboe wrote:
>>>> On 1/31/24 11:17 AM, Bart Van Assche wrote:
>>>>> On 1/31/24 07:42, kernel test robot wrote:
>>>>>> kernel test robot noticed a -72.9% regression of fio.write_iops on:
>>>>>>
>>>>>>
>>>>>> commit: 574e7779cf583171acb5bf6365047bb0941b387c ("block/mq-deadline: use separate insertion lists")
>>>>>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master
>>>>>>
>>>>>> testcase: fio-basic
>>>>>> test machine: 64 threads 2 sockets Intel(R) Xeon(R) Gold 6346 CPU @ 3.10GHz (Ice Lake) with 256G memory
>>>>>> parameters:
>>>>>>
>>>>>>     runtime: 300s
>>>>>>     disk: 1HDD
>>>>>>     fs: xfs
>>>>>>     nr_task: 100%
>>>>>>     test_size: 128G
>>>>>>     rw: write
>>>>>>     bs: 4k
>>>>>>     ioengine: io_uring
>>>>>>     direct: direct
>>>>>>     cpufreq_governor: performance
>>>>>
>>>>> The actual test is available in this file:
>>>>> https://download.01.org/0day-ci/archive/20240131/202401312320.a335db14-oliver.sang@intel.com/repro-script
>>>>>
>>>>> I haven't found anything in that file for disabling merging. Merging
>>>>> requests decreases IOPS. Does this perhaps mean that this test is
>>>>> broken?
>>>>
>>>> It's hard to know as nothing in this email or links include the actual
>>>> output of the job...
>>>
>>> I attached a dmesg and 2 outputs while running tests on 574e7779cf.
>>> not sure if they are helpful?
>>
>> Both fio outputs is all I need, but I only see one of them attached?
> 
> while we running fio, there are below logs captured:
> fio
> fio.output
> fio.task
> fio.time
> 
> I tar them in fio.tar.gz as attached.
> you can get them by 'tar xzvf fio.tar.gz'

Right, but I need BOTH outputs - one from before the commit and the one
on the commit. The report is a regression, hence there must be both a
good and a bad run output... This looks like just the same output again,
I can't really do much with just one output.

-- 
Jens Axboe



  reply	other threads:[~2024-02-01 14:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 15:42 kernel test robot
2024-01-31 18:17 ` Bart Van Assche
2024-01-31 18:42   ` Jens Axboe
2024-02-01  7:18     ` Oliver Sang
2024-02-01 13:40       ` Jens Axboe
2024-02-01 14:03         ` Oliver Sang
2024-02-01 14:30           ` Jens Axboe [this message]
2024-02-01 14:45             ` Oliver Sang
2024-02-09 21:06 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf5236e6-a79b-455a-9afe-b5dbf27d33e9@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=feng.tang@intel.com \
    --cc=fengwei.yin@intel.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=oe-lkp@lists.linux.dev \
    --cc=oleksandr@natalenko.name \
    --cc=oliver.sang@intel.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox