From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49EC0C76196 for ; Mon, 3 Apr 2023 07:48:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67A0A6B0072; Mon, 3 Apr 2023 03:48:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 629AF6B0074; Mon, 3 Apr 2023 03:48:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C98B6B0075; Mon, 3 Apr 2023 03:48:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 39ECE6B0072 for ; Mon, 3 Apr 2023 03:48:42 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 00E8AC079C for ; Mon, 3 Apr 2023 07:48:41 +0000 (UTC) X-FDA: 80639302884.01.43494D1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id C757C180007 for ; Mon, 3 Apr 2023 07:48:39 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BTWMHFFD; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680508119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gg+D4CsPnhSBX6Ep/vVZ03qpNvjb7Nx0ShML5od8/7w=; b=IIAbZSm0uDsIzRuVDGZlYgNEnk46M5/LYTqRDkfR8nW0gkh8VN7puWd8HHIizYt8XOFjCD 4NuhIhT5+V8Dj7nKF5gLYKYg6Zd0il/31C8rg9LG6wCns2NxTvihwTbeTAJ/pp8IrecejW d7MrXZ1e6tike1G+T0AJE8NRHpPcOyM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BTWMHFFD; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680508119; a=rsa-sha256; cv=none; b=CIJimPpH2xafti+rZckunf5QcfUl8QN0JCv9qra3U7fjCHzbTe0Pp5EV62Ns0q+FgMl/MR E66WXr/kCfjVEhqxIoNBJErbX5HP4CYRkfK1BxBv/73B1+8CbofsRF5d5uRjXplXpUJ9lD P75EeDjyuauu6HY9iBh43D1fjM5doHk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680508119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gg+D4CsPnhSBX6Ep/vVZ03qpNvjb7Nx0ShML5od8/7w=; b=BTWMHFFDSqSxF7+BzgZiFYeRyZ59SarnyXHC+JEoZus68xzwXiCSCgiQrX5METkkxHueeq vjM4BcJVFNuEHPJJrbuFGBfHUJPJexq6hOWR7V5LKV/UQej5judx8Ga9WJyzSKDknBIY9L 3IEJro4HAbnzoPX5kiEcAnX4UWYnPQw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-130-_j0CJf-oMtWJJPmP1b6sWA-1; Mon, 03 Apr 2023 03:48:34 -0400 X-MC-Unique: _j0CJf-oMtWJJPmP1b6sWA-1 Received: by mail-wm1-f70.google.com with SMTP id i4-20020a05600c354400b003ef649aa8c7so12718531wmq.6 for ; Mon, 03 Apr 2023 00:48:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680508113; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gg+D4CsPnhSBX6Ep/vVZ03qpNvjb7Nx0ShML5od8/7w=; b=7lclRwJhDm7vh+8mC9cFFT8QOKThAWj+QXLJ8+Sz55pPcc9iFbm0UKSIRJ38edT8aF O+CtXPBgnWgTJT8ro4t4z4vsF+PKlGm8848Eosz/QFSJgoenhm9f/bBiua8EhG0AtIoC xj/MfTebTi5j3GVllOb34OC2NiaYIlWP3REWk+Qi3um1an5XMoOjLR9N5DqJp4RUC5DR cU8sdnWd63QMkeoDGnGo8dSc0UIjy8QXJRIRXno8EoOt95JPptfod/ttPg8Ymv4AOGG5 Yfb2Oqb2OuQxsYnLJUFoOJejAy+IQikXAEju23fndtk/fz1F0jMpE5yM2rsT6gv5HFxT kcNQ== X-Gm-Message-State: AO0yUKU0hDaBjiy28HbxaNtWbGZWd2jqNZ+45N2hZt9whVSHQYDuQE9t R6cwhke+6BcURl8zjNGFWT0v0aHHttDcv64PFCpVIC7Flg9C/InOEKTV2/mJyb3vbXmYlUHmcvy BZJy5tJM4MGU= X-Received: by 2002:a05:600c:2043:b0:3ee:4678:dde with SMTP id p3-20020a05600c204300b003ee46780ddemr26761756wmg.27.1680508113588; Mon, 03 Apr 2023 00:48:33 -0700 (PDT) X-Google-Smtp-Source: AK7set+hIQJPk9AeYQ1jOGL8hezQ5AK7xpXic1LUhQyAL2YtCFuergW3icXKd9hRk2LAG4cOh0BRKQ== X-Received: by 2002:a05:600c:2043:b0:3ee:4678:dde with SMTP id p3-20020a05600c204300b003ee46780ddemr26761730wmg.27.1680508113216; Mon, 03 Apr 2023 00:48:33 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:5e00:8e78:71f3:6243:77f0? (p200300cbc7025e008e7871f3624377f0.dip0.t-ipconnect.de. [2003:cb:c702:5e00:8e78:71f3:6243:77f0]) by smtp.gmail.com with ESMTPSA id q13-20020a7bce8d000000b003ef71d541cbsm11216347wmj.1.2023.04.03.00.48.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 00:48:32 -0700 (PDT) Message-ID: Date: Mon, 3 Apr 2023 09:48:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 01/29] Revert "userfaultfd: don't fail on unrecognized features" To: Axel Rasmussen , Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Kravetz , Andrew Morton , Andrea Arcangeli , Mike Rapoport , Nadav Amit , Leonardo Bras Soares Passos , linux-stable References: <20230330155707.3106228-1-peterx@redhat.com> <20230330155707.3106228-2-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C757C180007 X-Stat-Signature: n1psnjwkih3dba4qw3wbjqy5d539mff8 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680508119-26058 X-HE-Meta: U2FsdGVkX1/cAI7O4BuJ9cKguguzBmEtBaTcQ5SvWAKRznfF+gVzZGl3+ND2G0lbzlzqMOE5gV3T2QwhQO/AEAzm0mMFErJD1Tx7BH5FE6t8Re9l6Op2d/gExx/aBe9iW6M7vY/u22NkDrkmGmOG7Pya3nqdHGJVyZATxiTTy25zWX3CWxDiNV1THU3e3FYWMwMBwo8gJoBZkeGJhMgW3ypNLhDbVoqIwT6LTyyN3kEs+9nS0SPASlpkMthHYtSX1Wc7fZbNED0Jjc17mAuyiEQcAFAuEv01L+/YbRmZTd1r28f9doTkGQ1S7KiRJm5ssguqgkKRHHORM0jl9zWnF3GXYzWSiq627sDRW0oyjZTBqbU8PMAhZSV/IvnhmfomYOfha9Kd5g6+Z/LvRJARfkZ74f9W65JNlZpJhFvltjKuTDfSi1sZW8szv383B5wwwgQbMQma2iCVGJiXfLXleGgL0AQVMpLUypLriCbVIC04l9wlcLl9aQbha3iOzCZ+hnrph61VIa+ns2u4battIeOg/62NXV6IeSyh3gLCfxtRRG06qeD3iE3Kn+QBd4QriwnJGrRgEPlScDP+TwcBp6kE32FTO7cA3xB/lSepZ+4A6BK5QB2w0lrmvXN+VI3uIxVbTRxeLOsbQnFc5SICtf0lH5DBf98I0pvREOFiKIpqG77YISsPXUt9ivmAIt6c3tyJW4m3oL/4f3SYDSVPCViAheH0JbjuQNFCCykNLdSOmeRGlmrMkjFs1qNzRaQGBTCT2Uq90sYAFZI9uj82vx+622n/end0GxERzeTwqdc3PS/n6AXHGQsKv8X9MkbeuzD4vMiyJlWMw2Beu7QR1e/iXNjBggi01H8x05V/72MwgKHjMzQWUliO8MUWq+RVYBcBBxjyB0O3hHpX3C3E2JpbRlYjHvLkCUXwtEcFSi/fKr/mfl+MrmQcMKaNtGvMZDsPrOeZV6P5YlAo3tm AbEyMmFV OA/9Hes0jferDwfgZR9VBh6t3IJWNWPMv9DkjCjkMCoVkY2vzH53ZS0GTyI8jllalp5XIaYaGcZc3AOTOv0YqMO6uZ/1dDnaRcY4b9WHEUefZN+IgyfLgk4i9uDua0oVD40dU+0HpvT0I2x4rF6pMVNWOzTujDQ4VCcS1laYXFfuhrjaIb+JQGlrkIvqAZSzjBNeIRTKTlqoEw7xcLAHbG6Z44QGzeqGOhrqHUn3O19zuZ8qgOltRdFdH7/dtZVFdrd42ado1XFS2sY0Q8ldhZalD3R0dyBBr7cccM6zIM4C1nsGONAefEaAj8a5D3M51Nej3uhpNQAnQwNJ8XkLsEcWEswCKDEpptMaK06hPLJONhh3wlencoAST3qoT6cerbwD6vbfykErwYN4l2HJ6oHsZ/tbM2kxv4njr7gDhIZ2zWjU++aVHtu9GztK1Rz5WX7DXJ80UxnQRLo3UEyAN7DSORYtfCbfX1kCmatAJA02OkeB36ByMWQ/qlg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000930, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 30.03.23 21:04, Axel Rasmussen wrote: > On Thu, Mar 30, 2023 at 8:57 AM Peter Xu wrote: >> >> This is a proposal to revert commit 914eedcb9ba0ff53c33808. >> >> I found this when writting a simple UFFDIO_API test to be the first unit >> test in this set. Two things breaks with the commit: >> >> - UFFDIO_API check was lost and missing. According to man page, the >> kernel should reject ioctl(UFFDIO_API) if uffdio_api.api != 0xaa. This >> check is needed if the api version will be extended in the future, or >> user app won't be able to identify which is a new kernel. > > 100% agreed, this was a mistake. > >> >> - Feature flags checks were removed, which means UFFDIO_API with a >> feature that does not exist will also succeed. According to the man >> page, we should (and it makes sense) to reject ioctl(UFFDIO_API) if >> unknown features passed in. > > I still strongly disagree with reverting this part, my feeling is > still that doing so makes things more complicated for no reason. > > Re: David's point, it's clearly wrong to change semantics so a thing > that used to work now fails. But this instead makes it more permissive > - existing userspace programs continue to work as-is, but *also* one > can achieve the same thing more simply (combine probing + > configuration into one step). I don't see any problem with that, > generally. > > But, if David and others don't find my argument convincing, it isn't > the end of the world. It just means I have to go update my userspace > code to be a bit more complicated. :) I'd probably find it more convincing if we'd started out with that approach ;) . User space would have to deal with the behavior of old kernels either way already? IOW, old kernels would reject the new flags, new kernels would not reject them but mask them out. So changing that behavior after the effects is somewhat suboptimal IMHO ... and rather makes things more complicated. -- Thanks, David / dhildenb