From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BED6AC55178 for ; Tue, 27 Oct 2020 00:23:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 512D320759 for ; Tue, 27 Oct 2020 00:23:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="GfZl03Hz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 512D320759 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C90A56B005C; Mon, 26 Oct 2020 20:23:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C187C6B005D; Mon, 26 Oct 2020 20:23:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB8586B006E; Mon, 26 Oct 2020 20:23:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id 7B0006B005C for ; Mon, 26 Oct 2020 20:23:54 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 08497180AD802 for ; Tue, 27 Oct 2020 00:23:54 +0000 (UTC) X-FDA: 77415807588.10.lunch66_2f17e7027277 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id DD3D516A0B9 for ; Tue, 27 Oct 2020 00:23:53 +0000 (UTC) X-HE-Tag: lunch66_2f17e7027277 X-Filterd-Recvd-Size: 6216 Received: from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Tue, 27 Oct 2020 00:23:53 +0000 (UTC) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09R0FbBB078392; Tue, 27 Oct 2020 00:23:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=uRAj/oUYU6Qz08rcDbzfHpSL0p2/DhZAjTpOfARCJQw=; b=GfZl03HzSCgWF0Lo8+RjVohok+486IHirPaWiPb9ggCRw8nVKkUSMRC31G/DM2MPM06z 3qUEpaUcpwboKaU1KcVN/WiffziCZqSLeem4OL6KtdO2jXncKXESIpQXp3rTP+qJ1dc9 oeQIBuyozcp7kA7Uc9bVXY3IQ2BwtQqscRgBV1+VXpGYn2C+bl9AwMlVW5HVn5Mj+b8W 8CJABqpXU/93b3IebV2iSBeMOc2QMzQBTrC9w/bMTnKutqTX8XlAoCu+6qlRMAITiQvs mcWqrhp01Nv/69UhAdS6PCoDyXR9sflVKWC6x0tzI9O6n1lo9eZqPFTBZu2NFiu2963b iA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 34c9saqfq1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 27 Oct 2020 00:23:45 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09R0G0as025472; Tue, 27 Oct 2020 00:23:45 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 34cx5wgp8q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Oct 2020 00:23:45 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 09R0NihM030423; Tue, 27 Oct 2020 00:23:44 GMT Received: from [192.168.2.112] (/50.38.35.18) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 26 Oct 2020 17:23:44 -0700 Subject: Re: [PATCH] mm/hugetable.c: align some prints To: Hui Su , gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20201009162359.GA19686@rlk> From: Mike Kravetz Message-ID: Date: Mon, 26 Oct 2020 17:23:43 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20201009162359.GA19686@rlk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9786 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 mlxlogscore=999 suspectscore=2 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010270000 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9786 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 impostorscore=0 mlxlogscore=999 malwarescore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 spamscore=0 phishscore=0 clxscore=1011 suspectscore=2 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010270000 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/9/20 9:23 AM, Hui Su wrote: > in old code, it shows like: > Node 0 ShmemHugePages: 0 kB > Node 0 ShmemPmdMapped: 0 kB > Node 0 FileHugePages: 0 kB > Node 0 FilePmdMapped: 0 kB > Node 0 HugePages_Total: 0 > Node 0 HugePages_Free: 0 > Node 0 HugePages_Surp: 0 > > which is not align. So we align it. > > Signed-off-by: Hui Su Apologies for the late reply. I assume you you just want to make the output look better. Correct? To be honest, I am not sure about the policy for changing the output of sysfs files. My preference would be to not change the output. Why? When the output is changed there is always the possibility that someone may have written code that depends on the current format. It looks like the output has been misaligned since the day the code was first written. This code was recently changed to use sysfs_emit_at() instead of sprintf(). At that time Greg noted that this also violates the sysfs rule of one value per file. So, it appears there may be a bigger issue than alignment. Greg, Is it OK to break up these sysfs files to be one value per file if they contained multiple values from day 1 of their existence? I would prefer not to touch them in case some is depending on current format. -- Mike Kravetz > --- > drivers/base/node.c | 4 ++-- > mm/hugetlb.c | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/base/node.c b/drivers/base/node.c > index 50af16e68d98..b5453c372c5b 100644 > --- a/drivers/base/node.c > +++ b/drivers/base/node.c > @@ -430,8 +430,8 @@ static ssize_t node_read_meminfo(struct device *dev, > "Node %d AnonHugePages: %8lu kB\n" > "Node %d ShmemHugePages: %8lu kB\n" > "Node %d ShmemPmdMapped: %8lu kB\n" > - "Node %d FileHugePages: %8lu kB\n" > - "Node %d FilePmdMapped: %8lu kB\n" > + "Node %d FileHugePages: %8lu kB\n" > + "Node %d FilePmdMapped: %8lu kB\n" > #endif > , > nid, K(node_page_state(pgdat, NR_FILE_DIRTY)), > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 67fc6383995b..077860ea2452 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -3588,9 +3588,9 @@ int hugetlb_report_node_meminfo(int nid, char *buf) > if (!hugepages_supported()) > return 0; > return sprintf(buf, > - "Node %d HugePages_Total: %5u\n" > - "Node %d HugePages_Free: %5u\n" > - "Node %d HugePages_Surp: %5u\n", > + "Node %d HugePages_Total:%8u\n" > + "Node %d HugePages_Free: %8u\n" > + "Node %d HugePages_Surp: %8u\n", > nid, h->nr_huge_pages_node[nid], > nid, h->free_huge_pages_node[nid], > nid, h->surplus_huge_pages_node[nid]); >