From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C970C04A94 for ; Thu, 13 Jul 2023 13:57:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDF6B90001F; Thu, 13 Jul 2023 09:57:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8F7E90001C; Thu, 13 Jul 2023 09:57:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2FF090001F; Thu, 13 Jul 2023 09:57:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C452990001C for ; Thu, 13 Jul 2023 09:57:02 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7F9FB802A3 for ; Thu, 13 Jul 2023 13:57:02 +0000 (UTC) X-FDA: 81006739884.30.39C215B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 14AD010001E for ; Thu, 13 Jul 2023 13:56:59 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HwW7Jwqa; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689256620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u7slRFqXzj+fIwUfWpHgJOEMlp6jejIeFSooLIetSLk=; b=SdVy2mK+YLsXYzUvgu8UjUHehpAkqG+0pnIeCzquemdBYAeHtksxon/G93OmEOfSLs0Rn5 omBDIdbuoYdjMu8JOgUM/7DN57SUltlYUKDk6Rntmb4IVYMD52zUzkVFYiWQkjVMi6WQ+i z78vmVrE7lYg4HQDWfuABKUMQCP4wgs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689256620; a=rsa-sha256; cv=none; b=OuKa7V/LrQ+lVOdNtrJJEBSp5bX1vg96zz5Cjrg10dGmq22R4rZUgepa8WUAgEVP4Tn8CQ tlASRI1F8Wb3M7CMleRS5CfqHsSa1EVDulUoViyXmQDMgxbLctkAB8oJ5c18WCZ4xqBD9Q WSMMYtMff8F6BACmPSHVsj1bmxWDCAg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HwW7Jwqa; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689256618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u7slRFqXzj+fIwUfWpHgJOEMlp6jejIeFSooLIetSLk=; b=HwW7Jwqa2r71T1Jfa2HUwMdSDgM2pBkbWtfs9hSGIJALK2cPCUFfNQk/7srZuD1LtMHVbD XnUP2x+fiAoApjhiWyLZOlSVLWtX+R7lHxqzhVEKniWRxZTHNblhH/mA8uss2HZjTSmOZS SMC4bFB3keHfXy1ay4tEwslk3soy9c8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-152-qrOhZEElPNeX7ZQ5mNA6Og-1; Thu, 13 Jul 2023 09:56:55 -0400 X-MC-Unique: qrOhZEElPNeX7ZQ5mNA6Og-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fb40d0623bso3376975e9.1 for ; Thu, 13 Jul 2023 06:56:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689256614; x=1691848614; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=u7slRFqXzj+fIwUfWpHgJOEMlp6jejIeFSooLIetSLk=; b=BbdYw9KVunuRMEuFqgBVctX2dLM0vTYjBQkY3YEmhO+JYpH2ZfSoOgUSTMKvCSlo0D g+OCb7eghdkmW0XoXbVfmbqUtKglp5IYk0etmojPpQEwCZ1GtT7WKO1kXKXjUPEzc5+Q 0vi9J06Hip+r1BslIw9QmJIvdkCzDblBdmufuan6iGIoU+9camurPs5pMb91Dk44f36T Za2qM1YyEAZf8PLMtjPQj+HJEpA+PggwUtP0tOeFVe7crvz240gVQqYjKfcc96QYniC5 4FgM9Xgx8gFb0H0NMY5csZIWPSoB+7K1z0XwGrIZypPlnqFlKbcVAlzHP2CjyX47hPs4 m2Yw== X-Gm-Message-State: ABy/qLaU0JjSZqmox599jhUQbuUBVoGYy6craaPksLJ3dQMKDApenWw/ ZQLokHooL1XWRjQQ8vhcnd1rJPL6F9bT3WDliQYIyCmhv5n+YjJSF+dYa7RlR115Zx1lxSQEwZF GMdXg9w/czE8= X-Received: by 2002:a05:600c:5187:b0:3fb:b18a:f32d with SMTP id fa7-20020a05600c518700b003fbb18af32dmr4313869wmb.17.1689256614496; Thu, 13 Jul 2023 06:56:54 -0700 (PDT) X-Google-Smtp-Source: APBJJlE118GN9dvVisQic4LNU75RVuVsDjt1KGEsf35PRM3rckhrWuEAXEBr4f3RPD+JkiJS5nwlWA== X-Received: by 2002:a05:600c:5187:b0:3fb:b18a:f32d with SMTP id fa7-20020a05600c518700b003fbb18af32dmr4313854wmb.17.1689256614159; Thu, 13 Jul 2023 06:56:54 -0700 (PDT) Received: from ?IPV6:2003:cb:c717:6100:2da7:427e:49a5:e07? (p200300cbc71761002da7427e49a50e07.dip0.t-ipconnect.de. [2003:cb:c717:6100:2da7:427e:49a5:e07]) by smtp.gmail.com with ESMTPSA id q5-20020a1ce905000000b003fbc9d178a8sm18501864wmc.4.2023.07.13.06.56.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jul 2023 06:56:53 -0700 (PDT) Message-ID: Date: Thu, 13 Jul 2023 15:56:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 3/9] selftests/mm: Skip soft-dirty tests on arm64 To: Ryan Roberts , Andrew Morton , Shuah Khan , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Mark Brown , John Hubbard , Florent Revest , "Liam R. Howlett" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20230713135440.3651409-1-ryan.roberts@arm.com> <20230713135440.3651409-4-ryan.roberts@arm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230713135440.3651409-4-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 14AD010001E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: sgcpab9sckyqas7w5shq8betkry3dins X-HE-Tag: 1689256619-148274 X-HE-Meta: U2FsdGVkX1/sWM42ywJhlTXWhyus2ncPBudYFqB6kdksn51iByEEXfBz9i7ODG3CUtkPw6MoRlLX4iR10WZsk2YchAS2MqOQ+vRvBOCF3l58YbAmeXdNEwI+djUJp177tAZGkHObkipdOtcbBZ0j7DiUOwn7/KNOHZeBV8JnFHE8lPuovlScH7juEEJLd1Aw+4G1hdcPmBeG/je9yn+U+1odNu/ldHUAnc0da4AMdsGAKuEv8dDDJg++Vg0fao4w1Y4gbVQDRs6atXY82WFqypj9TQMvQ06CbaksiN5td8gVPxlAw7mzvgtiDJ7HI4niPJ1LS1iX+AxlIL8HaAssBryr3771DMcEaSniyCzewacc2JAD0Ij25ZgEszEP3DrnZDomiz+6H8vTd/2eB4RF3MvuT3iburz6W3fkez3bQm7l2ZT/+x97pAhLrJU3rStoJrnVMBRTguJqLrlZ8Enhdc6Kfnr2nC95Gs8a6+KCmKf4BZtjFWF1CyXypeP3zRPvVUeKHGHMFrHT9+unStPBz+SuxWsIbh3lI4Ep6R6gry1Bq+N/qsFf4TRV51Xh56vhZdrvWBHmxqMkE6ZwJEWfSzBde9hqtphH1KPvRjKRav3o5U46tvCl5ERzFhM4UJRyKSE6C1Nv8RydOgJfq7lHMWiGHfFzz0yj+4mcVnTEhIrryrzUt+x1ghKjUTH1IRRUZpSwPQdkYY7FE5wfKMDplCECXkvjqoM4StgcFf7nwKdvlbKAobOlGPL1bAVEitOcCuoAiIwXNZcOIrXQEMItd1E4LPvgih8HG5TTahIUQsBP0OC0mpfpqul/gHbJilFfmrC+PX/LRRRAuHqVe8pM0dHf5RnnwXfo42+Chy2BSTwX4deY6tZPYgxlWwa2lZjjYGxVD4DlmfmfyPjpTFWPRYnbENv2OZ5Q/5MIXjc4d67PLgqJ4d6ZPjg32ySERuu8/pp5MKUWx/0yBkjEPlv igBh3qve sn0ZCCCkmTGx8sIumOroYwj5Ks1syrMmoWK0JeFanBHYhBU4iTQwUsY32nR4BQIx6rI3A5wGtJlXKz4zt4XkNDKdzc8mGL402aFwhHv/yMaTp/WetDcvGAGfxPqfzPP3OkcWUN6JywsC89hG8F3PD/Yk0NAlRF49PvHcZ/PGNWDAci4GfcOEzrtncbwTvoExnQwBRhnJqiSlemui6/RpKTbri9BBrYW6dISF1AzUDgNeYNzK8VyPLSy0BwpohjKIdoa3y3sOTSEYpnkJKdCu2kdFKxeeaNCXp9GWP7i2pAS87xLXS4XA0kftGsvo5F26pQOUPvJlyDE8T7ryxpSm5fA4P/8rSIC6+bPGgATv541edxgdgJlz8vINDQzyxwv90G6NeBY2BJ/CNVqe58trwx7Qukgb9n5UNQcGqyLgkuzbbus8SfVHrsHLXgbH4cif1U/lI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.07.23 15:54, Ryan Roberts wrote: > arm64 does not support the soft-dirty PTE bit. However there are tests > in `madv_populate` and `soft-dirty` which assume it is supported and > cause spurious failures to be reported when preferred behaviour would be > to mark the tests as skipped. > > Unfortunately, the only way to determine if the soft-dirty dirty bit is > supported is to write to a page, then see if the bit is set in > /proc/self/pagemap. But the tests that we want to conditionally execute > are testing precicesly this. So if we introduced this feature check, we > could accedentally turn a real failure (on a system that claims to > support soft-dirty) into a skip. > > So instead, do the check based on architecture; for arm64, we report > that soft-dirty is not supported. This is wrapped up into a utility > function `system_has_softdirty()`, which is used to skip the whole > `soft-dirty` suite, and mark the soft-dirty tests in the `madv_populate` > suite as skipped. > > Signed-off-by: Ryan Roberts > --- > tools/testing/selftests/mm/madv_populate.c | 18 +++++++++++++----- > tools/testing/selftests/mm/soft-dirty.c | 3 +++ > tools/testing/selftests/mm/vm_util.c | 17 +++++++++++++++++ > tools/testing/selftests/mm/vm_util.h | 1 + > 4 files changed, 34 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/mm/madv_populate.c b/tools/testing/selftests/mm/madv_populate.c > index 60547245e479..5a8c176d7fec 100644 > --- a/tools/testing/selftests/mm/madv_populate.c > +++ b/tools/testing/selftests/mm/madv_populate.c > @@ -232,6 +232,14 @@ static bool range_is_not_softdirty(char *start, ssize_t size) > return ret; > } > > +#define ksft_test_result_if_softdirty(cond, ...) \ > +do { \ > + if (system_has_softdirty()) \ > + ksft_test_result(cond, __VA_ARGS__); \ > + else \ > + ksft_test_result_skip(__VA_ARGS__); \ > +} while (0) > + > static void test_softdirty(void) > { > char *addr; > @@ -246,19 +254,19 @@ static void test_softdirty(void) > > /* Clear any softdirty bits. */ > clear_softdirty(); > - ksft_test_result(range_is_not_softdirty(addr, SIZE), > + ksft_test_result_if_softdirty(range_is_not_softdirty(addr, SIZE), > "range is not softdirty\n"); > > /* Populating READ should set softdirty. */ > ret = madvise(addr, SIZE, MADV_POPULATE_READ); > - ksft_test_result(!ret, "MADV_POPULATE_READ\n"); > - ksft_test_result(range_is_not_softdirty(addr, SIZE), > + ksft_test_result_if_softdirty(!ret, "MADV_POPULATE_READ\n"); > + ksft_test_result_if_softdirty(range_is_not_softdirty(addr, SIZE), > "range is not softdirty\n"); > > /* Populating WRITE should set softdirty. */ > ret = madvise(addr, SIZE, MADV_POPULATE_WRITE); > - ksft_test_result(!ret, "MADV_POPULATE_WRITE\n"); > - ksft_test_result(range_is_softdirty(addr, SIZE), > + ksft_test_result_if_softdirty(!ret, "MADV_POPULATE_WRITE\n"); > + ksft_test_result_if_softdirty(range_is_softdirty(addr, SIZE), > "range is softdirty\n"); We probably want to skip the whole test_*softdirty* test instead of adding this (IMHO suboptimal) ksft_test_result_if_softdirty. -- Cheers, David / dhildenb