From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D6B5C636D4 for ; Tue, 7 Feb 2023 17:10:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F29526B0117; Tue, 7 Feb 2023 12:10:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ED9976B0119; Tue, 7 Feb 2023 12:10:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA0DC6B011A; Tue, 7 Feb 2023 12:10:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C71946B0117 for ; Tue, 7 Feb 2023 12:10:18 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 795D68083F for ; Tue, 7 Feb 2023 17:10:18 +0000 (UTC) X-FDA: 80441134116.04.D16C2AB Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf20.hostedemail.com (Postfix) with ESMTP id 77F4B1C000A for ; Tue, 7 Feb 2023 17:10:15 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JWBKD3zE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wSmncD+h; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675789815; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xqgHSvZVuaq+v+IH67EMkppDRKeF2E4q4iKhI5vfsLs=; b=kG/q3rw9p9kyezfaFkGPpbQiBiolWhhqkq/KQqlX/m/TkjoaKu0oIsao1PplYpuHDjgNH0 XQda+t6TpekQgkmMIFILi2h4dk35Sic32oj0//4GN1hlTzywIYuAJ9XkLYwXHyl/KkqNZ1 VQ5DwI2z5QcgxfQ0MnRSeOEqsCKyvDA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JWBKD3zE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wSmncD+h; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675789816; a=rsa-sha256; cv=none; b=5LAtIqeNlh+AadVtsHt5K8pO0wSQbGb6Q2+6Opo1ucZrQWJ5usZ+eFbQjoUd7Y1rU88DEg 2CXXL2ynQXs4smIFbCD2x35LyQVlj5stie+B2hbF2Rc7TvRpmdyPNqm2lqQOOvwaaNs5rE UheNG9f4IG1usNICiXMoxnnHnrF3h7s= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 13075200F5; Tue, 7 Feb 2023 17:10:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1675789814; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xqgHSvZVuaq+v+IH67EMkppDRKeF2E4q4iKhI5vfsLs=; b=JWBKD3zEhW9u5PTpMzNIu5j3KMSTM70D3oiK4riBRNbi68OWFrAZfwTt7ul4ba6YxAqYkY ZAhBr9G5gBFzPbkOmd2MWl+dbDGhbs40pL26JnFvw9l9MUvUMO+vZBxAwb/fwCui4yovzH ruIh4pRAQEX2ZaavPUUHBRHd8l36vKo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1675789814; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xqgHSvZVuaq+v+IH67EMkppDRKeF2E4q4iKhI5vfsLs=; b=wSmncD+h99/IocMDuo/nxBQbi5BfdRLwWaofsg2xub6KDx+ougC0aeAtyBqe9i7T1q2959 jYGeV9sE9pgNS9BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E06C613467; Tue, 7 Feb 2023 17:10:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cSEiNvWF4mPMVAAAMHmgww (envelope-from ); Tue, 07 Feb 2023 17:10:13 +0000 Message-ID: Date: Tue, 7 Feb 2023 18:10:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 3/4] mm, compaction: Finish scanning the current pageblock if requested Content-Language: en-US To: Mel Gorman Cc: Andrew Morton , Jiri Slaby , Maxim Levitsky , Michal Hocko , Pedro Falcato , Paolo Bonzini , Chuyi Zhou , Linux-MM , LKML References: <20230125134434.18017-1-mgorman@techsingularity.net> <20230125134434.18017-4-mgorman@techsingularity.net> From: Vlastimil Babka In-Reply-To: <20230125134434.18017-4-mgorman@techsingularity.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: xrqek5j88zfmugowmeizaw8bmptptmkm X-Rspam-User: X-Rspamd-Queue-Id: 77F4B1C000A X-Rspamd-Server: rspam06 X-HE-Tag: 1675789815-626824 X-HE-Meta: U2FsdGVkX1//McZ2Q6K386rYYq37kSv75RGmffqV0HNM25p7yEQoZKoPJD5KHn2pfJKoRvdqwYOje72dXFHWmhGwX9AlaLgcnk9s0PJrwp66gEENue1L74DqcGXQKvZMwahYwG07u/LVi5/pDKFlfpPxFxgeWkvEzpYqrHSY7GOiqXG7P+xiWU2QSqnxEGDQ1vDYSLqXkAW/W9gS9YrvOFjBDNlVRifQKAlqVNF8k5xCfgziGq6Rm+OXrr9J7yKLlPkpb3AiKJQoUHug+35acYrrDk+xdmbbHR21E3Qsjw3lS+5ZSRAo/2HPJicmPxtx41ia5P99Ms7Tn+EfngVRBlo7w5O43Jz7Hh6zpEdNPz+N5N6TDIRpa0nKEBZgQGFDW9JwUOy4ncyZVs3ygEhxdLL3I3Ozo6E7a14tlMZLStw5VjRR0QvZplAPF1y31p0mdxJ9R0lRPU6aZKt4nrd/R5i7LtfKLkh7CcImn25yZJ/7VhpyEdfHBsbIcJ9qS5urmf/cu/7+qk4m1RmRqE75VFMBVwnKf2hAxNCOcjB+haXcwfcnXyB1UF2VgAjVISv09mFupSTlOyFoab8bpbWtchS6fFp70VQOAZsEXTt86GdeqVMknN1nONuwkM+ucZ20EuXTEQYCYYiDzZCb3auV4JZIOlNVcVSQiGa3vmBJNzU7jCJglUgfzgkajzIZXeJbJbp0h4rNPDqAgV7CEq2Q3eOfRKun2qxoRFJ9ZnkKQtjppUe3TIIkaqBu5uigrBJgUWQqR+JQoFFRNdqwFa8RLPgHQ0PNJw99pNCOQPenN58XnLyBkkuvzJ2p2wemy7djrOSwz0g/imMZawrZTmFjiqJ/AjyKMQ/sSVfgh/6+NSxu/8VBeT6itfRRKIDj+csZUcczjXhVMfy19AJXLR5FPk2mh+cXcamcY+T5h88RgtE5byehPunAeQtyI60sfiAjP+dpU7seVsg3svZl0Rq sxCIKhts Uyvoas+79XVJYpvmB6RFxbzGXJG5hiaAi75zQZrjNzBhKmKEYZ2yKiEb1/U69fro1j5rVRorQCG3UYBV9Nih36AXp20UGncPpJ9QLaNBf1fr1Z2h7Yp+HFYrDqlilYmgaTyeV+zsHNZweGCwXQOJThixAgqekXhKxoyR4Dq/SGX5va0TF+WJ0JBOppb1BhoMGfhInd4mk25AfOi6L7tPY8VjaMv8qmxZvoZdKiqh5Vn3xu6i1qYHNJP4ao4/eP6mVKxLwNoXykdH5oKzdwa+8nlGGG4O0TYhXnr4E+1tvmf2MnvGIaJ5/IOgLiOR0phbshzLUxUJAzVW7kxTpQhYihH7BXQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/25/23 14:44, Mel Gorman wrote: > cc->finish_pageblock is set when the current pageblock should be > rescanned but fast_find_migrateblock can select an alternative > block. Disable fast_find_migrateblock when the current pageblock > scan should be completed. > > Signed-off-by: Mel Gorman Acked-by: Vlastimil Babka > --- > mm/compaction.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 28711a21a8a2..4b3a0238879c 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1762,6 +1762,13 @@ static unsigned long fast_find_migrateblock(struct compact_control *cc) > if (cc->ignore_skip_hint) > return pfn; > > + /* > + * If the pageblock should be finished then do not select a different > + * pageblock. > + */ > + if (cc->finish_pageblock) > + return pfn; > + > /* > * If the migrate_pfn is not at the start of a zone or the start > * of a pageblock then assume this is a continuation of a previous