From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7D4CC001DF for ; Thu, 3 Aug 2023 13:00:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FAB3280247; Thu, 3 Aug 2023 09:00:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AA8428022C; Thu, 3 Aug 2023 09:00:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 372E9280247; Thu, 3 Aug 2023 09:00:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 29A7328022C for ; Thu, 3 Aug 2023 09:00:46 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DA0871A1131 for ; Thu, 3 Aug 2023 13:00:45 +0000 (UTC) X-FDA: 81082802850.21.E22D6DA Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf23.hostedemail.com (Postfix) with ESMTP id 4AFB114002E for ; Thu, 3 Aug 2023 13:00:40 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=hFey5S88; spf=pass (imf23.hostedemail.com: domain of phind.uet@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=phind.uet@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691067640; a=rsa-sha256; cv=none; b=3Xhp0YttQZtz9Utxh9SBJBy9hi/3BDyqbjYbyMM3TXoMVo2JhZ8bOwZdZffJCix0iDQE9b RPoagFBLlpk5/ey3zBQPzLcXPjz+qnJTUywwwluOjZ9qKQgP/QCxqNc1+QBiqD5R96Cd83 DL3yj+M48qvMiJ3n2/9rNUFpDZf7dj8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=hFey5S88; spf=pass (imf23.hostedemail.com: domain of phind.uet@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=phind.uet@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691067640; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ne4TLOkbOjf1MkMkI08KdCgdWtyARI72DRJ1ahPA7Lg=; b=up4gyMmfPbnv/Xy+ODHIdaqMQalyvqyBcBTRKghhmx60WFP5TGEGA+Y8Gw0X7gxvzW1qQR bhUvohmVFroKveJVzWzfDfVlH4jhY/cpwdK0e8LYPVRSzzhYWdBsXtozvq1wtwHv1BuoWa 0Wkr7oGFrF5SBTuZmobVplxrYij0zdU= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1bb9e6c2a90so8191135ad.1 for ; Thu, 03 Aug 2023 06:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691067639; x=1691672439; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ne4TLOkbOjf1MkMkI08KdCgdWtyARI72DRJ1ahPA7Lg=; b=hFey5S88VtrEj8gHmZzWxck98y+If6caA2T8qnAZkJ4duvjNkDzWWvcFEw/uspdv1X wD909xuUDRoQrQNpiHSLdRLZFriZDRvwOiKmkduwJ/kahZ22t59tHpZak9YzHIedp9hg 4exCm1UfhAwy9Geeh5yuFeA2Wem+KZowfiT7EVhdWDgjjUaVbE8nV8fXdufVzS2h5dcH lKahNstvLkEJSry6FNlRSsneeYNI7kFkzZTmeU1O+VhTC7eYPGgFf1w1Re/dYov6Ox9I NzdEyNEL1gV6qv2uPri+ROXf0dRLmwYIOOjSZAra0jXjh8NQZabvgjARx8v0dLaz/64x Ij+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691067639; x=1691672439; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ne4TLOkbOjf1MkMkI08KdCgdWtyARI72DRJ1ahPA7Lg=; b=k2YKWaCDEYzRZr7YhLgNKwVXrG5q6F6jy9XGOBZbUkwnb5t312GBAqua5aUcr7YUmD DfdgYl1CH3gt9DMFcJD6H7FSwfCQ5lz95CxSdD8dUG0A8HvAdPXSJhVDUgYpCFRWBd7Z KwxWi0G6c93cjNpTR9BrnZDAL0WZbNH4D3Z5Dg8hBOfF+Tc4BDnlXW2KxOMzIH46676t DqjwbDyKnqPNJIk7P3kiEBuT/bDh/VYWGm+fOsNLntCOOmzioU2FF9vz96ydp/C5se6b uPw2naCC5B1s9UDy6Yyxdcs1VkHjLuYUgCiVZKOF0A1VwN47NPUvjefli+UVn4N9tQur tE2Q== X-Gm-Message-State: ABy/qLa/0iEwapoWqZb9d5LWP5c4Z/JOd8uQPoLR3N5k3oY9B8BrNqh9 4yGwbd8+akFT14OwXkBsT1A= X-Google-Smtp-Source: APBJJlFjk8oBOgHwouxONCLHTACkD4p2a6yaYuNz3BKom3qdfdhJRvnnBf3GbKpUGgyT1J5gs6W8Bg== X-Received: by 2002:a17:902:9045:b0:1bb:bbd4:aadf with SMTP id w5-20020a170902904500b001bbbbd4aadfmr15609107plz.61.1691067638758; Thu, 03 Aug 2023 06:00:38 -0700 (PDT) Received: from [192.168.1.100] (bb220-255-255-44.singnet.com.sg. [220.255.255.44]) by smtp.gmail.com with ESMTPSA id iz20-20020a170902ef9400b001b9ecee9f81sm14369433plb.129.2023.08.03.06.00.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Aug 2023 06:00:38 -0700 (PDT) Message-ID: Date: Thu, 3 Aug 2023 21:00:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v6 01/38] minmax: Add in_range() macro To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230802151406.3735276-1-willy@infradead.org> <20230802151406.3735276-2-willy@infradead.org> Content-Language: en-US From: Phi Nguyen In-Reply-To: <20230802151406.3735276-2-willy@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4AFB114002E X-Stat-Signature: mn7y5kubfu514uyx1db4dngsdyo8cm7w X-Rspam-User: X-HE-Tag: 1691067640-43632 X-HE-Meta: U2FsdGVkX19mRBXSeuBIIT52lLoYCVtCSmOV+mkd3E3PGpa5hKipxmevjxAHsGvLZ6iGwWnubtpIebvE+VKY8dRJoJSOBu84c0FM76Jps9Taqg5iumZiArVwHwCzlUcL9XRseI0GclLxjN46QvrHgtBv/bpBTasZL9j95KWu02goNaYYY/07hpnTNbNfThF9SkAGUk51CLgUSvNVCJKt95Q3QjJvJlW7QF6TwQWu5ctlT42IO4QGNW+bmYnwsNmcDRkeUqEegJUKDiqtm2U35RGLywKVSyGljndhbH+x/p0SuzbeBrAd9Tqn2tEbEc/siqa72Gfh0/+0M9BaTr5V2kdSZ5nFPSLGlLX6S2dBmdNn6WPQLYl2F/Tv76grdPTxDB9P5Fu7c7kJGSBiT9Nd6nDLvQTPKIWTvIVJWEB00FUDWDpE7TQWbDteejUQbYqKbiqGCK5U7TDna8rv0Na+7wAZmzbSD6aIwlVNDzDXD3soG20bTQOTPN1hO4/2MFrogE1lctHj53urHbS+XqBgcVa37oEjfk8y3iNrq/6w4W/ZHsQNlUy2H/uMYPzRgVAV5lnjm61NkEJtpXLZdu9W18PJQ7uKEiL8ZZjyppqy1yELYKzpu80aiQgHRxUAJreONBfdXHuT3zgsDeZAkp4IrzPm1C0q1r9G+AL0GGiw0j1133oe9IAMTWvicYbe4pg4Q8S3GDRvd1CYHdnOO9klQGK01OHh8rm8E+E36RsQPfKF0l6owza+L5yf69l8qbSIp59iQ5GMe3R8RuFf1MsqxuI/+OYWCdIgRsJlVCjduNxF+RwRlbVekIl26zvsDkv3YY9H61g4xfHKSbAR74uwQSxBRBN2PJ/rSd6lYDgiycmS6Vu6nf1lAiB5IeIyAPiAQh6nEivocXfMAwwOCC2Bj979CvCDb3gDqkAmKzZ+79My7qmyl/CBdUKhbqLz8hDq7cwa9S9QlQScpKZCjz5 Qe++x85C qK24TdDQngBdCqKIXDuC0vQbcFjWM+Nvl5DSrQpwkfmfq0GEGi6yqypSF/MCLyalS+MM1S1o5KeEcy7CiU2gJgk+nzGaKQMl9EG9pgEy3Gu5PKuZ8XhBQVuz1ZGIoJhKoZJzclXbWBh+6fZDfu3eixu83G/a431yxwTaFMATqID7AlkCDSShK2HaYg33UBJcrDoAPr3po/qGHsFGIBGozqbL8vpzAZquyqLwQlyvH/VNChlR4RsUmWiTcvfExcJZTk5ETwUzp9pjnASZY1XrtChXB58mtRfSr+DtUaYYdGlBBYBypfOYqOvptFFHIKZ6lkUG2osuS7gy+1AEKNdvC1qMQF/mB88r13g9vfM1u9T8fEKj6CIAvxWA5YL6HZ7T8e/tZJZld9qwx6hsQS1Dwxrwaw/tKTXHmzCfL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/2/2023 11:13 PM, Matthew Wilcox (Oracle) wrote: > diff --git a/include/linux/minmax.h b/include/linux/minmax.h > index 798c6963909f..83aebc244cba 100644 > --- a/include/linux/minmax.h > +++ b/include/linux/minmax.h > @@ -3,6 +3,7 @@ > #define _LINUX_MINMAX_H > > #include > +#include > > /* > * min()/max()/clamp() macros must accomplish three things: > @@ -222,6 +223,32 @@ > */ > #define clamp_val(val, lo, hi) clamp_t(typeof(val), val, lo, hi) > > +static inline bool in_range64(u64 val, u64 start, u64 len) > +{ > + return (val - start) < len; > +} > + > +static inline bool in_range32(u32 val, u32 start, u32 len) > +{ > + return (val - start) < len; > +} > + I think these two functions return wrong result if val is smaller than start and len is big enough.