[PATCH] memcg: code clean,rm unused variable in mem_cgroup_resize_limit

[PATCH] memcg: code clean,rm unused variable in mem_cgroup_resize_limit

[Bob Liu]

Variable progress isn't used in funtion mem_cgroup_resize_limit anymore.
Remove it.

Signed-off-by: Bob Liu <lliubbo@gmail.com>
---
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 984cf27..9d4776e 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2100,7 +2100,6 @@ static int mem_cgroup_resize_limit(struct
mem_cgroup *memcg,
 				unsigned long long val)
 {
 	int retry_count;
-	int progress;
 	u64 memswlimit;
 	int ret = 0;
 	int children = mem_cgroup_count_children(memcg);
@@ -2144,7 +2143,7 @@ static int mem_cgroup_resize_limit(struct
mem_cgroup *memcg,
 		if (!ret)
 			break;

-		progress = mem_cgroup_hierarchical_reclaim(memcg, NULL,
+		mem_cgroup_hierarchical_reclaim(memcg, NULL,
 						GFP_KERNEL,
 						MEM_CGROUP_RECLAIM_SHRINK);
 		curusage = res_counter_read_u64(&memcg->res, RES_USAGE);
-- 
1.6.0.6

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] memcg: code clean,rm unused variable in mem_cgroup_resize_limit

[Daisuke Nishimura]

(Added Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>)

On Mon, 7 Dec 2009 10:37:24 +0800, Bob Liu <lliubbo@gmail.com> wrote:
> Variable progress isn't used in funtion mem_cgroup_resize_limit anymore.
> Remove it.
> 
Indeed.

One minor nitpick.

> Signed-off-by: Bob Liu <lliubbo@gmail.com>
> ---
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 984cf27..9d4776e 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -2100,7 +2100,6 @@ static int mem_cgroup_resize_limit(struct
> mem_cgroup *memcg,
>  				unsigned long long val)
>  {
>  	int retry_count;
> -	int progress;
>  	u64 memswlimit;
>  	int ret = 0;
>  	int children = mem_cgroup_count_children(memcg);
> @@ -2144,7 +2143,7 @@ static int mem_cgroup_resize_limit(struct
> mem_cgroup *memcg,
>  		if (!ret)
>  			break;
> 
> -		progress = mem_cgroup_hierarchical_reclaim(memcg, NULL,
> +		mem_cgroup_hierarchical_reclaim(memcg, NULL,
>  						GFP_KERNEL,
>  						MEM_CGROUP_RECLAIM_SHRINK);
Could you merge "GFP_KERNEL," to the previous line ?
It can reduces 1 line as a result.


Thanks,
Daisuke Nishimura.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] memcg: code clean,rm unused variable in mem_cgroup_resize_limit

[Balbir Singh]

* Bob Liu <lliubbo@gmail.com> [2009-12-07 10:37:24]:

> Variable progress isn't used in funtion mem_cgroup_resize_limit anymore.
> Remove it.
> 
> Signed-off-by: Bob Liu <lliubbo@gmail.com>

Good catch! Please run checkpatch.pl before submitting with the
changes recommended by Daisuke-San.

Reviewed-by: Balbir Singh <balbir@linux.vnet.ibm.com>
 

-- 
	Balbir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>