Re: [PATCH] memcg: correct return value at mem_cgroup reclaim

[Bob Liu <lliubbo@gmail.com>]

On Sun, 6 Dec 2009 22:30:46 +0900
Daisuke Nishimura wrote:
>
> hi,
>
> On Sun, 6 Dec 2009 18:16:14 +0800
> Liu bo wrote:
>
>>
>> In order to indicate reclaim has succeeded, mem_cgroup_hierarchical_reclaim() used to return 1.
>> Now the return value is without indicating whether reclaim has successded usage, so just return the total reclaimed pages don't plus 1.
>>
>> Signed-off-by: Liu Bo
>> ---
>>
>> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>> index 14593f5..51b6b3c 100644
>> --- a/mm/memcontrol.c
>> +++ b/mm/memcontrol.c
>> @@ -737,7 +737,7 @@ static int mem_cgroup_hierarchical_reclaim(struct mem_cgroup *root_mem,
>> css_put(&victim->css);
>> total += ret;
>> if (mem_cgroup_check_under_limit(root_mem))
>> - return 1 + total;
>> + return total;
>> }
>> return total;
>> }
> What's the benefit of this change ?
> I can't find any benefit to bother changing current behavior.
>
en..I think there is just a little unnormal logic. The function
recliam total pages,
but return 1 + total to the caller. I am unclear why do this,it have
no benefit too.

Anyway,yes,there is no benifit of this change in current code.
Please just ignore this patch.

> P.S.
> You should run ./scripts/checkpatch.pl before sending your patch,
> and refer to Documentation/email-clients.txt and check your email client setting.
>

Sorry, I registered a gmail and hoping it will be ok! :-)
Thanks!
-- 
Regards,
-Bob Liu

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>