From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A792EC6FD1D for ; Tue, 4 Apr 2023 10:57:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3199B6B007B; Tue, 4 Apr 2023 06:57:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C9246B007D; Tue, 4 Apr 2023 06:57:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 169476B007E; Tue, 4 Apr 2023 06:57:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 06F966B007B for ; Tue, 4 Apr 2023 06:57:01 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D5A2A1C6A9D for ; Tue, 4 Apr 2023 10:57:00 +0000 (UTC) X-FDA: 80643406200.04.5F36AE4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id B071B14000A for ; Tue, 4 Apr 2023 10:56:57 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eDFiacbS; spf=pass (imf09.hostedemail.com: domain of hdegoede@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=hdegoede@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680605817; a=rsa-sha256; cv=none; b=tg00HTk+wEE3bC665mDK5pY+rMSPhLSWvxrZbVzF2lt+qUpQJrgdweIVjKVnL6AB5mQQvr I95h6J5YIqJYR9VQ5UGGQ72RS3429xDmGU+TbQXeQN8zEbG/Zl4ENGVhRjT7JX2tMvkW+d w1RPLq1lVdsgo8Iu21/TVXLS+gO+qUI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eDFiacbS; spf=pass (imf09.hostedemail.com: domain of hdegoede@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=hdegoede@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680605817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5FYgqkX3L6SS1bKKJ+GvTFOSuErZfN9BpiIAzISlufY=; b=0LoXQWqCotRKBA/jgUc7dkOQI/BwXs/rJOJVrVyLrQY3QlUIH9lnz3mWB6FeQQITC4UqKV wH1cirJ7T86+qXjYrqWn7T67gJ3FtM+4YSebtLgwGs8IFA/mrwdj334ovOl4t2ElUt6mbk +FIYl68+I/+3itC7u0f6s+lS1ItiYvc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680605816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5FYgqkX3L6SS1bKKJ+GvTFOSuErZfN9BpiIAzISlufY=; b=eDFiacbSl1dYsckfGru65BZnSOGF9/r5yyTZYSysYXLyCCtE3DnnTUm/ZcdXo8DMg+xM9b mdt690O9j5yhYpLLBFzIroUvOeyJux+hg8W8sQHX0AwnQBH0GKklKOPRx0tBB16EZOoSh+ +YDf2iU3qALkpYI9HQR/NIVsJ5yPbj0= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-3s09JBa-Pnad9IgXoySn2A-1; Tue, 04 Apr 2023 06:56:55 -0400 X-MC-Unique: 3s09JBa-Pnad9IgXoySn2A-1 Received: by mail-ed1-f71.google.com with SMTP id a40-20020a509eab000000b005024c025bf4so33300028edf.14 for ; Tue, 04 Apr 2023 03:56:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680605814; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5FYgqkX3L6SS1bKKJ+GvTFOSuErZfN9BpiIAzISlufY=; b=5qGlD5K0cCnCsNDpdDHBf/NXb7b3k5Hs4c/Ym6bIAMM/bQWFdVSL7gJwfYCa+jOOiG flPaZKn5WYB72xzJRiIKbl3+wJxoYD4pPj0lwc5f77TWHP07ZVIU4O8gkeRWKcsGzrW8 Ttm/uOgPOXz356i/ZFsqnR8qDrVgCNPZZQII9+HZGPQz7hQcZRgGD6l4Gdq+SkYCxbLP XbFxfUb4fbKjt9hnRFhwydHWdsD8XArDvNt/o52Rl48pTOKfGDCVdu0nEVdMK9hpYIRE LDQWMRkSMX6DzfQlhrTTEoRrEPIgj/7ccLtiMRUJ6C2brDQkrbOTTGvbe2QLgOrLapr/ NmHw== X-Gm-Message-State: AAQBX9ecuea7rMDyuSPjH66GPCE5Hi0qaQLN3Zof0jUnUMLFKp5uQsJv YsnnP/hG85X3BYdVLqXQL1vu5LmoT6BPBP1yNIJwlEryaEbbRL99Cfc9A3DOw3rtiUmz9R801ky 9HkY4YS5nsBY= X-Received: by 2002:a05:6402:1a46:b0:4fb:6796:14c0 with SMTP id bf6-20020a0564021a4600b004fb679614c0mr2170892edb.22.1680605814361; Tue, 04 Apr 2023 03:56:54 -0700 (PDT) X-Google-Smtp-Source: AKy350b//cnshzfKnu+JxIFi+BgHdznYalW1MBbKckx0B8bWkF0dzB3qofZUxVqCWanZRn12VumHxw== X-Received: by 2002:a05:6402:1a46:b0:4fb:6796:14c0 with SMTP id bf6-20020a0564021a4600b004fb679614c0mr2170883edb.22.1680605814119; Tue, 04 Apr 2023 03:56:54 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id o18-20020a17090608d200b0092973e209f2sm5824454eje.109.2023.04.04.03.56.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 03:56:53 -0700 (PDT) Message-ID: Date: Tue, 4 Apr 2023 12:56:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: sparse false-positive ? (was [linux-next:master 3256/8744] drivers/platform/x86/apple-gmux.c:224:48: sparse: sparse: incorrect type in argument 1 (different address spaces)) To: Dan Carpenter Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , kernel test robot , Orlando Chamberlain References: <202304040401.IMxt7Ubi-lkp@intel.com> From: Hans de Goede In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US, nl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: B071B14000A X-Rspamd-Server: rspam01 X-Stat-Signature: kdteenoxn1yfnebei839hrzrpyoxa1t3 X-HE-Tag: 1680605817-823112 X-HE-Meta: U2FsdGVkX18Q8yM5/beMRj0lcqZbUewW5jnFvCBoVM2ArpTlgr83NJFUJNQGXt7/7whU2XliPk31wwJ9T0zEbvBxA2BGhzfUpiIm8UOH8tteybySQpkj+jVGM1cy16JYv7ULV8SV/nVZwtoS3u+9OL/+bU7/Wzc0GdDUleApHMXFtrYlrzxyTkarwTlw7Q+LN5VljLKlTtHMY4Bf4/UZIlclzj5TeWvvlnq4tezkAOez4LQBNmeOzZ4S6EGbMBL2B9pJtxnE5HO5trsnBM36e3eoRA95iX/BCXZkXqkJr860Zl7lMlTie90rXXz2f+Bepb9oCdsZfmCAcNlVB9/WJA3G354oWG4khU5ivGaAf2KZpIJ6Kv7beRM+co2/ms3nVyNbTEow9Ze+WEyeHIYrlI4oFMYfAN8fgf+bzJBOAv8WpAvG1c5i+AtNBKDqwnlkucSzGwT6Pw/IXcWQ8pVn2m1l/xQ/JmJEnQffsidHsZAWy+kMrIL4lPGJr/XcbktlvjX7Mdd4Mv2LDezt07JUK9sz1gIGxBjos9XiODHhYWt0YE3Z7vTG05/zwf5Jg3oXJALIDAF66Wbp0ScuEMFAB173OqdFgpFtngCVa7AwFkTbCQy2jpgwHEeBihyrvtLc3KE5jEHESJmVG6DccJAQJYDVUkansbp9CUppi22xOpSvTPOPhKeOOGcJhpVztyMZnIkbS9ySKz1qjWV9M1gT5VmU9JzfQm/ROCKso33t79BgYQJfDLU7HHwydNogcsXGlIVNN2vbhdEq5z2jSdXO/yP6ggMDrJaCChGFXAwwY0ee5PCa1fYEDMKIYmrcKDfa+erFptcGqUay1oPocYLRMo5v4Pi/pnqSJyNKJPjfodlrjvji2mi3hAER9vLakZudTqfoCkgF8iCoJn4YUeQdpmVsu/HktDZ6TR/CUKy7k0hDCHJJNMsiXlBOYPL/XZ3IrnvEci+OhI/U7HOu0kC lvL9P0pK +MVo1jCJxH0Z9FriTmUBNMgnU+AGJuHPUiSaWxAvzVZrkYOGcmA7HIFmGtPgAVVv9pr1ao9lYuZptQ3Q2krCQlx4WX9dfcNAcrs38/eYcm0Klwi+sYwOwELywEWNMN7IEva3bN0Jpem4kchzOXmmT2UGJMwocUharIt72RzF1JAFOTMcvGsY+j0BouwsuceVoK8jJlRGk6apEYRLo2/klSYkIXSayltF2FDy0ePgHTN+AbBwqEQcxK430j2gGdoLYS3cYEbIcxoJBWrGqLD+sNsQUwzKLwJc+sKbqpWz/wO52aVkYg8jpUjKLPWzV+xpGcDrvnsPcABOvuKVp1kBTZB8N5NV0M5eHHgfpSJIL87g3U+7j+E2rXYXEJN5lIlwl0Wm+Kk/XfSZjNHBG/Cga5MkxhmekVBrrcDrngBzQIuxFfS4TZn3QZqEU9jHXdBEF6PAqMWIIJq8rfBRiCU730DnoP2B1uCAMPXnw9gfAHiwjJlL03vTJguU5RlNPbq+1ezlPSepCwgSMLpcRVqkQrVYXYBnybKwUlE1kzCYqwMRe/7qFszu95zZzvKA3XG2xjpvf7rdjRJeFB7BtaWwInPshXyD/C73AAjDQb752vUK2UAM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 4/4/23 12:07, Dan Carpenter wrote: > On Tue, Apr 04, 2023 at 11:50:17AM +0200, Hans de Goede wrote: >> Dan, >> >> Can you perhaps help me understand the following sparse warnings, >> they seem like false-positives to me. But I'm not used to >> sparse giving false-positives so I think I might be missing something >> here ? >> >> On 4/3/23 22:39, kernel test robot wrote: >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >>> head: 31bd35b66249699343d2416658f57e97314a433a >>> commit: 0c18184de990e63f708b090bcb9fc6c0fbc427cd [3256/8744] platform/x86: apple-gmux: support MMIO gmux on T2 Macs >>> config: x86_64-randconfig-s023-20230403 (https://download.01.org/0day-ci/archive/20230404/202304040401.IMxt7Ubi-lkp@intel.com/config) >>> compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 >>> reproduce: >>> # apt-get install sparse >>> # sparse version: v0.6.4-39-gce1a6720-dirty >>> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=0c18184de990e63f708b090bcb9fc6c0fbc427cd >>> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >>> git fetch --no-tags linux-next master >>> git checkout 0c18184de990e63f708b090bcb9fc6c0fbc427cd >>> # save the config file >>> mkdir build_dir && cp config build_dir/.config >>> make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 olddefconfig >>> make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/ >>> >>> If you fix the issue, kindly add following tag where applicable >>> | Reported-by: kernel test robot >>> | Link: https://lore.kernel.org/oe-kbuild-all/202304040401.IMxt7Ubi-lkp@intel.com/ >>> >>> sparse warnings: (new ones prefixed by >>) >>>>> drivers/platform/x86/apple-gmux.c:224:48: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const [noderef] __iomem * @@ got unsigned char [usertype] * @@ >>> drivers/platform/x86/apple-gmux.c:224:48: sparse: expected void const [noderef] __iomem * >>> drivers/platform/x86/apple-gmux.c:224:48: sparse: got unsigned char [usertype] * >> >> So apple-gmux.c:224 for the commit these sparse warnings are about reads: >> >> u8 gwr = ioread8(gmux_data->iomem_base + GMUX_MMIO_COMMAND_SEND); >> >> Where gmux_data is a "struct apple_gmux_data *" and the iomem_base member is: >> >> u8 *__iomem iomem_base; >> > > The __iomem should go before the *. > > u8 __iomem *iomem_base; Heh, thank you Dan! I'll send out a fix for this right away. Regards, Hans