From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF60BE77188 for ; Wed, 8 Jan 2025 18:16:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 262E76B007B; Wed, 8 Jan 2025 13:16:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 212146B0083; Wed, 8 Jan 2025 13:16:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DA206B0085; Wed, 8 Jan 2025 13:16:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E3CB76B007B for ; Wed, 8 Jan 2025 13:16:53 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6C4DB44F2D for ; Wed, 8 Jan 2025 18:16:53 +0000 (UTC) X-FDA: 82985090706.17.E0E33C8 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by imf06.hostedemail.com (Postfix) with ESMTP id 5F59818001B for ; Wed, 8 Jan 2025 18:16:51 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=TlsUCBxG; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf06.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736360211; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=soU5Aara92WlnAsbyi1E7mvn0ItlsuKySKe7QRCs+Ak=; b=ztkW/vgaOAgeJ6g9WeecsBljzmEx6kiZzH0UQ8sGW9nbUJi8mV08lTeLX7QrDHo7B+9tTg 05UWAtLbSMzsQ9P0hly6K3nSOyAuTmAEvh7axoXpyPVlgRvuG1jJNXmZmejRDqX60945pW 8z3aUTq2ORPU+W4GbVcyKuUT+YwKMQQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736360211; a=rsa-sha256; cv=none; b=4KH6Pyni1OJXHSBwkQFNnthYJ5heSX+/EQca0mJ0nVZNuXaX7LgEpB9tUzO2vwZ9/Ncss/ /4JYAgHL32dU4YRgCMmiWagxkfdIrxSCGpd75qHrVjVmCiaxUibBY/hIVAstitpqZRZXbd SrOONH8CHcCKWyMURM6xKadL3rLC1g4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=TlsUCBxG; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf06.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=mkoutny@suse.com Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4361fe642ddso1252455e9.2 for ; Wed, 08 Jan 2025 10:16:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1736360210; x=1736965010; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=soU5Aara92WlnAsbyi1E7mvn0ItlsuKySKe7QRCs+Ak=; b=TlsUCBxGxXwcSyZ/1yGeucqOU0KMNayRIoPmnvmRt//sweuSMWCXBY3MUCoQXWJ0eq 44FYC1npwIhvIrb727jTM+aZG20zdSYFoW/s1Tbr4XJXFvWj/hGTov895Q9yx+qi0VDS NUcvAtt7YZuaSD+ketOPtP22HwGmlg6Gkx9gyHar1ZLjug+GH+eABUwI/mZfpHL0k17d Ew+Px21Agg4JEg7GCM0lZSD/VGU+uoAECucijHxmuEZSnwdO8Wb1YB6aO7HWNieat44C iQ851+2xlE5KNn1KZBdT9H1IUf4A8oz3QXqq8HhleZawXC0MDVtdrPCPDhq1Cl5NvSbN q90w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736360210; x=1736965010; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=soU5Aara92WlnAsbyi1E7mvn0ItlsuKySKe7QRCs+Ak=; b=XACGhYo3I74PsZfh68QlFCuo45CPIpGq2w2oEFkjjOACIgHtz/zRRCL40RQ7q5ONue xfz1+rV+nYCv47CTUvcJxPYkXu8y0ZQZqG5tmF0u1ilroVDPi0itA2MVOLcQ6hR6AdY/ ZSDoUNe+rwmJvg2Vy3ymdsAeDanjpvyfhQMHgH666zadXv6tLdDw4YrfQdHZY6Js/wLx OBZFfU/gbB3kbyrj7dGuzaS0ZGl803gGIAtdy7wdxR+S3cn5KjYcXVOe7Qcp9OrS7W8m VKn6ACvTTtze6OBRJspScG03gURcP6u0PBLaar8D4kZRfmnoDQMeKueV0ssJIfj8MO3g lqLg== X-Forwarded-Encrypted: i=1; AJvYcCVW4YgrgMN+JqXw0kKsjNs+pYQ9OToNOuNC08s4YTkqRDgbD5FpKtDTypNoMcVNRDwXiCkohQyjwA==@kvack.org X-Gm-Message-State: AOJu0Yz60m0SrlUZ3+zCphOtF0KolgXw6ZGiqM//Sn+6zOSJ8iAS/RZ7 H//v6b10VTbiPsJ5cGvG3ynfmz33MTaeL7F548G2FyfLtXmIJOx/6SuNZYjHyAc= X-Gm-Gg: ASbGncvfF8/VIWGwzQ12LlffOGnAdODwKq17r/JnPS8Zgnlto5/aUaBc3qFKHrbuxtT XHcNzLEizabYceHYbvFcGjO97A6Sw5uSUWyDZ6DVazTnhpJ/U28N0KJZq/cF/iTabU3ZMnty5xA I5XJG6dpkjuDkW+GJfv3JwyqQegdqwlKjDk5qvHr6qN74KFiIZX0/RHbVK4RHdkYHBR6qG9y3NW SpxiWkFRCulX6eWJ8uprYXQ2IIwvJYB0ml5+zveVOSTuCeLysIZMNKx+KE= X-Google-Smtp-Source: AGHT+IEIj31ue/KYTGsnJ4xBlyy9BFoFJWG4Omrb20HMlsr04n9iXARJ4xGdLE0yI+caz9zqtnlt/Q== X-Received: by 2002:a5d:6d84:0:b0:385:ecdf:a30a with SMTP id ffacd0b85a97d-38a873140f6mr3329217f8f.33.1736360209807; Wed, 08 Jan 2025 10:16:49 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436dd15766fsm29236295e9.2.2025.01.08.10.16.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 10:16:49 -0800 (PST) Date: Wed, 8 Jan 2025 19:16:47 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: JP Kobryn Cc: shakeel.butt@linux.dev, hannes@cmpxchg.org, yosryahmed@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Tejun Heo Subject: Re: [PATCH 0/9 RFC] cgroup: separate rstat trees Message-ID: References: <20241224011402.134009-1-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nuj5c5dsq4myygkn" Content-Disposition: inline In-Reply-To: <20241224011402.134009-1-inwardvessel@gmail.com> X-Stat-Signature: xqe6f1nntjgxcecoc57dmr3xfhuad3ax X-Rspamd-Queue-Id: 5F59818001B X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736360211-580839 X-HE-Meta: U2FsdGVkX19Jyu4jP7m6FTYJ7ExG1JNfPVAUAr6T55PE6u8NfyH6Mpq+fjuWtqE9jKXLUQYSYQyqEPHqmzF3wWQPKaNXpsiWE5CudD8DUKu6jhVnS8Q2qnYYnvF+S2T5fYVn9MW81ukhVcwx0S2f5EN84wFkz0xiiSUWtqcJyvHhNdrNzFgsuN301t31Y0Qsx+qBUUcCBKFRERwO5sK2Bf01D78WWSOILM07bA91OwSfd5ttWMWJKD/67pBfWtpIvn7IK0NhFO+PPRqQCeJlKT69ShRrSdTwsoZRnD7t2hdAtvmhgIICNajpXL9FXgLt9nXQAlcSFTGVIT3pd45oMFez0jeuZ6ucOj12JO+40QayZlq97kG0JAeNWyz6OYDq9V3nkwg8XnJ6658BNODH8uyYYj7FsR5ipnQdmK2Zt7J9KqnSdYgZufMl7gnSbMX8jZOWX5AD4i1SgvmMoi4k/H7j/Q5DgN5EXK/r+zlDpta2veTrknvMI6v+xR6U5OKQyaAM5VJe42pAcExnpA9IQoP2dUH7XnRZ0dnPxGOLlVbN/AmjhPGRGLfgvnuknPZ/STrxxUM8JejPzdGXCU/wdcoADjwMwbQEE7jcEboQS+VNqDPpjRb1bFjypaZ7xMW6AExMjTLlFLGQVs8/uBoOqneHYFAyVOvZkn1NXGYN8IX6rftYhG+mO/ooh42R6RJZUTQOXI6z56AouYbry8kAUwkanHCUwmZOrQqUtksQYuLJ9+3F9Fyzt9ww2Ndv7v3wC7u/NhqaMGMnr2JcyPoP1Qmfw/lqdfYf14JiwJY93i8tmEB3DGsFll77X20bmQfvsN2Be02sSArnJr66tDQ/HPpeplHto22byvw71iyfU9VW7hBE5Aazu+h6Q3FjzCedQ3n9N1jYgVB3mGm8um1Ipg62evN7ESQyNfElrXx67Q10eD3ihC//HzC5rQPJcFcFtpee/36xeThTfC0W6G/ 7A4lLIWY ICtRR1WPJD88dm85dfGOmgprY33vqrxBwm78CMwNhxNqCbhG11EEBXhwsiL0szTJuqFwGwp//DaEXvJKRyvXN/elyOvP5znhgvdzYBGVCe24JtFjnlWgfQPSGmXNkXrABzmeUHokd+disy3bu1Rq81KrZ2OJfKEdE08qbTgpfXlywygVKlIRfPlxzzzB8fsXLXFA2v7zQVfDiMm1Pb10ZGeTU3lvMtyOe2xC+HqHZloi8sXYfq85tyAQ5TxLMmyDQ7Cn1Ulg9KjDtSZvrFEMW4vi/LNmIJA6ouGVJHEGfekXyoAzRR9qSXGnY/ihYRJ1GVXJf+pLHUPeBZPGmllHvC0hSZ+hZ75/N/Pie2JQmdT8EtpU3sSXV/1IMTrriLSUvylYnq8OZ9p9LzsQ37khVhGPWMIMciEX6HPXRZg3z4+qpKhMB/q9KuLli1PEAM4f1U9crwx6RI5V7Wx0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --nuj5c5dsq4myygkn Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH 0/9 RFC] cgroup: separate rstat trees MIME-Version: 1.0 Hello JP. On Mon, Dec 23, 2024 at 05:13:53PM -0800, JP Kobryn wrote: > I've been experimenting with these changes to allow for separate > updating/flushing of cgroup stats per-subsystem. Nice. > I reached a point where this started to feel stable in my local testing, so I > wanted to share and get feedback on this approach. The split is not straight-forwardly an improvement -- there's at least higher memory footprint and flushing efffectiveness depends on how individual readers are correlated, OTOH writer correlation affects updaters when extending the update tree. So a workload dependent effect can go (in my theory) both sides. There are also in-kernel consumers of stats, namely memory controller that's been optimized over the years to balance the tradeoff between precision and latency. So do you have any measurements (or expectations) that show how readers or writers are affected? Thanks, Michal --nuj5c5dsq4myygkn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCZ37BDQAKCRAt3Wney77B Sb/pAQDFXBfAL18vECaAX4mKV0c7EJKLfQPefr+lla4tVBBf4gEAx2v1lATXxUtS NVJ/+TlyaiAmzhgIgnL7DybzlPZ0RQM= =048q -----END PGP SIGNATURE----- --nuj5c5dsq4myygkn--