From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CAA6C433EF for ; Mon, 18 Oct 2021 06:49:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E235760F22 for ; Mon, 18 Oct 2021 06:49:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E235760F22 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 691186B006C; Mon, 18 Oct 2021 02:49:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 61A336B0071; Mon, 18 Oct 2021 02:49:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E214900002; Mon, 18 Oct 2021 02:49:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id 3F15D6B006C for ; Mon, 18 Oct 2021 02:49:41 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id F0A41180CA82C for ; Mon, 18 Oct 2021 06:49:40 +0000 (UTC) X-FDA: 78708632520.03.03DB66F Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf18.hostedemail.com (Postfix) with ESMTP id EC53D400208A for ; Mon, 18 Oct 2021 06:49:37 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 65F60106F; Sun, 17 Oct 2021 23:49:39 -0700 (PDT) Received: from [10.163.74.6] (unknown [10.163.74.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 77CE23F70D; Sun, 17 Oct 2021 23:49:37 -0700 (PDT) Subject: Re: [PATCH 1/2] mm/damon/vaddr: constify static mm_walk_ops To: Rikard Falkeborn , SeongJae Park , Andrew Morton , Naoya Horiguchi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20211014075042.17174-1-rikard.falkeborn@gmail.com> <20211014075042.17174-2-rikard.falkeborn@gmail.com> From: Anshuman Khandual Message-ID: Date: Mon, 18 Oct 2021 12:19:36 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20211014075042.17174-2-rikard.falkeborn@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: nozf3ffab13txjhzg1mi915zymb4k6si Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: EC53D400208A X-HE-Tag: 1634539777-505362 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/14/21 1:20 PM, Rikard Falkeborn wrote: > The only usage of these structs is to pass their addresses to > walk_page_range(), which takes a pointer to const mm_walk_ops as > argument. Make them const to allow the compiler to put them in > read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > mm/damon/vaddr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > index 953c145b4f08..65d4f115fa66 100644 > --- a/mm/damon/vaddr.c > +++ b/mm/damon/vaddr.c > @@ -476,7 +476,7 @@ static int damon_mkold_pmd_entry(pmd_t *pmd, unsigned long addr, > return 0; > } > > -static struct mm_walk_ops damon_mkold_ops = { > +static const struct mm_walk_ops damon_mkold_ops = { > .pmd_entry = damon_mkold_pmd_entry, > }; > > @@ -572,7 +572,7 @@ static int damon_young_pmd_entry(pmd_t *pmd, unsigned long addr, > return 0; > } > > -static struct mm_walk_ops damon_young_ops = { > +static const struct mm_walk_ops damon_young_ops = { > .pmd_entry = damon_young_pmd_entry, > }; > > Reviewed-by: Anshuman Khandual