From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDB84EB64DC for ; Thu, 20 Jul 2023 08:37:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 269082800D7; Thu, 20 Jul 2023 04:37:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21A2628004C; Thu, 20 Jul 2023 04:37:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E36D2800D7; Thu, 20 Jul 2023 04:37:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F08B328004C for ; Thu, 20 Jul 2023 04:37:43 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B77B4A0219 for ; Thu, 20 Jul 2023 08:37:43 +0000 (UTC) X-FDA: 81031336806.08.1EE72A0 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf27.hostedemail.com (Postfix) with ESMTP id E1CA74000B for ; Thu, 20 Jul 2023 08:37:39 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689842261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fVz5Rt0ad9bvSiabSN2hJDHIOXAxi0NVs/oh/O4y9Pc=; b=ixuyNeQUoQdhwx2qGoQWKBiSXy0V6zkiZOwf9oXu+Y8z7yXPbmN2pR4pDd5XS6Vo6BCDJz DHYSV7zh/8IJNzuyeyQDT7UFKCFt4sTY+BsJyh2c55PVS47VvQPJsYoenTWTI3FUx7mn6o TmYITyGSvhry0wR3xeWlO17GBzYElYM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689842261; a=rsa-sha256; cv=none; b=zqcgvSwzZNphmp9wcg3zUgogWlGy+WM4yUxGTU1fofG7gr5i6eTimyup9B8eboA0IjB894 xMcM8Z19lqWe9bwcrtyfJgIIpOP1mcvVmEEZYKRenjUzSP2odn5IqIpF03EdE2vyEFhU41 ABOGQpk4B6ziLVUytn14KorLd330p2Y= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4R65fL4XHtz4f3q3Q for ; Thu, 20 Jul 2023 16:37:30 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP2 (Coremail) with SMTP id Syh0CgBHJ9VJ8rhkhrpDOQ--.6998S2; Thu, 20 Jul 2023 16:37:31 +0800 (CST) Subject: Re: [PATCH 0/3] add page_ext_data to get client data in page_ext To: Mike Rapoport Cc: akpm@linux-foundation.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230718145812.1991717-1-shikemeng@huaweicloud.com> <20230719094421.GI1901145@kernel.org> <20230720053736.GM1901145@kernel.org> From: Kemeng Shi Message-ID: Date: Thu, 20 Jul 2023 16:37:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20230720053736.GM1901145@kernel.org> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:Syh0CgBHJ9VJ8rhkhrpDOQ--.6998S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Cr48XFyUCFykWF15Cr4xXrb_yoW8ur1fpF WDAFyUtF4kJw4avanFyw4kAw1rtw4fJF4UX3WYkryxZa98Gr15tF1xAr1UuayIgF1Yv347 ursrta4jv34DAa7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkjb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxk0xIA0c2IEe2xFo4CEbIxvr21l42xK82IYc2Ij 64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x 8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE 2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42 xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIE c7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07UE-erUUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: E1CA74000B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 6grpepp4fniqnjwq9hthppttcyhq3qtd X-HE-Tag: 1689842259-488575 X-HE-Meta: U2FsdGVkX189lSI3Yb1X1rGE99wF3BZNO4jMsTmaND+QtX3BZ0AkgqsCAOeupullnJBaMQdltm4KHK0IE/je4UHWz4imdLvu9rX3GUGxn6EK9Bpx81vKJobUicnUAcR0r+JkVrJwhqbaAtfnM2c0DA80VUKrLXdejeyIlNfJRw4zZZ2M7OeZKnbKs/W0Q0BWKdBCaSsF42DKY04jLnBS6BAX6IKtdg+CjTW6CoKQJF3r3uIjsSuF4Sh+X+Xc+oj2Bx5riGI1KJnJpT/O04g6CUDVo8JGp7p7YP7SFOKETZGtwG55lpYEK5X1zGMDEd2b39OsSX5Yud/fHFSbWPqZti9pbT1B3BSrdWGoyhvGPqZAaG0DX8kWMchVCYsDBpcz5EGKy7nHtDfHkdFWNy9fgHpGntamXmHAM9AaDnvsPKWh2MS8o/1YyZ/RiKFlsGeZ6gpKST2KN+yDe7I33vaikGfvTLBxWE0KF5VazExEnyMh3aAWmh7Dtfycnj8xNQ/2vB/cX2sty2RmFQQweD4M3MQPKPUztyicYbcN1r/c47nBO+T43xMpie5Rz6Mg3yBpWa00UnNalGkqyFsyt22XVL+3yD5rUQEjaXzBn2l3Cc6jq4QB0eu8o9nt2FO0CcaIE7eZDFxFMt2pW5krhsj0X1g5xeUQKs53xN6zNQ/SGKMHLROmywWyXaW4B3AxAf3bF065OraVn3drwDeonhJVRJ83aDWFODlvwYVhcb2AaqfNzhYMdvb14OMv985f2GCtgGDEmXGEYrOrsF8/duY3BZw5kJCALAUyPT5Qs4CoBtSKjGyX0acpERLThXaYlvNxD973ETA1qXO3cNYTWJdCt/hn3x3ssSxd3+vgzyAiB2yalI2ghvpByyv5abGgCZy8fLexqR8dwqH4TUSRS2LWGw/7qmn6DBD8ObSXe9Mj7msJIf9EgNr6nJ/n/MMDQ8Ha7bwMTXIhT7BW5GTWMaD SRDuUa99 Pof737BobNxxJX4WRwPjKdTvkRekzh/UUx2aQEmYGhtkHmfNMPvuNWQrOt640GNTir8kwIzcyoj/h9P8p7jTx81qTmB/U9qufgaYA64Mg0vdyoH7A3sqj3G6mOrOym5rl1wa0FmIP2h162nmvJX86dKgE8K4Nd8eh/Yi6+SvXUDVptUH/OBWU+Sy6DLJ1q11uo956aDV3+j+a+rUOJKaYTaI+9qMnfwV3NwN7brq2WpI1/7Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: on 7/20/2023 1:37 PM, Mike Rapoport wrote: > Hi, > > On Thu, Jul 20, 2023 at 10:38:39AM +0800, Kemeng Shi wrote: >> >> on 7/19/2023 5:44 PM, Mike Rapoport wrote: >>> On Tue, Jul 18, 2023 at 10:58:09PM +0800, Kemeng Shi wrote: >>>> Current client get data from page_ext by adding offset which is auto >>>> generated in page_ext core and expose the data layout design insdie >>>> page_ext core. This series adds a page_ext_data to hide offset from >>>> client. Thanks! >>> >>> Implementers of page_ext_operations are anyway intimately related to >>> page_ext, so I'm not convinced this has any value. >>> >> Hi Mike, thanks for reply. I thinks page_ext_operations can be futher splited >> into public part which used by client to simply register and private part which >> only page_ext core cares and should not be accessed by client directly >> to reduce decoupling. > > It would be easier to justify changes in this series if they were a part of > the refactoring you describe here. Actually, it's not the refactoring trigger this. I found offset used in client code while I could not find intialization of offset in client. After some search, I found how offset is generated in page_ext core and it's more like a page_ext internal behavior. Feel it's better to reduce dependency from upper level client to low level internal implementation. >> This series makes offset to be private which client >> doesn't really care to hide data layout inside page_ext core from client. >> There are some concrete gains I can list for now: >> 1. Future client cound call page_ext_data directly instead of define a >> new function like get_page_owner to get it's data. >> 2. No change to client if layout of page_ext data change. > > These should be a part of the changelog. Yes, it's better to highlight the gains. This series was taken into the tree. I'm not sure if I need send a v2 to include this or Andrew could add this when code merged to more stable tree. >> I hope this could be more convincing to you now. >> Thanks! >> >> -- >> Best wishes >> Kemeng Shi >> > -- Best wishes Kemeng Shi