From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CBCCC00140 for ; Tue, 26 Jul 2022 14:42:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B3AB8E0002; Tue, 26 Jul 2022 10:42:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 863918E0001; Tue, 26 Jul 2022 10:42:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72B1D8E0002; Tue, 26 Jul 2022 10:42:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 64D6D8E0001 for ; Tue, 26 Jul 2022 10:42:16 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 344F212070C for ; Tue, 26 Jul 2022 14:42:16 +0000 (UTC) X-FDA: 79729516272.29.01BC566 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf05.hostedemail.com (Postfix) with ESMTP id 45FD71000A0 for ; Tue, 26 Jul 2022 14:42:15 +0000 (UTC) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LsfgW57mhzjWvk; Tue, 26 Jul 2022 22:39:19 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 26 Jul 2022 22:42:12 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 26 Jul 2022 22:42:11 +0800 Message-ID: Date: Tue, 26 Jul 2022 22:42:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] mm: add warning if __vm_enough_memory fails Content-Language: en-US To: David Hildenbrand , Andrew Morton , , CC: Yongqiang Liu References: <20220726072451.142427-1-wangkefeng.wang@huawei.com> <18dc0807-5596-3aad-350d-3673a033bca8@redhat.com> From: Kefeng Wang In-Reply-To: <18dc0807-5596-3aad-350d-3673a033bca8@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658846535; a=rsa-sha256; cv=none; b=eOp5VfUCZI2N0lnV38mFuZgfoIou6iH02z/LW6U8mIpLtQyOr+vIwDMzJc7KVFhl2uPMGZ QtDO8qAfPdnu1Sk38+UFnC0XCsKxYFmMux5+/LxKcrOvoU8X8WfYVERlyuUOKC6Lwxf1lE T1pRBmECMwvd7HKkns9qesNlEtRDfPs= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf05.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658846535; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3zu9hm2XRkVnwg2hK09jSQPz7yim5VSWphrjf2BBEyo=; b=q1/+xqxz1yLf8CUOdJCZhoxt0ExOLEDHchThibUwLWSqvacSd2p6q4bfPr9fye83VtboLc vwEvwQtDa5LvUNMlTCYGNvtHCUquWNbjssi0SAkWVtE3Xdq1hzO12Zz2Xc5dIxsl+R7Wg3 WvFcWTHfpPDUiIYIbaJ4qGK+Khwxr2c= X-Rspamd-Queue-Id: 45FD71000A0 X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf05.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com X-Stat-Signature: 37mbhiaagbodstxuzpawzush3uhta1xx X-Rspamd-Server: rspam03 X-HE-Tag: 1658846535-782976 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/7/26 21:45, David Hildenbrand wrote: > On 26.07.22 09:24, Kefeng Wang wrote: >> If a process has no enough memory to allocate a new virtual mapping, we >> may meet kinds of error, eg, fork cannot allocate memory, SIGBUS error >> in shmem, but it is difficult to confirm them, let's add some debug >> information to easy to check this scenario if __vm_enough_memory fails. >> >> Reported-by: Yongqiang Liu >> Signed-off-by: Kefeng Wang >> --- >> mm/util.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/mm/util.c b/mm/util.c >> index 1266a33a49ea..19bfff8a0ad6 100644 >> --- a/mm/util.c >> +++ b/mm/util.c >> @@ -1020,6 +1020,8 @@ int __vm_enough_memory(struct mm_struct *mm, long pages, int cap_sys_admin) >> if (percpu_counter_read_positive(&vm_committed_as) < allowed) >> return 0; >> error: >> + pr_warn("%s: pid: %d, comm: %s, no enough memory for the allocation\n", >> + __func__, current->pid, current->comm); >> vm_unacct_memory(pages); >> >> return -ENOMEM; > Users can easily spam the kernel log, no? Maybe at least ratelimit. pr_warn_ratelimited is better, will update, thanks. >