From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED74EE7716B for ; Wed, 4 Dec 2024 09:28:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CB4F6B0083; Wed, 4 Dec 2024 04:28:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 87B5E6B0085; Wed, 4 Dec 2024 04:28:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F4F46B0088; Wed, 4 Dec 2024 04:28:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4F9D86B0083 for ; Wed, 4 Dec 2024 04:28:49 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D0AEEAE6C5 for ; Wed, 4 Dec 2024 09:28:48 +0000 (UTC) X-FDA: 82856751642.05.8D3728D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id F314A120008 for ; Wed, 4 Dec 2024 09:28:25 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Uhn6yP1W; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733304515; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AXkcsNssBDIkoyIUFa6gbYj8t92+fIKYw2rEYcDaoyk=; b=b07jvMFh0OMEnqrnyU1l6806Cb0PVMtcH/tJLNloa4zXzY+cIREYkU9aCD+cyLWg4QIu8p WTZW6WHdIgDaJljaxx8um9ijQrCZqOkEwiYebBpaVZGtShK+pD5s/ILxcUwRSVMi+NPWte R3W+qFm+z9XAKJ9wIwX89tTzsp4jdKU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Uhn6yP1W; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733304515; a=rsa-sha256; cv=none; b=Rw+TRxjFT19kN0NTdXJ3rokVaktto4k8k1XheErSI5nWVycx2DG8G6dnNZPytzWx0fZIna fita6q28yqdIqfzLcBmnoOmk6IDZk7V0krZN8+lXUIXpU5sSs/3esteemOs6cbtyPt1ytA h0VfWQgua30XsKeZauuNkisSI26vsqw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733304525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=AXkcsNssBDIkoyIUFa6gbYj8t92+fIKYw2rEYcDaoyk=; b=Uhn6yP1WRI8Nm8mrvC+qNexisDX3rxbhKySJ0xuzV1PnRnzso8holjU0cveGGyDotia4gL 1nYOpTvfVE0O1t9+soZ8sNxxfO4SZMDzamRqWU9aGdluBpSQfRbXpUJvr/IS1xLKcKVtP4 UQ/OTC92ukqoRlfSQ3ixApagqVTIGV4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-308-g17Lf0yXMLmNU3uqnFOirQ-1; Wed, 04 Dec 2024 04:28:43 -0500 X-MC-Unique: g17Lf0yXMLmNU3uqnFOirQ-1 X-Mimecast-MFC-AGG-ID: g17Lf0yXMLmNU3uqnFOirQ Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-434a4ad4798so48496605e9.0 for ; Wed, 04 Dec 2024 01:28:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733304522; x=1733909322; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=AXkcsNssBDIkoyIUFa6gbYj8t92+fIKYw2rEYcDaoyk=; b=Oy4/g7dtZahH25vQyDyeB6/fqwNfla0uZKNd4Zqop4U3fOnjFUgvOsqMhB+SZqrc1J G+a9bnK8Ls2ex1IQTLWlEhAp5sdlY+PmUaWTA4d/Yq6+lLXC6IFZfuaOO1CbhA3PYJSM v5zseCqFbFfv9WoODu2i6SKtukGDMErlIoVkEr8uuFef+p7TqdvV4wlif6FN4qsIpx1H bA1+dQq0ipRUzS1itHxfxhslKrQ0xVDr0ST+QylIGsni0KC7G2wVBomFZXfCibMoviWp haNrea30KMfYvi0z7vjyB1s6gTgRUqHtLvc7SmZ+VZ1dDigd+aaSI4oxAabLLo4Uuw9a IoCw== X-Forwarded-Encrypted: i=1; AJvYcCUuVx12GIwpuAyj60O39F4R2PdwSENFJwE+Mhi0hme1zEsGJOa422IpnVagbaA3ZrhR15se8zgc7Q==@kvack.org X-Gm-Message-State: AOJu0Ywp3bFj12rTHm4xblKYaK6ffrBIamm48CjtpervQXXGbFkWx9pm 1YKS81BhiEvN23ceaetNnlpPSnErwIGMeh87rymwvjelnUib5nAgXYRBVkmyMN2/nS6JhC7fxlh NDy9kB4EvVnkppWOW3t/cWR2L/FPYoWsDXXZH1iSS6jZd3u36 X-Gm-Gg: ASbGncs+G3gD8d4U8fPw17+uJlUwc+zHPHCf5WG48Xw0nU9ZfcYb4R7kQMRmhZUa8GG Uu8f0Zeu8NacK0f4Bk8IS3DCYEBDHekYk8lh3uKs/czuyYR3YL5KNLCbZHLBpOWuNDtdOeootRB Hz55en2xQrfznyq2HsJM3lOe5JdZpK5KUZf+XXZEFevz9nfzXHTR9Ius8wnUyrKGZOTk9A0ktAt jm3EGzboMqj6hUNuqv2IqDfoROtv1dQiPalK8exqCOlojKNhY6/jWnxNecwByZOgb3sImHvwwXo HtEkNC17OfGPuC/1ImboT6JuiXXZVrnpGhFNl/PUHZC0fVav9eIX8vdJst3sFap3RWAAzaIdapG fZA== X-Received: by 2002:a05:600c:3554:b0:431:6083:cd38 with SMTP id 5b1f17b1804b1-434d09b0020mr48636895e9.6.1733304522268; Wed, 04 Dec 2024 01:28:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IEujwNpRBwluk2zpQ1Yet+Ecjg4bwyX/zVe4UezRqTVJMMizFZiaTPX/p8MoKgtkYxHhiPB0g== X-Received: by 2002:a05:600c:3554:b0:431:6083:cd38 with SMTP id 5b1f17b1804b1-434d09b0020mr48636675e9.6.1733304521850; Wed, 04 Dec 2024 01:28:41 -0800 (PST) Received: from ?IPV6:2003:cb:c70b:e100:38d6:8aa1:11b0:a20a? (p200300cbc70be10038d68aa111b0a20a.dip0.t-ipconnect.de. [2003:cb:c70b:e100:38d6:8aa1:11b0:a20a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434d5307400sm17785025e9.38.2024.12.04.01.28.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2024 01:28:41 -0800 (PST) Message-ID: Date: Wed, 4 Dec 2024 10:28:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v2 4/6] mm/page_alloc: sort out the alloc_contig_range() gfp flags mess To: Oscar Salvador , Vlastimil Babka Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Andrew Morton , Zi Yan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan References: <20241203094732.200195-1-david@redhat.com> <20241203094732.200195-5-david@redhat.com> <96c92857-4850-4f85-9474-ac193c5ea48c@redhat.com> <04c1d28e-bbea-4499-9a6d-770f9ca53ba9@suse.cz> <15096b27-6f27-45fc-8a8b-de781a9c42a5@suse.cz> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 92y9vD9D86ahQUJ4wGePRip1wDbl0-cFckb72oHZAbQ_1733304522 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: F314A120008 X-Rspamd-Server: rspam12 X-Stat-Signature: xwynpd1fj7oz5cyufqj5ws7keewya78k X-Rspam-User: X-HE-Tag: 1733304505-384952 X-HE-Meta: U2FsdGVkX1+k+acPByOEwxZaWa/B6HUl+Drce3pF2LG/dCaW1S/6Wjq7c9ZlwfmkTlLeslzyzTHwenFuDmVNHnK02Eq2dl0MA2OkmAX8Z9fN4QdiuAdg7UR8aRPX+Q9E2k+uRzktbTJ0oweP2I69AzFpX1H9GBgfpJ5u8Yu7G7DfZEI8Iv7vxsppXGuO8fqBpXQANFa/uuUy4n2N7kwU3BGuc2F5HmRPs5tx3iVDEQP+orBZvkfZ/gt3uowRu/bGrwIBoPlxTwFESWLLrPri6KQLD9BMbzpZ2q2XZfWXmY1FF8d0Gkb+H0cjCKL+Ka2gugJseSMyfQ7FjdzUiLwxcP/vJumXLFSOB4TzQIa5R2/00pJ3CTn2yT8MNeMHt4D1005JB70trVbZgb5d3DHHStuC/syQ/G3Fk6iSh5BGSYLc0W9Ur4+RPKnCALsf4jNAAv8ReqMKWW+1J02M+8AihVFFctpF3P8i1MerBGS3pPeubGlsQUN1bLRSeufzD7kwZKj/Nmh4ogHFtkjsTfaTYvBOxw8SOgMqTNMeXlbaBeOa/wV+YK9gjoTCv7dMcq3vlI1MMD/4bui8d5oFVpoFUX5Za4eGNKo2RwvVcgaIElnd7nGNjE9Q8RWY2fDFDkygP3pcBrdnPeureRXVllmj2beSSn9n8ayeEGNENrR+e9Av0bgp2ks5/xkop+o8aYSlWmOCoGIOOVtSkIEweBk3UPZ/MWgWCDZtgLHP+jqVs/vvJGXcmTRwVE6LfZzDwidMBnzSEyUUgRWkssq2iMgtLe5P1RTg/IkMN5OmaXnCJuKVSKvyJDIt9WY+sXl2L70iZ2iiCO7OVzQGK/Gx+vwuYSaHqP6vOBPOR0KMnobyfktMMErojfp6TvoAnhtHgI8XQd5gHgTAtNCAioUhMnUgXcfZ0cbnD1scrZF06E5Zn89TlhOkELn77/f6gybmyZFI+Co4mE/UArOCihmemqh T99nbR/S WV81WRTkVYo7Gyqvhr7SqKitwXNm7aFey/v5g2MeW4oPwzQFTwGTKQYS/35kIskxMGEuHkMhSiXW6es0RO9fYOs0IomsXrAs9sHWcQp/IDcH5H/Yx9anK2K07hyqkbmLBC4pHQs2Ee+WqHVy1fMoBAvQPUIzQfAUE1WG6UH5hazoiEFmdKjBupISUs4Q6NNHa1jNcUkg/pT9vlQFKegCP8xoxmb5tSfTFGk1UPl6r1dbF4K4RXQSfa/XpqyBx6nvnuqgbNoxGvJBtQLRaRZdJo981loDBrYoANJUgNWsupESZzGW1ZiFMwf1paFWxiQN2FAfLrbAajEbgtVXPwybYXQC80mmL5BfOLp3amP1JQtsoHem0Hm2eqtDmvcfoXS/BNek+t/qRMe1Byplpx9yJccFuF+rKuoqXrPui8NsFepAAMGZ71L9gsupuMvU9DIbNhr3DkID0tlVsCSDv1GYul5l3nQ1rKhdPHKXJefmAUOm9WcGY/F5bwWhFxmFMgADn/DFw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.12.24 10:15, Oscar Salvador wrote: > On Wed, Dec 04, 2024 at 10:03:28AM +0100, Vlastimil Babka wrote: >> On 12/4/24 09:59, Oscar Salvador wrote: >>> On Tue, Dec 03, 2024 at 08:19:02PM +0100, David Hildenbrand wrote: >>>> It was always set using "GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL", >>>> and I removed the same flag combination in #2 from memory offline code, and >>>> we do have the exact same thing in do_migrate_range() in >>>> mm/memory_hotplug.c. >>>> >>>> We should investigate if__GFP_HARDWALL is the right thing to use here, and >>>> if we can get rid of that by switching to GFP_KERNEL in all these places. >>> >>> Why would not we want __GFP_HARDWALL set? >>> Without it, we could potentially migrate the page to a node which is not >>> part of the cpuset of the task that originally allocated it, thus violating the >>> policy? Is not that a problem? >> >> The task doing the alloc_contig_range() will likely not be the same task as >> the one that originally allocated the page, so its policy would be >> different, no? So even with __GFP_HARDWALL we might be already migrating >> outside the original tasks's constraint? Am I missing something? > > Yes, that is right, I thought we derive the policy from the old page > somehow when migrating it, but reading the code does not seem to be the > case. > > Looking at prepare_alloc_pages(), if !ac->nodemask, which would be the > case here, we would get the policy from the current task > (alloc_contig_range()) when cpusets are enabled. > > So yes, I am a bit puzzled why __GFP_HARDWALL was chosen in the first > place. I suspect because "GFP_USER" felt like the appropriate thing to do. Before: commit f90b1d2f1aaaa40c6519a32e69615edc25bb97d5 Author: Paul Jackson Date: Tue Sep 6 15:18:10 2005 -0700 [PATCH] cpusets: new __GFP_HARDWALL flag Add another GFP flag: __GFP_HARDWALL. GFP_USER and GFP_KERNEL were the same thing. But memory offlining/alloc_contig were added later. -- Cheers, David / dhildenb