From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A9A9C369AB for ; Mon, 21 Apr 2025 07:42:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04D556B0008; Mon, 21 Apr 2025 03:42:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFD7C6B000A; Mon, 21 Apr 2025 03:42:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D922C6B000C; Mon, 21 Apr 2025 03:42:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B6C526B0008 for ; Mon, 21 Apr 2025 03:42:46 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 45938B9FE5 for ; Mon, 21 Apr 2025 07:42:48 +0000 (UTC) X-FDA: 83357259216.05.FB2449B Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf21.hostedemail.com (Postfix) with ESMTP id C62FB1C0008 for ; Mon, 21 Apr 2025 07:42:45 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=F2yUarBY; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf21.hostedemail.com: domain of quic_zhenhuah@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_zhenhuah@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745221366; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Uda27OR6jl0Qtu3XrSgAsNeJj/Kw9HnJ8gdvEdHRSF4=; b=lrnfum/HOpdbQBnzJKkWeoIZkLBHRxdY6KZwxTM1YANSrAtnRSPzNoPHyiIIQC2g21rI/v SUSqJqgjof/s1bGkfXVcaPp+Mg9+GOHwUkjHB509cS6qqZUYxg98YbXVumogsMLojExeZj jncNnq+WhrIYfVc6zMQs0yqHqQGyF/k= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=F2yUarBY; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf21.hostedemail.com: domain of quic_zhenhuah@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_zhenhuah@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745221366; a=rsa-sha256; cv=none; b=R6wgvoBtS5tbzSPIlFWRwbJ/Vw5nTp+wQ1s97fgLna8DlF/l6C0X02XzL73iGgpgAO+sw6 UuucWbSt9xR7YSWcXd5pZzptnsBm9JUWtT0i9SZs4IQAH3gc7cYnOMrs1mq/wN4yDPPnZ5 zVkdiASReJJRmHP2fhZObY2hIcdF2dw= Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53KNDt89025922; Mon, 21 Apr 2025 07:42:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Uda27OR6jl0Qtu3XrSgAsNeJj/Kw9HnJ8gdvEdHRSF4=; b=F2yUarBYjb+LQ3d2 V2lAUDqrg0jWn0XcZW25Z53FIFZEss70bgzq6J0rz2sAaVMSXaKWrhLMn3qzMGkK OkP8x/GUns5LxP6z4cP6NqpuljJlHDCBaXIWVr9WOG+bu7XPWlTX3DkOYD0jDGdb 9/QHFjuOQ7bF6xn2wmi5hxtEIadNmMOxOFuAKW6OlEG5q62dKaNHyYEAdd67vtdW sAsU2axmFuRsPeXwis/869V5OgFJ5pPfq/r0keXgZ0UNAzfbim0RXhP2XPtb4mfj 2YI0yXga7KIHKKTGaNykWuRDA0Taai3vJra0MwJh6fpr2UWEtBZiN2GomoPWP/CC OWa0Yw== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 464426kb2e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Apr 2025 07:42:42 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 53L7gghw004059 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Apr 2025 07:42:42 GMT Received: from [10.239.132.245] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 21 Apr 2025 00:42:39 -0700 Message-ID: Date: Mon, 21 Apr 2025 15:42:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm, slab: clean up slab->obj_exts always To: Harry Yoo CC: , , , , , , , , , References: <20250418061459.3898802-1-quic_zhenhuah@quicinc.com> Content-Language: en-US From: Zhenhua Huang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: QdMRYimzp7ELfGaPx9J1Lx3SlfpZrx1O X-Proofpoint-GUID: QdMRYimzp7ELfGaPx9J1Lx3SlfpZrx1O X-Authority-Analysis: v=2.4 cv=IP8CChvG c=1 sm=1 tr=0 ts=6805f6f2 cx=c_pps a=ouPCqIW2jiPt+lZRy3xVPw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=COk6AnOGAAAA:8 a=yPCof4ZbAAAA:8 a=tUVUhsVVWxwbZEqO3ecA:9 a=QEXdDO2ut3YA:10 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-21_03,2025-04-21_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 spamscore=0 mlxscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 bulkscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504210059 X-Stat-Signature: ajsy9znpiwbh8qoi3ym8cyc4jztsqmqi X-Rspamd-Queue-Id: C62FB1C0008 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745221365-906743 X-HE-Meta: U2FsdGVkX19ENExHDSMKMkVvn/PWKbyXfe9phrhCp9ze6x3l6QEnapDKKhbZqdvCwdNDcnRTM4qcmiVL4KU6+yV4iRM42e7D+BvklN1MH1Xh+lIdMrTPu2obIQ5V2XJIRyjy3kLEWzii2xTzbQ0vBcqCeNF3FlUUzC65J3pbvgBEs8NE5IYcqreO8ymA4rQsVwBvImamJ/pujOqqRCrKMkpXEFDqSe7ESGCdE36+FfwPAOplM2f6jSoXjxkWsFm4Ame72yRGxY5MQYcvT6XkCwnV5rejxaU+GM5gUhj+01cT51jrmAXEbm0qPjDPdpFxPDJZb7NwzlevQjmlPxXuO3ap1D5EXLyJnEtkgGcggvwZ5fsb8xjhhizvww3eYuCZuOaGgHmVo+7QdOOvXa9DwzHj/i580gnOknV3hTquXTNy+/rfg4p6M+G87HcDUZhoxPb4vsp1nxA8ZPkChoQTKHdFMfNV62a7GHgg9kpFdGkXDuQ32CBK4f41eNLLuWaDGGIAOH2VJ08LoQOrEnaRoKPHiRuyBGIb9Ysws3xFEZcJyBN3+4yVp5RnUoBdiqlZ3N2fRYOiuggvWbB8r1yI210765c6vkvSxo64iGmJxW6RSsn1mfvxc7eggbD6zSiZgc6acOke96D1uWUOfsryFAwPxaWggqVCNkV6pYzs7Ipy5j38n4CJBDqfRpztoCFXldjQcWWs9dQxKBvoAE+mxpEnbUSyucFy6lOsppw/SUfC11Eq+BVT37ySQwvgQ8SDY1jbOLlxDPlj5C7urKVC4yt2TCdoQ84SsIsTQrraGJCyAP3aQkAvdUe9aYGOonqeP/6qg0js74DN693aKTHaaIXuIWeBSrJW793hBezIfgY5O1E9s5SVnWFeUPddcCFJJyVa9M4zEJriivuanFIiz+x66L2S7DQj7J49YOtJE39jiMYNCte0X4Du84niaFpZ3G3IzBfhhzFezF7TDv8 nAuoWWvN S7seeMaStvFjM4ES0Wz55HOEH0QAtx08IuJ7ziIMDp2fx8KSLECmvOo9v3xjGM9PngOfexP+wbqFcJNraJObGlLdY5BZS5+BM/46qFOO07IEzTgbciwvk2drDE/SHoZt+4Zw66IPtiP/r2WJBBNIKemoe6TaOpAGfRk1evzmgmjsmjdiT+VuVUozwdl+Qigfw5gaGG6oEIViqv73elWeoYp8OsunFy7wo7IT0xHmbuzRfREBuuTIGLAJsiVy6kqrlnYuvS4SjUDRRIXORFiM7D2uf/s61PAYwV/krTIYSD3fAdNiF4trJX66RUMeQaIrs1pnTLrBBVOqbTxpBliVNWvUremWnxxt5OktxsQd4+qJN8OyDrtcyjk8VGS131CoJSFEf303JkEU9NyDKItacAVd8vPpkbUn72C97sD8PJDBS3z/Z2trgLw25Bg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/4/18 23:17, Harry Yoo wrote: > On Fri, Apr 18, 2025 at 02:14:59PM +0800, Zhenhua Huang wrote: >> When memory allocation profiling is disabled at runtime or due to an >> error, shutdown_mem_profiling() is called: slab->obj_exts which >> previously allocated remains. >> It won't be cleared by unaccount_slab() because of >> mem_alloc_profiling_enabled() not true. It's incorrect, slab->obj_exts >> should always be cleaned up in unaccount_slab() to avoid following error: >> >> [...]BUG: Bad page state in process... >> .. >> [...]page dumped because: page still charged to cgroup >> >> Fixes: 21c690a349baa ("mm: introduce slabobj_ext to support slab object extensions") >> Signed-off-by: Zhenhua Huang >> --- > Acked-by: Harry Yoo > > I reproduced the issue locally and confirmed that this patch fixes > the issue. > > Tested-by: Harry Yoo > > By the way, I think this should probably be backported to -stable? Thanks Harry, I'll send another patch that incorporates Suren's suggestion as well. > > -- Cheers, Harry / Hyeonggon