From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA54CC02198 for ; Tue, 18 Feb 2025 12:33:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39136280128; Tue, 18 Feb 2025 07:33:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F36E280124; Tue, 18 Feb 2025 07:33:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16CCE280128; Tue, 18 Feb 2025 07:33:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E4861280124 for ; Tue, 18 Feb 2025 07:33:09 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CEFCB50834 for ; Tue, 18 Feb 2025 12:33:08 +0000 (UTC) X-FDA: 83133005256.12.BC4164E Received: from fout-a3-smtp.messagingengine.com (fout-a3-smtp.messagingengine.com [103.168.172.146]) by imf08.hostedemail.com (Postfix) with ESMTP id C0C49160008 for ; Tue, 18 Feb 2025 12:33:06 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b="k 4Ivd2I"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=tdRnouMm; spf=pass (imf08.hostedemail.com: domain of kirill@shutemov.name designates 103.168.172.146 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739881986; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=28yRX83oWy8XKbFVALI7tpeopwOBxQY89HUmWnOuufI=; b=PdFfh0p2j8fuBFb7QmNH2b6BkUDIKZrLLvDFA16uapQl9k48uBQEd5/IwUFT+F+hdJKAIa EcTBbTw3dTCeD6Czi6JBFhgBnB2LytmVa4SW9igC2ryWGmE6CCCCICm+tqwnZDLiIjmrPX jQhwxaFFmv3EXBLEkicFcrdPiiv4EZc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b="k 4Ivd2I"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=tdRnouMm; spf=pass (imf08.hostedemail.com: domain of kirill@shutemov.name designates 103.168.172.146 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739881986; a=rsa-sha256; cv=none; b=I/QsmCsye493E5lztmp0Ce+W8RGG34QSubQRqdfjNb4P0RAouJnVZy522uIm0UfEpsGa+v mmmsKGgYdE5XmMbPLVLLEo58Bq3hEKr1ns+prve3Ku7AA52TiaBV9ZXO0r0+6y31un4tkQ nhCPBdAHRpF305P10ahgQKC1ZVKJvN4= Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfout.phl.internal (Postfix) with ESMTP id 26FAA1380A30; Tue, 18 Feb 2025 07:33:06 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Tue, 18 Feb 2025 07:33:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1739881986; x= 1739968386; bh=28yRX83oWy8XKbFVALI7tpeopwOBxQY89HUmWnOuufI=; b=k 4Ivd2Io2ISFOMlEcM6QW8uX1W04uRBe6cyikRg1yUumcQzqIQKxDFZuDM3S3ENt9 QrxMJ4urvbq/3dsGzV1M7Gs4+55sp5a3EF2vXEV+iAkdqUa6FW6YtJfD1MSIlzi6 zP/Gb58aU4fH93xuvJaZVMhba+bKggoMRDNJkCqGmvTWS2DYjFjO8zuFL+9BFhGd bfGr6vtVvZhcodPIiRh9rimPbA2/9zYratr+2J9QnaFkEFNNNtBsvJPnkZUM65wb 11HYRfy0jexD/n2Ts+kF1Wj9gsXfp8fw5jL+PVD3aP7APvxNdQYOlCIr4BP3YJSB todkdMyoMGZ5uxw4vKKhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1739881986; x=1739968386; bh=28yRX83oWy8XKbFVALI7tpeopwOBxQY89HU mWnOuufI=; b=tdRnouMmvB00wKWqqjIfD9DuQjO1oPw2Euvos6aajrdecbNZCks ZiEstQOTbaeD2ts7kF7fGpXNmaIPGPCW5muIZac3Nn068IQdam4FUYyE/KPaDY4j DgXoEMiDTadTsfVe7+6LzZ9M265Ep4YzjcrTAU6XGDUT7zSW+xsf2VdHZ2Hb66Xm SYxvvlEeVeG6OpZ9/+ru3x0HC2ICXaSCfh8P05OBWcpc0Y2hNT41aC86UFF3oGLy 6d07wHJTJ0JkVWaNgWEjeTJZXwOdH0r7EXLF+162ZXsopY1rsX9dQQrL+hSXaFzD l5Oa4eL1BnJ8hkpqG8pG4BD0jGsGY7mwjyw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeiudefvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvf evuffkfhggtggujgesthdtsfdttddtvdenucfhrhhomhepfdfmihhrihhllhcutedrucfu hhhuthgvmhhovhdfuceokhhirhhilhhlsehshhhuthgvmhhovhdrnhgrmhgvqeenucggtf frrghtthgvrhhnpeffvdevueetudfhhfffveelhfetfeevveekleevjeduudevvdduvdel teduvefhkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehkihhrihhllhesshhhuhhtvghmohhvrdhnrghmvgdpnhgspghrtghpthhtohepjedp mhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepjhgvfhhflhgvgihusehlihhnuhigrd grlhhisggrsggrrdgtohhmpdhrtghpthhtoheprgigsghovgeskhgvrhhnvghlrdgukhdp rhgtphhtthhopehlihhnuhigqdhfshguvghvvghlsehvghgvrhdrkhgvrhhnvghlrdhorh hgpdhrtghpthhtoheplhhinhhugidqmhhmsehkvhgrtghkrdhorhhgpdhrtghpthhtohep sghrrghunhgvrheskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrh hnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepvhhirhhoseiivghn ihhvrdhlihhnuhigrdhorhhgrdhukh X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 18 Feb 2025 07:33:02 -0500 (EST) Date: Tue, 18 Feb 2025 14:32:58 +0200 From: "Kirill A. Shutemov" To: Jingbo Xu Cc: axboe@kernel.dk, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, brauner@kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk Subject: Re: [PATCH 2/2] mm/truncate: don't skip dirty page in folio_unmap_invalidate() Message-ID: References: <20250218120209.88093-1-jefflexu@linux.alibaba.com> <20250218120209.88093-3-jefflexu@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250218120209.88093-3-jefflexu@linux.alibaba.com> X-Rspam-User: X-Rspamd-Queue-Id: C0C49160008 X-Stat-Signature: q74grngh5mqdcbwyfbtpakiebia5btob X-Rspamd-Server: rspam03 X-HE-Tag: 1739881986-565373 X-HE-Meta: U2FsdGVkX18O/WB+e2JpcJ4PA2uvDTEHlmlbJEWnQIX1JHhH5Ul2d+20a5Cz7FABJZG6dIxCKV/DULE3Uoe59xUHU1PnZl1zV4Bn8YKbPUBx0v5xreAIOBxfq/F1Ag1y5t0544DhFeFYGgu9u3JpM0rA1gVvvAJ/OMPYSqxgeVSgY3Pp/HrIj+VXkEHs1S+XuPfyMKoYUx5jCJ1AO6mvvwbDeyScNnK5mrkx8nN8YeimSj3YdCYUrPTuqOk2qWRHwugJqyLau21GGyyHcxjjL0MntmXsaoLAz6qjIhWcJITpn6ZCl8liOFPDf59T0Dqn4uydPoOgYtV3ivDABP+rawJh4vJScwQy1dbBvMCrFObJRJWgEg/koecDb6K+bmTGjg2NwEQEp5uEiYtc/+GORjW9rHW25GqDeuj8f7YFitCQTwtAa/hI+C2iodE8AYIb1ujA83wH/CYbL4VeRJF+WXvRFfg3hYOtCeOuK2QgSiBxIPgNMIelqHcy2QYE+pJGuTZw/RA3uiOeCmEHHNtmJGruJxU7TH00fkE3zMAkR/CYeXqrmvOszEblFYK1dOyrvuk6iwmcjOLSMGLrOeD46nDS4QDHPQHS4rXILM/LdQIkxlk/CFZSFOyoZMHNRi2HLVMQ+eTo45cddh+ldTLTOhst8NnfnqJXS0zRHmgNYaZVaqceXE8a2EpShUBhZ8YhOQdEC70V3gHiesHuqQrPTpThgKktzJleil1BJUs1utS8HDcg+8FvYGguk8NqN8Xz8+pd8tkvdCb5h1xNBfQMRXuBJX381SuNBoAbu+/TuohROQ2aJZdwjIUzc5V6wlZg54oCRdZkIFaPc6ksqSVebccBrEEjKqScpnkgtnUHpyU57/5TmeM2JQCLFV0teMDj84HDHucCWq9xDMmpf3rrUv+TVERIaYfOtjCNCUq4EenZNgv47KKXTUwvbCAuWCmkiZZ1VJt1fEkCIKVIt8d HlhwJps+ 8XKVHU0KtXJdCOhf8fZt5RhCMEEUMIM7Mm7GtQvYS19t+9SKmQwT0rfoHgXyjs9TPAW5noFn8rT8WDBH486E8qgFxLmY7J6fh7RyZJzKC+1UOIvR1W1ux/x439oy3PbNKkNIv9ygfmyiGjuFNoo1DwGJWfhbV0n/LJq2dQ5h7UAYDDEdO16VzMddOhXwzdRaLb0yxJdRhPKAfkxly6VHm/wJyMkcO8aFBI473PgJ6b565QdbevQP44RvIkq4zwcGJmrVVNk+FLdy7dTvZe9A8prsi6aeVkdE8Y/7Oqa1mn1xC0pUuqQg0nvHl2La67VEfrhW+xoO5+K7UaDcWPcbUH00LeUNXQTro15uxwDyRnKFcrQ3LKAxVLnohMGLMKvHTqPL3w2AkCk7RcZW95Bp2nNNdVmJqVrsxXB0x X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 18, 2025 at 08:02:09PM +0800, Jingbo Xu wrote: > ... otherwise this is a behavior change for the previous callers of > invalidate_complete_folio2(), e.g. the page invalidation routine. Hm. Shouldn't the check be moved to caller of the helper in mm/filemap.c? Otherwise we would drop pages without writing them back. And lose user's data. -- Kiryl Shutsemau / Kirill A. Shutemov