From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 517A1C369D5 for ; Mon, 28 Apr 2025 20:52:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BEDE56B0031; Mon, 28 Apr 2025 16:52:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B97E46B007B; Mon, 28 Apr 2025 16:52:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 972B76B0082; Mon, 28 Apr 2025 16:52:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 759676B0031 for ; Mon, 28 Apr 2025 16:52:01 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3035C5FA93 for ; Mon, 28 Apr 2025 20:52:03 +0000 (UTC) X-FDA: 83384649726.23.7A0D5C5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 96FD5180017 for ; Mon, 28 Apr 2025 20:52:00 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EPQytuAw; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745873520; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j2bUXPd239Gbe+nQ3lTe/eSsnuhadeHIHUfplu2vSg4=; b=SUxmOwHE52bIa9+Nw7ur9YLm9P/hYX3tnoFU9GXNusUp8U/EYoKtb+l889Y/PfQrJ11+A4 ECzeBCBg9LlJ6yj5X8EuR/LWvJnAzzqmArzpqNe4fYqaHLZMYQVynUoYIXQMrRWwQTL+eg BVcvkltfQn0JCnThcpWLhXoV6EnhCRY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745873520; a=rsa-sha256; cv=none; b=gkKki7t+mEUZZtPEQ12o03yxiH4d8B4NUKrqfDVT1XMADK28RuTKXTXPHnunkcrqQlG33O 3ly0rUR/xwG0/cawE/69+RMURysrNAb7BeYDDyTunEpQ9KtFBBrYW2qJyhlyPmo1LHKTUa Jp+YP/mwpehou1bINr1LUBaUsMERWN4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EPQytuAw; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745873520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=j2bUXPd239Gbe+nQ3lTe/eSsnuhadeHIHUfplu2vSg4=; b=EPQytuAwpwIGfGyeRbyWyIepRMLRc3Pj6CuyCUgaEp7lIh/QvjAXgKEtfcG0usv0LYjPpL twoEBML9df0PUvvZXoBQIpNIfLqXgpfSIBs5NbqX7pyQUkjezuSdHB0nmQ9aFq7OrWI1cW u64XTSM0nXSDM56ljjgMwl4eNoUQzEo= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-347-vZVY5BSqPkK9d806-lDVkg-1; Mon, 28 Apr 2025 16:51:56 -0400 X-MC-Unique: vZVY5BSqPkK9d806-lDVkg-1 X-Mimecast-MFC-AGG-ID: vZVY5BSqPkK9d806-lDVkg_1745873516 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-39c184b20a2so1825707f8f.1 for ; Mon, 28 Apr 2025 13:51:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745873515; x=1746478315; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=j2bUXPd239Gbe+nQ3lTe/eSsnuhadeHIHUfplu2vSg4=; b=YsFELgMMijsAjtcSlx7hgo9X4lHdHJ6OOVBMzGoblSEnbv5dFNmF8vKObxVe8LOwz/ lYSehsbUKJzs4HVOFAsLkcnG/hKMTmD3N64Mf5mgIh92rZE7/GlBW//dveruzLiggogg qgRkRTFkqJaxMptliqqhMXlpsD4KV8jcDDG9glrx68r3AWeumIDRGTiFrSwY2aCcTHmi wLDaZomIO6x90HcsjsPnnru/tFzhKmyL5lxkEAvsb4H6SMyHxslVVH2+57tFKkPoqbev dCtNrjiBz6eeHINJioXejZiElzlAG43IP/c0nhtsmh7Br06EcAo2ubeuBcpHt3O2ibAb mU9w== X-Forwarded-Encrypted: i=1; AJvYcCUivFtWQAfwmSNqmytlxFyAbQ1bmRVWSyqu1KA4dhLbhtgiNUaBnTrr/eecRQJkoEsdphQMaE7Mqg==@kvack.org X-Gm-Message-State: AOJu0Yz4cxUFk39E6F9lEk2fBNLQX9shexgTsG5RD9sPefrZFYQW27+r gEDVHmpCEhR6s1vGNDWdW3bJMZWmiUgu2tZt0Ot8YaNVa7B4r09s92zk9Wdpdsx+GXNqIOpbXj0 AbE/Gnqt3dI3biztnjHun+qCkMRvXUKWTu6HF0pwCB78W6wek X-Gm-Gg: ASbGncv8iCUnGORa7RMTgnku/Nc6yaEvPeXQ2HmzzslnBww2wZ7crstiE0TV8Ca5Mgh 1KFfGt3OqYDWLp7dN20ZhuL9q7Q/hteGGyFDRD4/j/qI5U+2JZ4qfh12jw5UQoI2O3/+rpiYB7c VpVH6+1ViESktRgjeMwhE4CkkofoJRF472XJ7znXET05PjUrlJhbgQRC7LJPu/1/A0AA0lJCDq2 cDckcFWcPn+ODeydK9+J1gXJF/TkNJauZeBF6iKChsiW3t7k/hXQ4Gp5OkByXmLLU1iiBhEsENx Ni0LOWoftz5U43oCOs2whsx8uhyiQB83lNglyurO1Ohf+5JGxUN5O3PcMV6KuhIt92NDZ2CtHNc xk3q+fDIZN5XWzuprPMdfETqYcLo1K44afJ0QXJs= X-Received: by 2002:adf:ec87:0:b0:39c:1257:c96f with SMTP id ffacd0b85a97d-3a07adb1766mr5885047f8f.59.1745873515617; Mon, 28 Apr 2025 13:51:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGg/ZdNPM76QotVNqWHb1vX5+E7w/bMZCMD5F0ePmlXfZOfXKaNazuQwa6Th8wuWGKYYPw0XA== X-Received: by 2002:adf:ec87:0:b0:39c:1257:c96f with SMTP id ffacd0b85a97d-3a07adb1766mr5885041f8f.59.1745873515309; Mon, 28 Apr 2025 13:51:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:ea00:2f00:e7e5:8875:a0ea? (p200300cbc72fea002f00e7e58875a0ea.dip0.t-ipconnect.de. [2003:cb:c72f:ea00:2f00:e7e5:8875:a0ea]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a07dbd6ea1sm8050593f8f.7.2025.04.28.13.51.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Apr 2025 13:51:54 -0700 (PDT) Message-ID: Date: Mon, 28 Apr 2025 22:51:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] mm/hugetlb: Refactor __unmap_hugepage_range() to take folio instead of page To: nifan.cxl@gmail.com, muchun.song@linux.dev, willy@infradead.org Cc: mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fan Ni References: <20250428171608.21111-3-nifan.cxl@gmail.com> <20250428171608.21111-6-nifan.cxl@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250428171608.21111-6-nifan.cxl@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: u-NYn4XIycQQnK4eFHNzFb7VRr3FWeC35Ai9mUz1pPE_1745873516 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 96FD5180017 X-Rspam-User: X-Stat-Signature: zr66ewhqznjtekhsqxs7es9agc75uqju X-HE-Tag: 1745873520-293333 X-HE-Meta: U2FsdGVkX195AX1oP93RM2Tc0638vGxAOSD/lPgzyvCSoA9fh+vrXNzlSYiaFpq9ppPjvQnOgbmk9G2xqybHjYY1B2BpyFJSgz5mEtJKK0g+P6b2G3jAuQav/V32EPCLv4bomh/8NUDUDzFALBe3i3BUe2kk0ldQABmvUtK1WpL9UYavSUWbTZMSy+zhLaRPbIuY2BzaMxI5o6PmR2CIduhXPRgoH2wnos2ZnAhyS68DkvnwIOfzcnyN5lo2Zv1206V9xe/9rlnoNYOIHCU0d9eaCzkY61oHSssDeq8AdRLaOmTpppuYOkNyBl6r7mJEDxij70b6CPzzGFmO0FD2Ub3ocsK0VdEfJdtGOjaj8942OuyUJWYy9LbjxFTktIYplUlm9CWAHXq/eoKof9Wqnsq63yOUg0cfA+QOqAeqPqKUCgHnMG/ocYb6RRqJn15drpsnuy6PsFJ6zp1A00ghaK3NsTvd1tPqkD3D6HT3EIrzJdHSFhtJTFc/TCHh2KfLT7N7d0D11JE0qVvxCxj2vt3kJZckf7zUVDJUyb+H223PXZ6Py3y7ECH67JyodM0YOz0L7JxsVfRr9VTEhbdX7O5Fk019DFPNfvkQNtghQiEf9z4XQDoiMykbEQly9OyAcltCaB1V3f5mjSN0koHMOZHQvXQXLXI7masNGDLx02vpZutRFUfhvTXF5GCSvx51ObuA/VA2iRVhGC/MwG5sDv0Wh46h4cgDl62rqjxoBpmXtHI2gYSb1RjyUbFZJ9G58k0k/ZlSOcoFJzljk5ewOrXwAmfeOjtIF1Xdnq+YoKQQKyZycjsDA7Z3swu4BPGn4wmQgBGczNL0A7+DHrrgSP2H2aZlUA6jdXyoXXglFX6jLMIk4vlWBpWOIOZXAcYtDNTayE2l+UwgER+5vmKG0+K5qMPfDTRpLbqP6cSLO83wdHzDMaILaq6diHVK5UQiyOj+cZk9FdahXAW/B7O pnEc+jj6 A85IkoDIZaajVdL6V82U5wfdFHamx+U5TLClHXaaZf69ZOwUBzf0Bl+JZT68wKIEtWfhlq7h3FKyXPGy83xVO6CTVqd1mnn7zUyYnrSHiyFBhNOSr37aBZAhzKMm8h/o47SdmerBcWJRl34mRGFCFKxxaLbn43Edas9te7GIGvvdbvqpat7FIUHDeNZjRmYoeaB2BN8ldvVTqRu3S5m6WaTY6A3mwk109Wimt+hwHi0kU0r8el+ElHNGpCNttkJMoKq/5T9SrfmSaT7VmPG69cMubd63z5Zq+m4OAlDkGMtpiIRq/7ecIrNIGCjVWJjJnsSH3l/XUvr1B/ExbMmsS9WtVfxhHuIN1+dlFwD65CcO7Pw/2KM8+scs7aMf3hXH6sI9hF/myxmwzvOtokVuQUd0hKU83A/U1kjkpgi9O1wuFlfjgiRuBUDt0RhhaMstE9jnI6DcCghtQmUKZ6vj8Idov2YYNvtz+5rIkuaO0xmYSHDa98SHQ3Cbzx8J3Mbggou/0O15SqOXHz+BJeNxXOxfe0TGY4n/spMXc6vcOtl5L9XJ/cKAbHie7j3In/FepM7xIroJhG2WmaRc6PGg9rEAE9Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.04.25 19:11, nifan.cxl@gmail.com wrote: > From: Fan Ni > > The function __unmap_hugepage_range() has two kinds of users: > 1) unmap_hugepage_range(), which passes in the head page of a folio. > Since unmap_hugepage_range() already takes folio and there are no other > uses of the folio struct in the function, it is natural for > __unmap_hugepage_range() to take folio also. > 2) All other uses, which pass in NULL pointer. > > In both cases, we can pass in folio. Refactor __unmap_hugepage_range() to > take folio. > > Signed-off-by: Fan Ni > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb